Conversation
11 tasks
…ents for accessibility Closes #225507 Agent-Logs-Url: https://github.com/elastic/kibana/sessions/0c708412-8300-4299-8a66-2934198f077f Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Address code review feedback to use aria-label directly instead of aria-labelledby with a hidden span element. Agent-Logs-Url: https://github.com/elastic/kibana/sessions/0c708412-8300-4299-8a66-2934198f077f Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix eslint violations for aria-label in modal components
Fix Apr 13, 2026
@elastic/eui/require-aria-label-for-modals lint violations across @elastic/kibana-esql files
Contributor
|
/ci |
alexwizp
added
backport:skip
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
alexwizp
added
the
release_note:skip
Contributor
|
/ci |
Contributor
|
/ci |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @alexwizp @Copilot |
stratoula
approved these changes
Apr 14, 2026
Contributor
|
@elasticmachine run docs-build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #262711
Adds missing
aria-labeloraria-labelledbyprops to 8EuiPopover/EuiModalcomponents to satisfy the@elastic/eui/require-aria-label-for-modalsESLint rule.Changes
discard_starred_query_modal.tsx—aria-labelledbyonEuiModallinked toEuiModalHeaderTitleviauseGeneratedHtmlIderrors_warnings_popover.tsx—aria-labelusing existing i18nlabelfromgetConstsByType()("Errors"/"Warnings")keyboard_shortcuts.tsx—aria-labelledbyreferencing the existing<h2 id={labelId}>popover titlehelp_popover.tsx—aria-labelusing existinghelpLabeli18n stringsources_dropdown.tsx—aria-labelwith new i18n keyadd_column_popover.tsx—aria-labelwith new i18n keyas_popover/index.tsx—aria-labelwith new i18n keychoose_column_popover.tsx—aria-labelwith new i18n keyPreferred
aria-labelledbyreferencing visible text where it already existed; usedaria-labelwithi18n.translate()elsewhere. All new strings are localized.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ci-stats.kibana.dev/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2(dns block)/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap(dns block)/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node node scripts/type_check --project src/platform/packages/private/kbn-esql-editor/tsconfig.json nibr�� ; s#^/home/REDACTED/.nvm/##; \#^[^v]# d; \#^versions$# d; tail git e get --local /home/REDACTED/.cos#\(.*\)\.\([^\.]\{1,\}\)$#\2-\1#; e t/we��(dns block)clients3.google.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack /lib/ld-linux.so.2 b/li�� nc.so.1.0.7(dns block)detectportal.firefox.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack /lib/ld-linux.so.2 b/li�� nc.so.1.0.7(dns block)google.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack /lib/ld-linux.so.2 b/li�� nc.so.1.0.7(dns block)googlechromelabs.github.io/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js it ldd b/li��(dns block)iojs.org/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -(dns block)If you need me to access, download, or install something from one of these locations, you can either: