Skip to content

[Metrics] Pod OTEL metrics table: review follow-ups from #259552 #262708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmyz merged 2 commits into from
Apr 14, 2026
+29 −18
Merged

[Metrics] Pod OTEL metrics table: review follow-ups from #259552 #262708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04ccfa
refactor: pod OTEL metrics table review follow-ups
rmyz Apr 13, 2026
c2231d7
Merge branch 'main' into refactor/pod-metrics-table-review-followups-…
rmyz Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 29 additions & 18 deletions ..._access/public/components/infrastructure_node_metrics_tables/pod/use_pod_metrics_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,32 +176,38 @@ function calculateMetricAverages(
rows: MetricsExplorerRow[],
isOtel: boolean
): Omit<PodNodeMetricsRow, 'id' | 'name'> {
const unpackRow = isOtel ? unpackMetricsOtel : unpackMetrics;
const averageCpuUsagePercentValues: number[] = [];
const averageMemoryUsagePercentValues: number[] = [];
let memoryUnit: PodNodeMetricsRow['memoryUnit'] = '%';

rows.forEach((row) => {
const unpacked = isOtel ? unpackMetricsOtel(row) : unpackMetrics(row);
for (const row of rows) {
const {
averageCpuUsagePercent,
averageMemoryUsagePercent,
memoryUnit: rowMemoryUnit,
} = unpackRow(row);

if (unpacked.averageCpuUsagePercent !== null) {
averageCpuUsagePercentValues.push(unpacked.averageCpuUsagePercent);
if (averageCpuUsagePercent !== null) {
averageCpuUsagePercentValues.push(averageCpuUsagePercent);
}
if (unpacked.averageMemoryUsagePercent !== null) {
averageMemoryUsagePercentValues.push(unpacked.averageMemoryUsagePercent);
if (averageMemoryUsagePercent !== null) {
averageMemoryUsagePercentValues.push(averageMemoryUsagePercent);
}
memoryUnit = unpacked.memoryUnit;
});

let averageCpuUsagePercent = null;
if (averageCpuUsagePercentValues.length !== 0) {
averageCpuUsagePercent = scaleUpPercentage(averageOfValues(averageCpuUsagePercentValues));
memoryUnit = rowMemoryUnit;
}

let averageMemoryUsagePercent = null;
if (averageMemoryUsagePercentValues.length !== 0) {
const avg = averageOfValues(averageMemoryUsagePercentValues);
averageMemoryUsagePercent = memoryUnit === '%' ? scaleUpPercentage(avg) : Math.floor(avg);
}
const averageCpuUsagePercent =
averageCpuUsagePercentValues.length === 0
? null
: scaleUpPercentage(averageOfValues(averageCpuUsagePercentValues));

const averageMemoryUsagePercent =
averageMemoryUsagePercentValues.length === 0
? null
: memoryUnit === '%'
? scaleUpPercentage(averageOfValues(averageMemoryUsagePercentValues))
: Math.floor(averageOfValues(averageMemoryUsagePercentValues));

return { averageCpuUsagePercent, averageMemoryUsagePercent, memoryUnit };
}
Expand All @@ -227,9 +233,14 @@ function unpackMetricsOtel(row: MetricsExplorerRow): Omit<PodNodeMetricsRow, 'id
}

const memoryBytes = unpackMetricOtel(row, SEMCONV_K8S_POD_MEMORY_WORKING_SET);
const memoryMegabytes =
typeof memoryBytes === 'number' && Number.isFinite(memoryBytes)
? memoryBytes / 1_000_000
: null;

return {
averageCpuUsagePercent: cpuUtilization,
averageMemoryUsagePercent: memoryBytes != null ? memoryBytes / 1_000_000 : null,
averageMemoryUsagePercent: memoryMegabytes,
memoryUnit: ' MB',
};
}
Loading