Skip to content

[i18n] Translate Agg_types(part_2) #26091

Merged
Nox911 merged 71 commits intoelastic:masterfrom
Nox911:feature/translate-ui-agg_types-controls
Dec 14, 2018
Merged

[i18n] Translate Agg_types(part_2) #26091
Nox911 merged 71 commits intoelastic:masterfrom
Nox911:feature/translate-ui-agg_types-controls

Conversation

@Nox911
Copy link
Contributor

@Nox911 Nox911 commented Nov 22, 2018

Translate Agg_types -> controls

Part1: #24259

@Nox911 Nox911 added review Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:i18n labels Nov 22, 2018
@timroes
Copy link
Contributor

timroes commented Dec 10, 2018

Now blocked on #26803

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Dec 14, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata self-requested a review December 14, 2018 09:03
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comments.

@Nox911 Nox911 requested a review from timroes December 14, 2018 09:56
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 7866544 into elastic:master Dec 14, 2018
@Nox911 Nox911 removed the review label Dec 14, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Dec 14, 2018
* partial translate

* Translate agg_types -> controls

* Fix translations issues

* Fix id

* Fix issue

* Fix issues

* Fix issues

* Fix long string

* Fix issues

* Fix issues
Nox911 pushed a commit that referenced this pull request Dec 14, 2018
* partial translate

* Translate agg_types -> controls

* Fix translations issues

* Fix id

* Fix issue

* Fix issues

* Fix issues

* Fix long string

* Fix issues

* Fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:i18n Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v6.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants