Skip to content

[i18n] Translate Agg_types(part_1)#24259

Merged
Nox911 merged 35 commits intoelastic:masterfrom
Nox911:feature/translate-ui-agg_types-buckets
Nov 26, 2018
Merged

[i18n] Translate Agg_types(part_1)#24259
Nox911 merged 35 commits intoelastic:masterfrom
Nox911:feature/translate-ui-agg_types-buckets

Conversation

@Nox911
Copy link
Contributor

@Nox911 Nox911 commented Oct 19, 2018

translate ui -> agg_types -> buckets

@Nox911 Nox911 requested a review from maryia-lapata October 19, 2018 11:06
@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Oct 22, 2018

retest

1 similar comment
@Nox911
Copy link
Contributor Author

Nox911 commented Oct 22, 2018

retest

@maryia-lapata maryia-lapata added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:i18n v6.6.0 labels Oct 24, 2018
@timroes timroes added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Oct 27, 2018
@timroes
Copy link
Contributor

timroes commented Oct 27, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Nov 22, 2018

retest

@Nox911 Nox911 changed the title Feature/translate ui-agg_types-buckets [i18n] Translate Agg_types(part_2) Nov 22, 2018
@Nox911 Nox911 changed the title [i18n] Translate Agg_types(part_2) [i18n] Translate Agg_types(part_1) Nov 22, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor parameter name requests.

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 8f871f9 into elastic:master Nov 26, 2018
@Nox911 Nox911 deleted the feature/translate-ui-agg_types-buckets branch November 26, 2018 14:34
@Nox911 Nox911 removed the review label Nov 26, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Nov 26, 2018
* translate ui-agg_types-bucket

* Fix name of id

* Delete extra i18n import

* Rename some parameters
Nox911 pushed a commit that referenced this pull request Nov 27, 2018
* translate ui-agg_types-bucket

* Fix name of id

* Delete extra i18n import

* Rename some parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:i18n Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v6.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants