[Discover] [Metrics Experience] Hide the main table when the metrics profile resolves by davismcphee · Pull Request #260607 · elastic/kibana

davismcphee · 2026-04-01T01:14:48Z

Summary

Closes #260680

This pull request provides collapsed table by default for the metrics profile.

A-la-carte

Screen.Recording.2026-04-02.at.12.46.03.mov

Checklist

Unit or functional tests were updated or added to match the most common scenarios
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

macroscopeapp · 2026-04-01T01:21:57Z

+const getTableButton = ({
+  isHidden,
+  toggleTable,
+  isDisabled,
+}: {
+  isHidden: boolean;
+  toggleTable: () => void;
+  isDisabled?: boolean;
+}) => {
+  const label = isHidden
+    ? i18n.translate('discover.panelsToggle.showTableButton', {
+        defaultMessage: 'Show results table',
+      })
+    : i18n.translate('discover.panelsToggle.hideTableButton', {
+        defaultMessage: 'Hide results table',
+      });
+
+  return {
+    label,
+    iconType: isHidden ? temporaryCollapseTableIcon : temporaryExpandTableIcon,
+    'data-test-subj': isHidden ? 'dscShowTableButton' : 'dscHideTableButton',
+    'aria-expanded': !isHidden,
+    isDisabled,
+    toolTipContent: isDisabled ? disabledCollapsingTooltip : label,
+    onClick: toggleTable,
+  };
+};


🟠 High panels_toggle/panels_toggle.tsx:124

The iconType logic in getTableButton is inverted: when isHidden is true, it displays temporaryCollapseTableIcon instead of temporaryExpandTableIcon. This shows the wrong icon — users see a collapse icon when the table is already hidden and clicking will expand it. Swap the icons so isHidden maps to temporaryExpandTableIcon.

- iconType: isHidden ? temporaryCollapseTableIcon : temporaryExpandTableIcon, + iconType: isHidden ? temporaryExpandTableIcon : temporaryCollapseTableIcon,

🤖 Copy this AI Prompt to have your agent fix this:

In file src/platform/plugins/shared/discover/public/components/panels_toggle/panels_toggle.tsx around lines 124-150: The `iconType` logic in `getTableButton` is inverted: when `isHidden` is true, it displays `temporaryCollapseTableIcon` instead of `temporaryExpandTableIcon`. This shows the wrong icon — users see a collapse icon when the table is already hidden and clicking will expand it. Swap the icons so `isHidden` maps to `temporaryExpandTableIcon`. Evidence trail: src/platform/plugins/shared/discover/public/components/panels_toggle/panels_toggle.tsx lines 39-67 (icon definitions), line 143 (iconType logic showing `isHidden ? temporaryCollapseTableIcon : temporaryExpandTableIcon`), lines 132-137 (label logic showing correct behavior: `isHidden ? 'Show results table' : 'Hide results table'`), line 144 (data-test-subj showing correct behavior: `isHidden ? 'dscShowTableButton' : 'dscHideTableButton'`). The icon logic at line 143 is inverted compared to the label and test subject logic.

That's not entirely true, the icon visually is aligned with the action, what's inverted is naming of the SVG, which I must have confused in the previous PR and we didn't catch it. That being said, it'll be replaced by EUI icons soon, so I'm not sure if another CI run is worth the change of the variable name

You're right — I misread the icon semantics. The upward arrow for expanding the table (pulling it into view) and downward arrow for collapsing it (pushing it away) are visually correct for the actions. The variable names are swapped, but since these will be replaced by EUI icons soon, it makes sense to leave as-is. Thanks for the clarification!

I'd appreciate a human reviewer input too before resolving 😁
I'm open for changing it, not sure if it's worth it though

elasticmachine · 2026-04-02T08:52:45Z

💚 Build Succeeded

Buildkite Build
Commit: 6d4641e

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`discover`	1959	1960	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	1.6MB	1.6MB	+76.0B

History

💔 Build #420178 failed 1a57e3d

cc @davismcphee

elasticmachine · 2026-04-02T10:47:37Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

justinkambic

This is awesome! Exploration code LGTM!

That said, one thing worth considering here is that the new behavior for all ES|QL is going to be a loading spinner replacing the old visualization, whether it is a TS metrics-* or a FROM logs-*.

Since there should be no delta for users that are writing FROM queries against logs data streams, this could be jarring for them. I am running against a local cluster, so it happens super fast, but you can imagine if the user is waiting a long time for their query to come back this could be annoying. Example:

main

this branch

…ile change" This reverts commit ff73464.

davismcphee · 2026-04-03T01:04:37Z

@justinkambic That's true, I reverted it in a690be6. We used to have a full screen loader prior to #253510 too, but I removed it since I also didn't like it. I re-added it here because there's some layout flickering when transitioning between profiles that we won't have time to look into for 9.4:

transition.mp4

But I think the alternative is worse since it will happen for all searches like you mentioned. Better a bit of flickering for now until we get a chance to look into it.

MiloszRadzynski

LGTM! Great Work! 🚀

…scover (#5845) (#6004) ## Summary This PR addresses #5845 with the following changes: - **`solutions/observability/infra-and-hosts/discover-metrics.md`**: Added a sentence to the intro paragraph noting that the documents table is collapsed by default when the metrics profile is active, and that users can expand it at any time. This reflects the behavior introduced in elastic/kibana#260607, which sets `hideTable: true` as the default app state for the metrics data source profile. Note: I didn't add applies_to because the page already has the right values, so no need to repeat inline ## Resolves Closes #5845 --- > **AI-generated draft** — created with Claude Sonnet 4.6. > Review all generated content for factual accuracy before merging.

davismcphee self-assigned this Apr 1, 2026

davismcphee added release_note:enhancement backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Apr 1, 2026

macroscopeapp Bot reviewed Apr 1, 2026

View reviewed changes

davismcphee added 2 commits April 1, 2026 10:38

Hide the table by default for the metrics grid

a2d663b

Improve ES|QL loading state to prevent layout jumping on profile change

ff73464

davismcphee force-pushed the discover-metrics-hide-table branch from b0da51f to ff73464 Compare April 1, 2026 13:38

improve selectTextBaseLang helper for scout tests

6d4641e

akowalska622 self-assigned this Apr 2, 2026

akowalska622 marked this pull request as ready for review April 2, 2026 10:47

akowalska622 requested review from a team as code owners April 2, 2026 10:47

steliosmavro approved these changes Apr 2, 2026

View reviewed changes

justinkambic approved these changes Apr 2, 2026

View reviewed changes

Revert "Improve ES|QL loading state to prevent layout jumping on prof…

a690be6

…ile change" This reverts commit ff73464.

MiloszRadzynski approved these changes Apr 3, 2026

View reviewed changes

Merge branch 'main' into discover-metrics-hide-table

f8dd542

kertal added Feature:Discover Discover Application Project:OneDiscover Enrich Discover with contextual awareness and removed Feature:Discover Discover Application labels Apr 3, 2026

kertal enabled auto-merge (squash) April 3, 2026 14:08

kertal merged commit 1c8c519 into elastic:main Apr 3, 2026
25 checks passed

kibanamachine added the v9.4.0 label Apr 3, 2026

davismcphee deleted the discover-metrics-hide-table branch April 7, 2026 19:45

florent-leborgne mentioned this pull request Apr 9, 2026

Discover metrics view now hides documents table by default elastic/docs-content#5845

Closed

florent-leborgne mentioned this pull request Apr 20, 2026

docs: note that documents table is collapsed by default in metrics Discover (#5845) elastic/docs-content#6004

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] [Metrics Experience] Hide the main table when the metrics profile resolves#260607

[Discover] [Metrics Experience] Hide the main table when the metrics profile resolves#260607
kertal merged 5 commits intoelastic:mainfrom
davismcphee:discover-metrics-hide-table

davismcphee commented Apr 1, 2026 •

edited by akowalska622

Loading

Uh oh!

macroscopeapp Bot Apr 1, 2026

Uh oh!

akowalska622 Apr 2, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot Apr 2, 2026

Uh oh!

akowalska622 Apr 2, 2026

Uh oh!

elasticmachine commented Apr 2, 2026

Uh oh!

elasticmachine commented Apr 2, 2026

Uh oh!

justinkambic left a comment

Uh oh!

davismcphee commented Apr 3, 2026

Uh oh!

MiloszRadzynski left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

davismcphee commented Apr 1, 2026 • edited by akowalska622 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

macroscopeapp Bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

akowalska622 Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

akowalska622 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 2, 2026

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

elasticmachine commented Apr 2, 2026

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

main

this branch

Uh oh!

davismcphee commented Apr 3, 2026

Uh oh!

MiloszRadzynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

davismcphee commented Apr 1, 2026 •

edited by akowalska622

Loading

akowalska622 Apr 2, 2026 •

edited

Loading