Skip to content

[Discover] Stop hiding doc viewer when refreshing in ES|QL mode#253510

Merged
davismcphee merged 5 commits intoelastic:mainfrom
davismcphee:discover-esql-mode-doc-viewer-closing
Feb 20, 2026
Merged

[Discover] Stop hiding doc viewer when refreshing in ES|QL mode#253510
davismcphee merged 5 commits intoelastic:mainfrom
davismcphee:discover-esql-mode-doc-viewer-closing

Conversation

@davismcphee
Copy link
Copy Markdown
Contributor

@davismcphee davismcphee commented Feb 17, 2026

Summary

refresh.mp4

Resolves #191885.

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@davismcphee davismcphee self-assigned this Feb 17, 2026
@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Feb 17, 2026
davismcphee
davismcphee commented Feb 18, 2026
View reviewed changes
Comment thread ...ugins/private/discover_enhanced/test/scout/ui/parallel_tests/metrics_experience/grid.spec.ts
spaceTest('should render grid with WHERE filter', async ({ pageObjects }) => {
await pageObjects.metricsExperience.runEsqlQuery(
`${testData.ESQL_QUERIES.TS_TSDB_LOGS} | WHERE @timestamp > NOW() - 1 DAY`
`${testData.ESQL_QUERIES.TS_TSDB_LOGS} | WHERE @timestamp > "${testData.TSDB_LOGS_DEFAULT_END_TIME}" - 100 DAYS`
Copy link
Copy Markdown
Contributor Author

@davismcphee davismcphee Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test wasn't actually working as expected. The previous WHERE condition returned no results, but runEsqlQuery didn't wait on the fetch to complete, so it passed with the previous results. Now it actually waits for the fetch to complete, so we need valid results.

Copy link
Copy Markdown
Contributor

@iblancof iblancof Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaslopezf I think you worked on this, so I’m pinging you in case you’d like to review it.

Copy link
Copy Markdown
Contributor Author

@davismcphee davismcphee Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a bit of additional context, this test as it was previously written would fail if a short delay was added after this line, e.g. await new Promise((resolve) => setTimeout(resolve, 5000)).

@davismcphee davismcphee marked this pull request as ready for review February 18, 2026 02:46
@davismcphee davismcphee requested review from a team as code owners February 18, 2026 02:46
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 18, 2026

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta
jughosta approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dmlemeshko
Copy link
Copy Markdown
Contributor

dmlemeshko commented Feb 18, 2026

/flaky scoutConfig:x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts:20

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 18, 2026

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#10779

  • x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts x20

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 18, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10779

[✅] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 20/20 tests passed.

see run history

@davismcphee
Copy link
Copy Markdown
Contributor Author

davismcphee commented Feb 18, 2026

/flaky scoutConfig:x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts:20

@dmlemeshko what is this magic? 😄 Can I do this on any of my PRs to run flaky scout configs?

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 18, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #74 / discover/esql discover esql view ES|QL in Discover should not render the histogram for indices with no @timestamp field

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.6MB 1.6MB -3.0B

History

cc @davismcphee

@dmlemeshko
Copy link
Copy Markdown
Contributor

dmlemeshko commented Feb 20, 2026

@dmlemeshko what is this magic? 😄 Can I do this on any of my PRs to run flaky scout configs?

it is /flaky GH action trigger, you can run it on any PR for FTR or Scout config file:

  • /flaky ftrConfig:<config_path>:<retry_count>
  • /flaky scoutConfig:<config_path>:<retry_count>

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 20, 2026

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.6MB 1.6MB -3.0B

History

cc @davismcphee

@davismcphee davismcphee merged commit ea9ad5b into elastic:main Feb 20, 2026
16 checks passed
@davismcphee davismcphee deleted the discover-esql-mode-doc-viewer-closing branch February 20, 2026 16:16
@davismcphee davismcphee mentioned this pull request Apr 3, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@jughosta jughosta jughosta approved these changes

@iblancof iblancof iblancof approved these changes

Assignees

@davismcphee davismcphee

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document viewer disappears and reappears when ES|QL query is re-run

8 participants

@davismcphee @elasticmachine @dmlemeshko @kibanamachine @tylersmalley @jughosta @iblancof @kertal