Fix: Add tags to canvas functional suite#26046
Merged
w33ble merged 1 commit intoelastic:masterfrom Nov 21, 2018
Merged
Conversation
w33ble
added
review
v7.0.0
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
Author
Contributor
💔 Build Failed |
w33ble
added a commit
that referenced
this pull request
Nov 22, 2018
* chore: revert #25921 / d76c0ae * Test: canvas functional smoke test (#25262) ~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing  * test: add ci group tags backport of #26046 * chore: shot in the dark beforeAll fix * chore: add some debug logging in the beforeAll hook, to see where it's getting stuck * [canvas/archive] remove _1 from .kibana archives to avoid lockup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
this.tagsis required now, I guess.