Merged
Conversation
allows for using a hash router with pushState and replaceState
it doesn't use basepath anymore, so none of the basepath stuff is needed anymore
hash routing will work with any url, the only part that matters is the part after the hash now
w33ble
added
review
v7.0.0
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💚 Build Succeeded |
cqliu1
approved these changes
Nov 19, 2018
Contributor
cqliu1
left a comment
cqliu1
left a comment
There was a problem hiding this comment.
LGTM 👍 The url params persisted as I navigated through Canvas. The params are removed when you visit a different Kibana app, but when you return to Canvas, the url params pop back into the URL which is pretty neat.
rashidkpc
approved these changes
Nov 19, 2018
Contributor
rashidkpc
left a comment
rashidkpc
left a comment
There was a problem hiding this comment.
Tested, seems to work well, ship it!
w33ble
added a commit
that referenced
this pull request
Nov 19, 2018
Closes #23046 Switch to a hash history manager that supports pushState and replaceState. This makes the "basepath" part of the hash's concern, so anything before the hash no longer matters. This also allows undoing a bunch of hacky fixes. This also allows the `urlparam` function to work again! ヽ(；▽；)ノ 
w33ble
added a commit
that referenced
this pull request
Nov 19, 2018
Closes #23046 Switch to a hash history manager that supports pushState and replaceState. This makes the "basepath" part of the hash's concern, so anything before the hash no longer matters. This also allows undoing a bunch of hacky fixes. This also allows the `urlparam` function to work again! ヽ(；▽；)ノ 
Contributor
Author
w33ble
added a commit
that referenced
this pull request
Nov 21, 2018
~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
that referenced
this pull request
Nov 21, 2018
~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Nov 21, 2018
~~Blocked by elastic#23046 (pending elastic#25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
that referenced
this pull request
Nov 21, 2018
~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
that referenced
this pull request
Nov 22, 2018
* chore: revert #25921 / d76c0ae * Test: canvas functional smoke test (#25262) ~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing  * test: add ci group tags backport of #26046 * chore: shot in the dark beforeAll fix * chore: add some debug logging in the beforeAll hook, to see where it's getting stuck * [canvas/archive] remove _1 from .kibana archives to avoid lockup
w33ble
added a commit
that referenced
this pull request
Nov 22, 2018
* Test: canvas functional smoke test (#25262) ~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing  * [canvas/archive] remove _1 from .kibana archives to avoid lockup (cherry picked from commit d51e554)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23046
Switch to a hash history manager that supports pushState and replaceState. This makes the "basepath" part of the hash's concern, so anything before the hash no longer matters. This also allows undoing a bunch of hacky fixes.
This also allows the
urlparamfunction to work again! ヽ(；▽；)ノ