Skip to content

[9.3] [Security Solution] Make the dataview key in localstorage space aware (#260258)#260453

Merged
kibanamachine merged 1 commit intoelastic:9.3from
kibanamachine:backport/9.3/pr-260258
Mar 31, 2026
Merged

[9.3] [Security Solution] Make the dataview key in localstorage space aware (#260258)#260453
kibanamachine merged 1 commit intoelastic:9.3from
kibanamachine:backport/9.3/pr-260258

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.3:

Questions ?

Please refer to the Backport tool documentation

…elastic#260258)

## Summary
This [PR](elastic#245002) introduced
logic to persist the loaded DV ids in the local storage. However, DVs
are space aware, and so whenever you switch from one space to another in
current `main` you get the following error in the video below.

https://github.com/user-attachments/assets/94089c8f-c35d-4734-b983-f49698e70351

This PR makes the key used to store the id in the local storage, space
aware.

(cherry picked from commit 5f5decb)
@kibanamachine kibanamachine merged commit 1bda146 into elastic:9.3 Mar 31, 2026
19 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 8588 8589 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.8MB 10.8MB +29.0B

cc @denar50

jbudz pushed a commit that referenced this pull request Apr 24, 2026
## Summary

Fix this error after node 24.14.1 upgrade (#260453):

```
$ node scripts/kbn bootstrap
success yarn.lock integrity check passed - no need to update
info pre-build webpack bundles
Using moon at (node:28990) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
(Use `node --trace-deprecation ...` to show where the warning was created)
/Users/jen/Projects/kibana/node_modules/.bin/moon
UNHANDLED EXCEPTION: Error: spawn ENAMETOOLONG
    at ChildProcess.spawn (node:internal/child_process:421:11)
    at Object.spawn (node:child_process:796:9)
    at run (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/lib/spawn.mjs:105:29)
    at moonRun (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/lib/moon.mjs:66:10)
    at processTicksAndRejections (node:internal/process/task_queues:104:5)
    at file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/commands/bootstrap/bootstrap_command.mjs:130:13
    at async Promise.allSettled (index 0)
    at time (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/cli.mjs:72:22)
    at async Promise.all (index 0)
    at Object.run (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/commands/bootstrap/bootstrap_command.mjs:125:5)
error Command failed with exit code 1.
```
rbrtj pushed a commit to walterra/kibana that referenced this pull request Apr 27, 2026
## Summary

Fix this error after node 24.14.1 upgrade (elastic#260453):

```
$ node scripts/kbn bootstrap
success yarn.lock integrity check passed - no need to update
info pre-build webpack bundles
Using moon at (node:28990) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
(Use `node --trace-deprecation ...` to show where the warning was created)
/Users/jen/Projects/kibana/node_modules/.bin/moon
UNHANDLED EXCEPTION: Error: spawn ENAMETOOLONG
    at ChildProcess.spawn (node:internal/child_process:421:11)
    at Object.spawn (node:child_process:796:9)
    at run (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/lib/spawn.mjs:105:29)
    at moonRun (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/lib/moon.mjs:66:10)
    at processTicksAndRejections (node:internal/process/task_queues:104:5)
    at file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/commands/bootstrap/bootstrap_command.mjs:130:13
    at async Promise.allSettled (index 0)
    at time (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/cli.mjs:72:22)
    at async Promise.all (index 0)
    at Object.run (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/commands/bootstrap/bootstrap_command.mjs:125:5)
error Command failed with exit code 1.
```
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Apr 27, 2026
## Summary

Fix this error after node 24.14.1 upgrade (elastic#260453):

```
$ node scripts/kbn bootstrap
success yarn.lock integrity check passed - no need to update
info pre-build webpack bundles
Using moon at (node:28990) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
(Use `node --trace-deprecation ...` to show where the warning was created)
/Users/jen/Projects/kibana/node_modules/.bin/moon
UNHANDLED EXCEPTION: Error: spawn ENAMETOOLONG
    at ChildProcess.spawn (node:internal/child_process:421:11)
    at Object.spawn (node:child_process:796:9)
    at run (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/lib/spawn.mjs:105:29)
    at moonRun (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/lib/moon.mjs:66:10)
    at processTicksAndRejections (node:internal/process/task_queues:104:5)
    at file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/commands/bootstrap/bootstrap_command.mjs:130:13
    at async Promise.allSettled (index 0)
    at time (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/cli.mjs:72:22)
    at async Promise.all (index 0)
    at Object.run (file:///Users/jen/Projects/kibana/src/dev/kbn_pm/src/commands/bootstrap/bootstrap_command.mjs:125:5)
error Command failed with exit code 1.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants