Skip to content

[Security Solution] Make the dataview key in localstorage space aware#260258

Merged
denar50 merged 1 commit into
elastic:mainfrom
denar50:fix-dataview-id-key-localstorage
Mar 31, 2026
Merged

[Security Solution] Make the dataview key in localstorage space aware#260258
denar50 merged 1 commit into
elastic:mainfrom
denar50:fix-dataview-id-key-localstorage

Conversation

@denar50
Copy link
Copy Markdown
Contributor

@denar50 denar50 commented Mar 30, 2026 •
edited by kibanamachine
Loading

Summary

This PR introduced logic to persist the loaded DV ids in the local storage. However, DVs are space aware, and so whenever you switch from one space to another in current main you get the following error in the video below.

Screen.Recording.2026-03-31.at.13.21.34.mov

This PR makes the key used to store the id in the local storage, space aware.

@PhilippeOberti
Copy link
Copy Markdown
Contributor

PhilippeOberti commented Mar 30, 2026

@kqualters-elastic this is related to this previous PR. If you have some time, could you take a look at this current one? I will review myself as well

kqualters-elastic
kqualters-elastic approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, and how this is done lgtm 👍 is this currently breaking anything?

@denar50 denar50 force-pushed the fix-dataview-id-key-localstorage branch from 8cef5f0 to 40126f1 Compare March 31, 2026 09:04
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 31, 2026

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #35 / dashboard app - esql controls dashboard - add an interval type ES|QL control should add an ES|QL interval control

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [53d896f]

@denar50 denar50 marked this pull request as ready for review March 31, 2026 11:28
@denar50 denar50 requested a review from a team as a code owner March 31, 2026 11:28
@denar50 denar50 self-assigned this Mar 31, 2026
@denar50 denar50 added backport:version Backport to applied version labels 9.3 candidate v9.2.4 release_note:skip Skip the PR/issue when compiling release notes v9.3.0 v9.2.0 and removed 9.3 candidate v9.2.4 labels Mar 31, 2026
@denar50 denar50 merged commit 5f5decb into elastic:main Mar 31, 2026
33 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 31, 2026

Starting backport for target branches: 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/23795060337

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 31, 2026
@denar50
[Security Solution] Make the dataview key in localstorage space aware (…
5dee4d9 
…elastic#260258)

## Summary
This [PR](elastic#245002) introduced
logic to persist the loaded DV ids in the local storage. However, DVs
are space aware, and so whenever you switch from one space to another in
current `main` you get the following error in the video below.

https://github.com/user-attachments/assets/94089c8f-c35d-4734-b983-f49698e70351

This PR makes the key used to store the id in the local storage, space
aware.

(cherry picked from commit 5f5decb)
@kibanamachine kibanamachine mentioned this pull request Mar 31, 2026
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 31, 2026

💔 Some backports could not be created

Status Branch Result
❌ 9.2 Backport failed because of merge conflicts
✅ 9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 260258

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 31, 2026
@kibanamachine @denar50
[9.3] [Security Solution] Make the dataview key in localstorage space…
1bda146 
… aware (#260258) (#260453)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[Security Solution] Make the dataview key in localstorage space aware
(#260258)](#260258)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Edgar
Santos","email":"edgar.santos@elastic.co"},"sourceCommit":{"committedDate":"2026-03-31T11:31:13Z","message":"[Security
Solution] Make the dataview key in localstorage space aware
(#260258)\n\n## Summary\nThis
[PR](#245002) introduced\nlogic to
persist the loaded DV ids in the local storage. However, DVs\nare space
aware, and so whenever you switch from one space to another in\ncurrent
`main` you get the following error in the video
below.\n\n\nhttps://github.com/user-attachments/assets/94089c8f-c35d-4734-b983-f49698e70351\n\nThis
PR makes the key used to store the id in the local storage,
space\naware.","sha":"5f5decbc680787e84da42621cedf366d1bf1ebde","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.3.0","v9.4.0"],"title":"[Security
Solution] Make the dataview key in localstorage space
aware","number":260258,"url":"https://github.com/elastic/kibana/pull/260258","mergeCommit":{"message":"[Security
Solution] Make the dataview key in localstorage space aware
(#260258)\n\n## Summary\nThis
[PR](#245002) introduced\nlogic to
persist the loaded DV ids in the local storage. However, DVs\nare space
aware, and so whenever you switch from one space to another in\ncurrent
`main` you get the following error in the video
below.\n\n\nhttps://github.com/user-attachments/assets/94089c8f-c35d-4734-b983-f49698e70351\n\nThis
PR makes the key used to store the id in the local storage,
space\naware.","sha":"5f5decbc680787e84da42621cedf366d1bf1ebde"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/260258","number":260258,"mergeCommit":{"message":"[Security
Solution] Make the dataview key in localstorage space aware
(#260258)\n\n## Summary\nThis
[PR](#245002) introduced\nlogic to
persist the loaded DV ids in the local storage. However, DVs\nare space
aware, and so whenever you switch from one space to another in\ncurrent
`main` you get the following error in the video
below.\n\n\nhttps://github.com/user-attachments/assets/94089c8f-c35d-4734-b983-f49698e70351\n\nThis
PR makes the key used to store the id in the local storage,
space\naware.","sha":"5f5decbc680787e84da42621cedf366d1bf1ebde"}}]}]
BACKPORT-->

Co-authored-by: Edgar Santos <edgar.santos@elastic.co>
jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Apr 1, 2026
@denar50 @jeramysoucy
[Security Solution] Make the dataview key in localstorage space aware (…
fcee8c2 
…elastic#260258)

## Summary
This [PR](elastic#245002) introduced
logic to persist the loaded DV ids in the local storage. However, DVs
are space aware, and so whenever you switch from one space to another in
current `main` you get the following error in the video below.


https://github.com/user-attachments/assets/94089c8f-c35d-4734-b983-f49698e70351

This PR makes the key used to store the id in the local storage, space
aware.
PhilippeOberti pushed a commit to PhilippeOberti/kibana that referenced this pull request Apr 1, 2026
@denar50
[Security Solution] Make the dataview key in localstorage space aware (…
97abcfa 
…elastic#260258)

## Summary
This [PR](elastic#245002) introduced
logic to persist the loaded DV ids in the local storage. However, DVs
are space aware, and so whenever you switch from one space to another in
current `main` you get the following error in the video below.

https://github.com/user-attachments/assets/94089c8f-c35d-4734-b983-f49698e70351

This PR makes the key used to store the id in the local storage, space
aware.

(cherry picked from commit 5f5decb)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/data_view_manager/redux/listeners/data_view_selected.test.ts
#	x-pack/solutions/security/plugins/security_solution/public/data_view_manager/redux/listeners/data_view_selected.ts
@PhilippeOberti PhilippeOberti mentioned this pull request Apr 1, 2026
Open
@PhilippeOberti
Copy link
Copy Markdown
Contributor

PhilippeOberti commented Apr 1, 2026

💚 All backports created successfully

Status Branch Result
✅ 9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Apr 2, 2026
@denar50 @paulinashakirova
[Security Solution] Make the dataview key in localstorage space aware (…
79c1412 
…elastic#260258)

## Summary
This [PR](elastic#245002) introduced
logic to persist the loaded DV ids in the local storage. However, DVs
are space aware, and so whenever you switch from one space to another in
current `main` you get the following error in the video below.


https://github.com/user-attachments/assets/94089c8f-c35d-4734-b983-f49698e70351

This PR makes the key used to store the id in the local storage, space
aware.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 2, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 2, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

28 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 3, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 6, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 7, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 8, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 9, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 10, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 13, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 14, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 15, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 16, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 17, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 20, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 21, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 22, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 23, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 24, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 28, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 29, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 30, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 1, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 4, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 5, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 6, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 7, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 8, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 11, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 12, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 13, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @denar50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees

@denar50 denar50

Labels

backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.2.0 v9.3.0 v9.3.3 v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@denar50 @PhilippeOberti @elasticmachine @kibanamachine @kqualters-elastic