[drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger by nreese · Pull Request #259637 · elastic/kibana

nreese · 2026-03-25T18:05:25Z

Before this PR, drilldown UI code added ON_OPEN_PANEL_MENU to an embeddable's supported triggers. This auto-magically allowed embeddables that implemented HasSupportedTriggers interface to support drilldowns that used ON_OPEN_PANEL_MENU trigger.

This auto-magic is causing problems with "as code" schemas. Embeddables register supported triggers on server during schema generation. Embeddables would not list ON_OPEN_PANEL_MENU in their supported triggers, allowing the UI to create drilldowns with triggers that are not contained in the schema.

This PR resolves the issue by removing the magic. Drilldown UI code no longer adds ON_OPEN_PANEL_MENU
to an embeddable's supported triggers. Instead, embeddables must explicitly include ON_OPEN_PANEL_MENU in supported triggers list.

PR also updates drilldownRegistry.getSchema to throw when no drilldowns match supporting triggers to give developers immediate feedback that drilldowns should not be included in schema if there is no overlap in supported triggers and drilldowns.

nreese · 2026-03-25T18:20:45Z

/ci

nreese · 2026-03-25T18:29:05Z

/ci

nreese · 2026-03-25T19:20:04Z

/ci

nreese · 2026-03-25T21:02:36Z

/ci

elasticmachine · 2026-03-25T23:50:04Z

Pinging @elastic/kibana-presentation (Team:Presentation)

elasticmachine · 2026-03-26T03:08:31Z

💚 Build Succeeded

Buildkite Build
Commit: 266bc56

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	1.6MB	1.6MB	+20.0B
`embeddable`	42.3KB	42.2KB	-28.0B
`lens`	2.0MB	2.0MB	+61.0B
`maps`	3.2MB	3.2MB	+21.0B
`visualizations`	332.1KB	332.2KB	+21.0B
total			+95.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`imageEmbeddable`	5.7KB	5.7KB	+21.0B

History

💔 Build #416766 failed 31c0846
💛 Build #416709 was flaky c445223
💔 Build #416641 failed fe7a245
💔 Build #416592 failed 9a3056b

ThomThomson

Nice simple changes, good magic removal. LGTM!

ThomThomson · 2026-03-26T16:55:48Z

src/platform/plugins/shared/discover/public/embeddable/get_search_embeddable_factory.tsx

        serializeState: () => serialize(savedObjectId$.getValue()),
        getInspectorAdapters: () => searchEmbeddable.stateManager.inspectorAdapters.getValue(),
        supportedTriggers: () => {
-          // No triggers are supported, but this is still required to pass the drilldown


This comment should definitely have tipped us off that this was a bad code smell. Happy to see it removed!

nickofthyme

Code review only

…hanges * commit '22bf09c82658b9511cbb2ad13f6dd29ad3526472': (21 commits) [Overlays System Flyout]: Support Child History (elastic#256339) KUA-Update event naming format and examples (elastic#259846) Fix pagerduty connector codeownership (elastic#259807) [Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests (elastic#258981) [Upgrade Assistant] Migrate ES deprecations flaky integration tests to unit tests (elastic#258142) [Index Management] Migrate flaky integration tests to unit tests (elastic#258942) [Cases] Rename attachment id to saved object id (elastic#259158) [Entity Store] Change hash algo to sha256 (elastic#259453) [Security Solution] fixed enhanced security profile header showing for non-alert documents (elastic#259801) Update LaunchDarkly (main) (elastic#259008) [Discover] Add observability default ES|QL query (elastic#257268) Update dependency @redocly/cli to v2.21.1 (main) (elastic#259016) Gap reason detected (elastic#258231) [One Workflow] Historical executionContext and telemetry (elastic#258623) coderabbit: drop SigEvents (elastic#259863) [ci] Bump cypress disk (elastic#259861) Server timings (elastic#258915) Replace deprecated EUI icons in files owned by @elastic/kibana-cases (elastic#255633) [ci] Bump storybooks disk (elastic#259858) [drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger (elastic#259637) ...

…er (elastic#259637) Closes elastic#259590 Before this PR, drilldown UI code added `ON_OPEN_PANEL_MENU` to an embeddable's supported triggers. This auto-magically allowed embeddables that implemented `HasSupportedTriggers` interface to support drilldowns that used `ON_OPEN_PANEL_MENU` trigger. This auto-magic is causing problems with "as code" schemas. Embeddables register supported triggers on server during schema generation. Embeddables would not list `ON_OPEN_PANEL_MENU` in their supported triggers, allowing the UI to create drilldowns with triggers that are not contained in the schema. This PR resolves the issue by removing the magic. Drilldown UI code no longer adds `ON_OPEN_PANEL_MENU` to an embeddable's supported triggers. Instead, embeddables must explicitly include `ON_OPEN_PANEL_MENU` in supported triggers list. PR also updates `drilldownRegistry.getSchema` to throw when no drilldowns match supporting triggers to give developers immediate feedback that drilldowns should not be included in schema if there is no overlap in supported triggers and drilldowns. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…ers (#261018) Follow up to #259637 Before this PR, drilldown UI code added ON_APPLY_FILTER to an embeddable's supported triggers. This auto-magically allowed embeddables that implemented HasSupportedTriggers interface to support drilldowns that used ON_APPLY_FILTER trigger. This auto-magic could cause problems with "as code" schemas. Embeddables register supported triggers on server during schema generation. Embeddables could not list ON_APPLY_FILTER in their supported triggers, allowing the UI to create drilldowns with triggers that are not contained in the schema. In practice this did not happen, but we want to avoid the possibility for such a mistake. This PR resolves the issue by removing the magic. Drilldown UI code no longer adds ON_APPLY_FILTER to an embeddable's supported triggers. Instead, embeddables must explicitly includeON_APPLY_FILTER in supported triggers list. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

nreese added 2 commits March 25, 2026 12:04

[drilldowns] require embeddables to opt into all triggers

c0785e5

throw when not drilldown schemas

a6a00c4

nreese changed the title ~~[drilldowns] require embeddables to opt into all triggers~~ [drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger Mar 25, 2026

visualization

9a3056b

Changes from node scripts/lint.js --fix

fe7a245

Changes from node scripts/eslint_all_files --no-cache --fix

c445223

nreese marked this pull request as ready for review March 25, 2026 23:49

nreese requested review from a team as code owners March 25, 2026 23:49

nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.4.0 labels Mar 25, 2026

nreese added the Project:Dashboards API label Mar 25, 2026

Merge branch 'main' into issue_259590

31c0846

botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame labels Mar 25, 2026

Merge branch 'main' into issue_259590

266bc56

jughosta approved these changes Mar 26, 2026

View reviewed changes

kowalczyk-krzysztof approved these changes Mar 26, 2026

View reviewed changes

ThomThomson approved these changes Mar 26, 2026

View reviewed changes

nickofthyme approved these changes Mar 26, 2026

View reviewed changes

nreese merged commit 341779b into elastic:main Mar 26, 2026
18 checks passed

nreese mentioned this pull request Apr 8, 2026

[drilldowns] do not add ON_APPLY_FILTER to embeddable supported triggers #261018

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger#259637

[drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger#259637
nreese merged 7 commits intoelastic:mainfrom
nreese:issue_259590

nreese commented Mar 25, 2026 •

edited

Loading

Uh oh!

nreese commented Mar 25, 2026

Uh oh!

nreese commented Mar 25, 2026

Uh oh!

nreese commented Mar 25, 2026

Uh oh!

nreese commented Mar 25, 2026

Uh oh!

elasticmachine commented Mar 25, 2026

Uh oh!

elasticmachine commented Mar 26, 2026

Uh oh!

ThomThomson left a comment

Uh oh!

ThomThomson Mar 26, 2026

Uh oh!

nickofthyme left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

nreese commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented Mar 25, 2026

Uh oh!

nreese commented Mar 25, 2026

Uh oh!

nreese commented Mar 25, 2026

Uh oh!

nreese commented Mar 25, 2026

Uh oh!

elasticmachine commented Mar 25, 2026

Uh oh!

elasticmachine commented Mar 26, 2026

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nreese commented Mar 25, 2026 •

edited

Loading