[Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests by kapral18 · Pull Request #258981 · elastic/kibana

kapral18 · 2026-03-22T16:05:24Z

Summary

Migrates Kibana deprecations coverage from flaky client integration tests to focused unit tests.
Adds unit coverage for the Kibana deprecations list/table (refresh, counts, filters/clear, details link) and the details flyout (manual steps, docs link, quick resolve success/failure).
Removes legacy __jest__/client_integration/kibana_deprecations specs and drops shared_imports usage in favor of @kbn/es-ui-shared-plugin/public imports.

Closes

Closes Failing test: Jest Tests.x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecations_table - Kibana deprecations - Deprecations table Search bar filters by "critical" status #253915

Coverage mapping

Integration → unit test mapping (gist)

Test plan

node scripts/check_changes.ts
yarn test:jest x-pack/platform/plugins/private/upgrade_assistant/public/application/components/kibana_deprecations --silent

Assisted with Cursor using GPT-5.2

elasticmachine · 2026-03-22T20:46:37Z

Pinging @elastic/kibana-management (Team:Kibana Management)

coderabbitai · 2026-03-22T21:27:17Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 659e09df-037d-4a54-8061-8ecd168f76dc

📥 Commits

Reviewing files that changed from the base of the PR and between 3661c15 and bb3ed6f.

📒 Files selected for processing (8)

x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecation_details_flyout/deprecation_details_flyout.test.ts
x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecations_table/deprecations_table.test.ts
x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecations_table/error_handling.test.ts
x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/kibana_deprecations.helpers.tsx
x-pack/platform/plugins/private/upgrade_assistant/public/application/components/kibana_deprecations/deprecation_details_flyout.test.tsx
x-pack/platform/plugins/private/upgrade_assistant/public/application/components/kibana_deprecations/kibana_deprecations.test.tsx
x-pack/platform/plugins/private/upgrade_assistant/public/application/components/kibana_deprecations/kibana_deprecations.tsx
x-pack/platform/plugins/private/upgrade_assistant/public/application/components/kibana_deprecations/kibana_deprecations_table.test.tsx

💤 Files with no reviewable changes (4)

x-pack/platform/plugins/private/upgrade_assistant/jest/client_integration/kibana_deprecations/deprecations_table/deprecations_table.test.ts
x-pack/platform/plugins/private/upgrade_assistant/jest/client_integration/kibana_deprecations/kibana_deprecations.helpers.tsx
x-pack/platform/plugins/private/upgrade_assistant/jest/client_integration/kibana_deprecations/deprecation_details_flyout/deprecation_details_flyout.test.ts
x-pack/platform/plugins/private/upgrade_assistant/jest/client_integration/kibana_deprecations/deprecations_table/error_handling.test.ts

📝 Walkthrough

Walkthrough

This change migrates test coverage for the Kibana deprecations feature from integration-style tests in the __jest__/client_integration directory to colocated unit/component tests. The old test files (deprecation_details_flyout.test.ts, deprecations_table.test.ts, error_handling.test.ts) and their helper (kibana_deprecations.helpers.tsx) are removed. New component-level tests are added (deprecation_details_flyout.test.tsx, kibana_deprecations.test.tsx, kibana_deprecations_table.test.tsx) that cover rendering, user interactions, error handling, and state management using mocked services. Additionally, imports for MissingPrivileges, WithPrivileges, SectionLoading, and GlobalFlyout are updated to source from @kbn/es-ui-shared-plugin/public instead of local shared imports.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	PR successfully migrates flaky client integration tests to focused unit tests, directly addressing issue `#253915`.
Out of Scope Changes check	✅ Passed	All changes are scoped to test migration and import refactoring. No unrelated modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

elasticmachine · 2026-03-24T21:48:14Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: e3c1c6e

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #7 / buildEsqlFetchSubscribe changing a ES|QL query with no transformational commands should not change state when loading and finished if index pattern and columns are the same
[job] [logs] Jest Tests #6 / StatefulOpenTimeline it invokes onOpenTimeline with the expected parameters when the hyperlink is clicked

Metrics [docs]

✅ unchanged

History

💚 Build #414268 succeeded bb3ed6f

damian-polewski

Great job migrating those integration tests to unit tests! I have two small comment but overall looks good!

...sistant/public/application/components/kibana_deprecations/kibana_deprecations_table.test.tsx

...istant/public/application/components/kibana_deprecations/deprecation_details_flyout.test.tsx

…ts to unit tests Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

…ogress resolve Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

damian-polewski

Thanks for addressing my feedback! LGTM!

kibanamachine · 2026-03-26T20:44:53Z

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/23617119803

kibanamachine · 2026-03-26T20:55:00Z

💔 All backports failed

Status	Branch	Result
❌	9.3	Backport failed because of merge conflicts You might need to backport the following PRs to 9.3: - [Upgrade Assistant] Migrate ES deprecations flaky integration tests to unit tests (#258142) - [Index Management] Migrate flaky integration tests to unit tests (#258942) - [Dashboards] Fix backups service (#257762) - [Security Solution] only show notes for a saved timeline (ignoring emtpy string from draft timelines) (#259658) - [Security Solution][Detection Engine] Fix alert count so max alerts warning shows correctly (#259199)

Manual backport

To create the backport manually run:

node scripts/backport --pr 258981

Questions ?

Please refer to the Backport tool documentation

…hanges * commit '22bf09c82658b9511cbb2ad13f6dd29ad3526472': (21 commits) [Overlays System Flyout]: Support Child History (elastic#256339) KUA-Update event naming format and examples (elastic#259846) Fix pagerduty connector codeownership (elastic#259807) [Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests (elastic#258981) [Upgrade Assistant] Migrate ES deprecations flaky integration tests to unit tests (elastic#258142) [Index Management] Migrate flaky integration tests to unit tests (elastic#258942) [Cases] Rename attachment id to saved object id (elastic#259158) [Entity Store] Change hash algo to sha256 (elastic#259453) [Security Solution] fixed enhanced security profile header showing for non-alert documents (elastic#259801) Update LaunchDarkly (main) (elastic#259008) [Discover] Add observability default ES|QL query (elastic#257268) Update dependency @redocly/cli to v2.21.1 (main) (elastic#259016) Gap reason detected (elastic#258231) [One Workflow] Historical executionContext and telemetry (elastic#258623) coderabbit: drop SigEvents (elastic#259863) [ci] Bump cypress disk (elastic#259861) Server timings (elastic#258915) Replace deprecated EUI icons in files owned by @elastic/kibana-cases (elastic#255633) [ci] Bump storybooks disk (elastic#259858) [drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger (elastic#259637) ...

…ts to unit tests (elastic#258981) ## Summary - Migrates Kibana deprecations coverage from flaky client integration tests to focused unit tests. - Adds unit coverage for the Kibana deprecations list/table (refresh, counts, filters/clear, details link) and the details flyout (manual steps, docs link, quick resolve success/failure). - Removes legacy `__jest__/client_integration/kibana_deprecations` specs and drops `shared_imports` usage in favor of `@kbn/es-ui-shared-plugin/public` imports. ## Closes - Closes elastic#253915 ## Coverage mapping - [Integration → unit test mapping (gist)](https://gist.github.com/kapral18/a3d2f778d575daa2f3dfcd8e0f4b66e4) ## Test plan - [x] `node scripts/check_changes.ts` - [x] `yarn test:jest x-pack/platform/plugins/private/upgrade_assistant/public/application/components/kibana_deprecations --silent` Assisted with Cursor using GPT-5.2 --------- Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 5c40b03) # Conflicts: # x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecation_details_flyout/deprecation_details_flyout.test.ts # x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecations_table/deprecations_table.test.ts # x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecations_table/error_handling.test.ts

kapral18 · 2026-03-28T01:12:09Z

💚 All backports created successfully

Status	Branch	Result
✅	9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ts to unit tests (elastic#258981) ## Summary - Migrates Kibana deprecations coverage from flaky client integration tests to focused unit tests. - Adds unit coverage for the Kibana deprecations list/table (refresh, counts, filters/clear, details link) and the details flyout (manual steps, docs link, quick resolve success/failure). - Removes legacy `__jest__/client_integration/kibana_deprecations` specs and drops `shared_imports` usage in favor of `@kbn/es-ui-shared-plugin/public` imports. ## Closes - Closes elastic#253915 ## Coverage mapping - [Integration → unit test mapping (gist)](https://gist.github.com/kapral18/a3d2f778d575daa2f3dfcd8e0f4b66e4) ## Test plan - [x] `node scripts/check_changes.ts` - [x] `yarn test:jest x-pack/platform/plugins/private/upgrade_assistant/public/application/components/kibana_deprecations --silent` Assisted with Cursor using GPT-5.2 --------- Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 5c40b03) # Conflicts: # x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecation_details_flyout/deprecation_details_flyout.test.ts # x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecations_table/deprecations_table.test.ts # x-pack/platform/plugins/private/upgrade_assistant/__jest__/client_integration/kibana_deprecations/deprecations_table/error_handling.test.ts

kibanamachine · 2026-03-30T20:50:05Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @kapral18

…on tests to unit tests (#258981) (#260129) # Backport This will backport the following commits from `main` to `9.3`: - [[Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests (#258981)](#258981)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

…ts to unit tests (elastic#258981) ## Summary - Migrates Kibana deprecations coverage from flaky client integration tests to focused unit tests. - Adds unit coverage for the Kibana deprecations list/table (refresh, counts, filters/clear, details link) and the details flyout (manual steps, docs link, quick resolve success/failure). - Removes legacy `__jest__/client_integration/kibana_deprecations` specs and drops `shared_imports` usage in favor of `@kbn/es-ui-shared-plugin/public` imports. ## Closes - Closes elastic#253915 ## Coverage mapping - [Integration → unit test mapping (gist)](https://gist.github.com/kapral18/a3d2f778d575daa2f3dfcd8e0f4b66e4) ## Test plan - [x] `node scripts/check_changes.ts` - [x] `yarn test:jest x-pack/platform/plugins/private/upgrade_assistant/public/application/components/kibana_deprecations --silent` Assisted with Cursor using GPT-5.2 --------- Co-authored-by: Cursor <cursoragent@cursor.com>

kapral18 force-pushed the chore/upgrade-assistant/fix-kibana-deprecations-flaky-tests-253915 branch from d99525f to bb3ed6f Compare March 22, 2026 16:08

kapral18 marked this pull request as ready for review March 22, 2026 16:09

kapral18 requested a review from a team as a code owner March 22, 2026 16:09

kapral18 force-pushed the chore/upgrade-assistant/fix-kibana-deprecations-flaky-tests-253915 branch from bb3ed6f to 8862f7f Compare March 23, 2026 16:42

kapral18 requested a review from damian-polewski March 23, 2026 17:47

kapral18 force-pushed the chore/upgrade-assistant/fix-kibana-deprecations-flaky-tests-253915 branch from 8862f7f to e3c1c6e Compare March 24, 2026 20:29

damian-polewski reviewed Mar 26, 2026

View reviewed changes

...sistant/public/application/components/kibana_deprecations/kibana_deprecations_table.test.tsx Outdated Show resolved Hide resolved

...istant/public/application/components/kibana_deprecations/deprecation_details_flyout.test.tsx Show resolved Hide resolved

kapral18 and others added 2 commits March 26, 2026 12:40

[Upgrade Assistant] Migrate Kibana deprecations flaky integration tes…

3bcfc37

…ts to unit tests Co-authored-by: Cursor <cursoragent@cursor.com>

[Upgrade Assistant] Speed up Kibana deprecations table filter test

d7db7f6

Co-authored-by: Cursor <cursoragent@cursor.com>

kapral18 force-pushed the chore/upgrade-assistant/fix-kibana-deprecations-flaky-tests-253915 branch from e3c1c6e to d7db7f6 Compare March 26, 2026 11:40

kapral18 and others added 2 commits March 26, 2026 12:53

[Upgrade Assistant] Stabilize filter button selectors and cover in-pr…

94172df

…ogress resolve Co-authored-by: Cursor <cursoragent@cursor.com>

[Upgrade Assistant] Use getByLabelText for deprecations filter buttons

6ea32a4

Co-authored-by: Cursor <cursoragent@cursor.com>

kapral18 requested a review from damian-polewski March 26, 2026 12:00

damian-polewski approved these changes Mar 26, 2026

View reviewed changes

kapral18 merged commit 5c40b03 into elastic:main Mar 26, 2026
18 checks passed

kapral18 deleted the chore/upgrade-assistant/fix-kibana-deprecations-flaky-tests-253915 branch March 26, 2026 20:44

kibanamachine mentioned this pull request Mar 27, 2026

[Snapshot Restore] Migrate flaky repository_add integration test to unit tests #258974

Merged

kapral18 mentioned this pull request Mar 28, 2026

[9.3] [Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests (#258981) #260129

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2026

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests#258981

[Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests#258981
kapral18 merged 4 commits intoelastic:mainfrom
kapral18:chore/upgrade-assistant/fix-kibana-deprecations-flaky-tests-253915

kapral18 commented Mar 22, 2026 •

edited by kibanamachine

Loading

Uh oh!

elasticmachine commented Mar 22, 2026

Uh oh!

coderabbitai bot commented Mar 22, 2026

Walkthrough

Uh oh!

elasticmachine commented Mar 24, 2026

Uh oh!

damian-polewski left a comment

Uh oh!

Uh oh!

Uh oh!

damian-polewski left a comment

Uh oh!

Uh oh!

kibanamachine commented Mar 26, 2026

Uh oh!

kibanamachine commented Mar 26, 2026

Uh oh!

kapral18 commented Mar 28, 2026

Uh oh!

kibanamachine commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kapral18 commented Mar 22, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Closes

Coverage mapping

Test plan

Uh oh!

elasticmachine commented Mar 22, 2026

Uh oh!

coderabbitai bot commented Mar 22, 2026

Walkthrough

Uh oh!

elasticmachine commented Mar 24, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

Uh oh!

damian-polewski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

damian-polewski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Mar 26, 2026

Uh oh!

kibanamachine commented Mar 26, 2026

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kapral18 commented Mar 28, 2026

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kapral18 commented Mar 22, 2026 •

edited by kibanamachine

Loading