Skip to content

[Fleet] Make var groups more generically usable#259213

Merged
Supplementing merged 6 commits intoelastic:mainfrom
Supplementing:make-var-groups-generically-usable
Mar 24, 2026
Merged

[Fleet] Make var groups more generically usable#259213
Supplementing merged 6 commits intoelastic:mainfrom
Supplementing:make-var-groups-generically-usable

Conversation

@Supplementing
Copy link
Copy Markdown
Contributor

@Supplementing Supplementing commented Mar 23, 2026

Summary

Closes https://github.com/elastic/ingest-dev/issues/7185
Related: https://github.com/elastic/ingest-dev/issues/6549
Depends on elastic/package-spec#1120

This PR makes var_groups usable everywhere, rather than just at the package root and streams level so that items can be rendered in their appropriate sections (input, etc) and take full advantage of grouping. This will unblock elastic/integrations#17495 and allow us to finalize a draft version of this integration as a poster-child that utilizes var_groups for a clean and minimal UI.

WIP integration utilizing the var_groups at the input level for grouping based on chosen auth method:
image

Testing instructions

If you want to manually build an integration and test, please DM me and I will send you detailed instructions or walk you through how to set up a local package-spec and point your elastic-package at it, build it, etc. Im happy to do so, but in the sake of brevity, I will skip that here.

The easiest way otherwise is to simply upload this pre-built integration that I built locally using the changes to package-spec:
okta-3.14.2.zip

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@Supplementing Supplementing requested a review from a team as a code owner March 23, 2026 21:26
@Supplementing Supplementing added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Mar 23, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@Supplementing
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod Bot requested a review from a team as a code owner March 23, 2026 21:44
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 23, 2026

Caution

Review failed

The head commit changed during the review from e1e7ad1 to 4a0d550.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the descriptions.

Copy link
Copy Markdown
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Supplementing
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@Supplementing Supplementing enabled auto-merge (squash) March 24, 2026 14:35
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 24, 2026

⏳ Build in-progress, with failures

Failed CI Steps

History

@Supplementing Supplementing merged commit 0bc4af2 into elastic:main Mar 24, 2026
18 checks passed
jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Mar 26, 2026
## Summary

Closes elastic/ingest-dev#7185
Related: elastic/ingest-dev#6549 
Depends on elastic/package-spec#1120

This PR makes `var_groups` usable everywhere, rather than just at the
package root and streams level so that items can be rendered in their
appropriate sections (input, etc) and take full advantage of grouping.
This will unblock elastic/integrations#17495 and
allow us to finalize a draft version of this integration as a
poster-child that utilizes `var_groups` for a clean and minimal UI.

WIP integration utilizing the var_groups at the input level for grouping
based on chosen auth method:
<img width="1709" height="1198" alt="image"
src="https://github.com/user-attachments/assets/433307f4-dcd6-460f-a34f-2a5fa9dc6c3f"
/>


## Testing instructions

If you want to manually build an integration and test, please DM me and
I will send you detailed instructions or walk you through how to set up
a local package-spec and point your elastic-package at it, build it,
etc. Im happy to do so, but in the sake of brevity, I will skip that
here.

The easiest way otherwise is to simply upload this pre-built integration
that I built locally using the changes to package-spec:

[okta-3.14.2.zip](https://github.com/user-attachments/files/26195499/okta-3.14.2.zip)


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants