Skip to content

[ES|QL] Support by into the Limit command #258008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoval merged 7 commits into from
Mar 19, 2026
Merged

[ES|QL] Support by into the Limit command #258008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d57dd8
support by into the Limit command
bartoval Mar 16, 2026
84f4c81
remove validation
bartoval Mar 17, 2026
4c6fc1e
TO FIX: Run node 'scripts/yarn_deduplicate && yarn kbn bootstrap' loc…
kibanamachine Mar 17, 2026
eb1c3cc
Merge branch 'main' into add_limit_by
stratoula Mar 17, 2026
4fe480e
Remove groupinig functions from LIMIT BY autocomplete
bartoval Mar 17, 2026
b514695
updates from the new grammar
bartoval Mar 19, 2026
da9bc08
Merge branch 'main' into add_limit_by
bartoval Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
"@elastic/ecs": "9.3.0",
"@elastic/elasticsearch": "9.3.4",
"@elastic/ems-client": "8.6.3",
"@elastic/esql": "1.4.1",
"@elastic/esql": "1.5.0",
"@elastic/eui": "113.2.1",
"@elastic/eui-theme-borealis": "6.1.0",
"@elastic/filesaver": "1.1.2",
Expand Down
1 change: 1 addition & 0 deletions src/platform/packages/shared/kbn-esql-language/scripts/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export const defaultScalarFunctionLocations: Location[] = [
Location.WHERE,
Location.STATS,
Location.STATS_BY,
Location.LIMIT_BY,
Location.STATS_WHERE,
Location.STATS_TIMESERIES,
Location.COMPLETION,
Expand Down
2 changes: 2 additions & 0 deletions src/platform/packages/shared/kbn-esql-language/scripts/generate_function_definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ const enrichOperators = (
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand All @@ -214,6 +215,7 @@ const enrichOperators = (
Location.STATS,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down
3 changes: 3 additions & 0 deletions src/platform/packages/shared/kbn-esql-language/src/commands/definitions/all_operators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const logicalOperators: FunctionDefinition[] = [
Location.SORT,
Location.STATS,
Location.STATS_BY,
Location.LIMIT_BY,
Location.STATS_WHERE,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -87,6 +88,7 @@ const otherDefinitions: FunctionDefinition[] = [
Location.ROW,
Location.SORT,
Location.STATS_BY,
Location.LIMIT_BY,
Location.STATS_WHERE,
Location.RERANK,
Location.JOIN,
Expand All @@ -108,6 +110,7 @@ const otherDefinitions: FunctionDefinition[] = [
Location.EVAL,
Location.STATS,
Location.STATS_BY,
Location.LIMIT_BY,
Location.ROW,
Location.WHERE,
Location.ENRICH,
Expand Down
11 changes: 11 additions & 0 deletions ...latform/packages/shared/kbn-esql-language/src/commands/definitions/generated/operators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@ const addDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -852,6 +853,7 @@ const divDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -1428,6 +1430,7 @@ const equalsDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -1851,6 +1854,7 @@ const greaterThanDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -2274,6 +2278,7 @@ const greaterThanOrEqualDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -3646,6 +3651,7 @@ const lessThanDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -4069,6 +4075,7 @@ const lessThanOrEqualDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -4898,6 +4905,7 @@ const modDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -5214,6 +5222,7 @@ const mulDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -6259,6 +6268,7 @@ const notEqualsDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down Expand Up @@ -6800,6 +6810,7 @@ const subDefinition: FunctionDefinition = {
Location.SORT,
Location.STATS_WHERE,
Location.STATS_BY,
Location.LIMIT_BY,
Location.COMPLETION,
Location.RERANK,
Location.JOIN,
Expand Down
Loading
Loading