[ES|QL] Support by into the Limit command by bartoval · Pull Request #258008 · elastic/kibana

bartoval · 2026-03-16T19:47:24Z

Summary

LIMIT_BY.mp4

The BY part of the LIMIT command is currently flagged as development-only, so it needs to be hidden
A mysterious voice says that LIMIT BY cannot come before SORT, so we added a validation and temporarily do not suggest it [ESQL] Adds planner implementation for LIMIT BY elasticsearch#144069

bartoval · 2026-03-16T19:48:27Z

...packages/shared/kbn-esql-language/src/commands/definitions/utils/autocomplete/fields_list.ts

-      );
+      const commaSuggestion = withAutoSuggest({ ...commaCompleteItem, text: ', ' });
+
+      if (ENDS_WITH_WHITESPACE_REGEX.test(innerText)) {


removes the space between the previous word and the paragraph. It's the same as what Stats By does

src/platform/packages/shared/kbn-esql-language/src/commands/registry/limit/validate.ts

bartoval · 2026-03-16T19:59:12Z

Stats By was considered for refactoring, but it requires special handling to avoid breaking tests. Since that is outside the scope of this PR, it was not included

bartoval · 2026-03-16T20:05:56Z

I’m not sure whether I also need to implement ColumnAfter. Stats By passes the custom columns to the next pipe

src/platform/packages/shared/kbn-esql-language/src/commands/registry/limit/autocomplete.ts

elasticmachine · 2026-03-17T06:56:55Z

Pinging @elastic/kibana-esql (Team:ESQL)

bartoval · 2026-03-17T07:00:52Z

src/platform/packages/shared/kbn-esql-language/src/commands/registry/limit/index.ts

-    examples: ['… | LIMIT 100', '… | LIMIT 1'],
+    preview: true,
+    // TODO: Remove this temporary autocomplete gate once LIMIT BY is available outside tests.
+    limitByHidden: process.env.NODE_ENV === 'test' ? false : true,


set this flag to false to try locally the PR

…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch

stratoula

Looks awesome, jsut a small change, do not suggest the grouping options for now as they are not going to be supported for 9.4

stratoula · 2026-03-17T09:46:32Z

...m/packages/shared/kbn-esql-language/src/commands/definitions/generated/grouping_functions.ts

    },
  ],
-  locationsAvailable: [Location.STATS, Location.STATS_BY],
+  locationsAvailable: [Location.STATS, Location.STATS_BY, Location.LIMIT_BY],


Here we shuld not have the locations right? Because the grouping functions are not supported in tech preview

stratoula

Thanks Val

stratoula

🎉

elasticmachine · 2026-03-19T11:57:00Z

💚 Build Succeeded

Buildkite Build
Commit: da9bc08

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`esql`	964	965	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`esql`	791.9KB	792.0KB	+22.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-npmDll`	7.0MB	7.0MB	+771.0B
`kbnUiSharedDeps-srcJs`	4.1MB	4.1MB	+3.4KB
total			+4.2KB

History

💛 Build #411497 was flaky 4fe480e
💛 Build #411432 was flaky eb1c3cc
💔 Build #411183 failed 4c6fc1e
💔 Build #411089 failed 772a3ea

cc @bartoval

## Summary https://github.com/user-attachments/assets/a2fc7656-935d-4b62-88cc-05418d321b6b - The BY part of the LIMIT command is currently flagged as development-only, so it needs to be hidden - A mysterious voice says that LIMIT BY cannot come before SORT, so we added a validation and temporarily do not suggest it elastic/elasticsearch#144069 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratou <efstratia.kalafateli@elastic.co>

bartoval self-assigned this Mar 16, 2026

bartoval added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.4.0 labels Mar 16, 2026

bartoval commented Mar 16, 2026

View reviewed changes

src/platform/packages/shared/kbn-esql-language/src/commands/registry/limit/validate.ts Outdated Show resolved Hide resolved

bartoval force-pushed the add_limit_by branch from 7de8ac9 to 772a3ea Compare March 17, 2026 06:54

bartoval commented Mar 17, 2026

View reviewed changes

src/platform/packages/shared/kbn-esql-language/src/commands/registry/limit/autocomplete.ts Outdated Show resolved Hide resolved

bartoval marked this pull request as ready for review March 17, 2026 06:56

bartoval requested a review from a team as a code owner March 17, 2026 06:56

bartoval commented Mar 17, 2026

View reviewed changes

bartoval force-pushed the add_limit_by branch from e658d3d to aec0190 Compare March 17, 2026 07:08

bartoval changed the title ~~support by into the Limit command~~ [ES|QL] Support by into the Limit command Mar 17, 2026

bartoval force-pushed the add_limit_by branch from 89425ff to f620002 Compare March 17, 2026 08:50

bartoval added 2 commits March 17, 2026 10:08

support by into the Limit command

7d57dd8

remove validation

84f4c81

bartoval force-pushed the add_limit_by branch from f620002 to 84f4c81 Compare March 17, 2026 09:09

kibanamachine and others added 2 commits March 17, 2026 09:46

TO FIX: Run node 'scripts/yarn_deduplicate && yarn kbn bootstrap' loc…

4c6fc1e

…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch

Merge branch 'main' into add_limit_by

eb1c3cc

stratoula reviewed Mar 17, 2026

View reviewed changes

Remove groupinig functions from LIMIT BY autocomplete

4fe480e

stratoula approved these changes Mar 17, 2026

View reviewed changes

bartoval and others added 2 commits March 19, 2026 11:22

updates from the new grammar

b514695

Merge branch 'main' into add_limit_by

da9bc08

stratoula approved these changes Mar 19, 2026

View reviewed changes

bartoval merged commit f5ae7bf into elastic:main Mar 19, 2026
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] Support by into the Limit command#258008

[ES|QL] Support by into the Limit command#258008
bartoval merged 7 commits intoelastic:mainfrom
bartoval:add_limit_by

bartoval commented Mar 16, 2026 •

edited

Loading

Uh oh!

bartoval Mar 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

bartoval commented Mar 16, 2026 •

edited

Loading

Uh oh!

bartoval commented Mar 16, 2026

Uh oh!

Uh oh!

elasticmachine commented Mar 17, 2026

Uh oh!

bartoval Mar 17, 2026

Uh oh!

stratoula left a comment

Uh oh!

stratoula Mar 17, 2026

Uh oh!

stratoula left a comment

Uh oh!

stratoula left a comment

Uh oh!

elasticmachine commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bartoval commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

bartoval Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bartoval commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bartoval commented Mar 16, 2026

Uh oh!

Uh oh!

elasticmachine commented Mar 17, 2026

Uh oh!

bartoval Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 19, 2026

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bartoval commented Mar 16, 2026 •

edited

Loading

bartoval Mar 16, 2026 •

edited

Loading

bartoval commented Mar 16, 2026 •

edited

Loading