[i18n] Translate Visual Builder(part_2)#25800
Merged
Nox911 merged 31 commits intoelastic:masterfrom Nov 26, 2018
Merged
Conversation
second merge
Contributor
💚 Build Succeeded |
timroes
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
pavel06081991
requested review from
pavel06081991
and removed request for
maryia-lapata
pavel06081991
approved these changes
Nov 20, 2018
Contributor
pavel06081991
left a comment
pavel06081991
left a comment
There was a problem hiding this comment.
LGTM but please fix some small comments
src/core_plugins/metrics/public/components/lib/get_axis_label_string.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/panel_config/gauge.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/panel_config/markdown.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/panel_config/table.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/panel_config/timeseries.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Nox911
added a commit
to Nox911/kibana
that referenced
this pull request
Nov 26, 2018
* Translate visual_builder(part_2) * Replace namespace metrics to tsvb * Fix issues
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Nov 26, 2018
* Translate visual_builder(part_2) * Replace namespace metrics to tsvb * Fix issues
maryia-lapata
added a commit
that referenced
this pull request
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 : #23988
Issue #23257