Translations for Visual Builder (part 1)#23988
Merged
Nox911 merged 50 commits intoelastic:masterfrom Nov 26, 2018
Merged
Conversation
second merge
pavel06081991
approved these changes
Oct 18, 2018
Contributor
pavel06081991
left a comment
pavel06081991
left a comment
There was a problem hiding this comment.
LGTM. please fix some small comments
…com/maryia-lapata/kibana into feature/translations/visual-builder
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
Could you please resolve the conflicts, then I can give this a final review. |
# Conflicts: # .i18nrc.json
# Conflicts: # src/core_plugins/metrics/public/kbn_vis_types/index.js
timroes
approved these changes
Nov 22, 2018
Contributor
timroes
left a comment
timroes
left a comment
There was a problem hiding this comment.
Code LGTM, approve assuming a green CI
Contributor
💚 Build Succeeded |
# Conflicts: # .i18nrc.json # src/core_plugins/metrics/public/kbn_vis_types/editor_controller.js
Contributor
💚 Build Succeeded |
maryia-lapata
added a commit
to maryia-lapata/kibana
that referenced
this pull request
Nov 26, 2018
* Translations for Aggregations in Visual Builder * Refactoring * Translate agg_lookup * Update ids * Add translation * Replace namespace metrics to tsvb * Change order in i18nrc file * Fix issues * Fix issues * Fix label calculating * Fix minor issue
Nox911
pushed a commit
that referenced
this pull request
Nov 26, 2018
* Translations for Aggregations in Visual Builder * Refactoring * Translate agg_lookup * Update ids * Add translation * Replace namespace metrics to tsvb * Change order in i18nrc file * Fix issues * Fix issues * Fix label calculating * Fix minor issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translations for Aggregations in Visual Builder
Issue #23257