[Controls] Restore fallback to dataViewId stored explicitly in control state

[Zacqary]

Summary

Fixes an issue in which legacy controls that stored a dataViewId in their state, but did not store a dataViewRefName or have a broken dataViewRefName, would throw an Internal Server Error by transforming into a control with an empty data_view_id.

Release note: This fix is only applicable to serverless deployments.

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[markov00]

if both of them are missing, should we just throw instead if fallback to an empty id that would cause other issues in the flow?

[markov00]

I'm testing this with the dashboard I shared on Slack and it doesn't seems to work:
before this return, if I print out dataViewRef and state.dataViewId I got this:

{
  dataViewRef: {
    name: 'b26a76ac-d257-4144-bd62-c70651312b37:optionsListDataView',
    type: 'index-pattern',
    id: ''
  },
  state: {
    use_global_filters: true,
    ignore_validations: false,
    field_name: 'resource.attributes.host.name',
    exclude: false,
    sort: { by: '_count', direction: 'desc' },
    exists_selected: false,
    run_past_timeout: false,
    search_technique: 'exact',
    selected_options: [],
    single_select: true,
    dataViewRefName: 'b26a76ac-d257-4144-bd62-c70651312b37:optionsListDataView'
  }
}

[Zacqary]

Ah. Well. In that case it looks like you've got a busted dataViewRef.

This PR will unfortunately not fix that particular dashboard. It'll fix some other dashboards that are breaking in other ways.

I'll add a throw for cases like this.

[Zacqary]

@markov00 Reverting this throw. The data control needs to have a data_view_id of '' for its own internal error handling around missing data views. Throwing in the transform was causing the control to never render at all and broke several Scout tests

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: e8faa06

Failed CI Steps

• Jest Tests #10
• FTR Configs #108

Test Failures

• [job] [logs] FTR Configs #108 / serverless search UI Rule details Edit rule with deleted connector should show and update deleted connectors when there are existing connectors of the same type
• [job] [logs] Jest Tests #10 / TagsField passes validation when tags are exactly 64 characters
• [job] [logs] Jest Tests #10 / TagsField shows validation error on submit when a tag exceeds 64 characters

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/controls-schemas	50	51	+1

Unknown metric groups

API count

id	before	after	diff
@kbn/controls-schemas	53	54	+1

History

• 💔 Build #422742 failed ba599b3
• 💔 Build #422172 failed 042ed3c
• 💔 Build #422120 failed bd691bc
• 💔 Build #422077 failed c457fa5
• 💔 Build #419985 failed dce2c27

[Heenawter]

LGTM - code review only. Nice test additions 🎉