[APM] Migrate charts to typescript#25514
Conversation
sorenlouv
force-pushed
the
typescript-migration
branch
from
c2257ff to
3ce8392
Compare
💔 Build Failed |
💔 Build Failed |
There was a problem hiding this comment.
Not sure if Coordinate is the correct term. LMK if you have something more apt.
sorenlouv
force-pushed
the
typescript-migration
branch
from
3ce8392 to
1239fe4
Compare
tsconfig.json
Outdated
There was a problem hiding this comment.
@mattapperson Following up on #24425 I've added support for importing json files but disabled it for the browser (see tsconfig.browser.json).
💔 Build Failed |
💔 Build Failed |
sorenlouv
force-pushed
the
typescript-migration
branch
from
522ef1e to
767af9a
Compare
💔 Build Failed |
sorenlouv
force-pushed
the
typescript-migration
branch
from
767af9a to
e2cf2b7
Compare
💔 Build Failed |
sorenlouv
force-pushed
the
typescript-migration
branch
from
9678017 to
f0dad8b
Compare
💚 Build Succeeded |
💚 Build Succeeded |
sorenlouv
force-pushed
the
typescript-migration
branch
from
f0dad8b to
09706dd
Compare
sorenlouv
force-pushed
the
typescript-migration
branch
from
09706dd to
07801ba
Compare
💚 Build Succeeded |
jasonrhodes
left a comment
jasonrhodes
left a comment
There was a problem hiding this comment.
Just a couple comments/questions/suggestions but nothing that blocks a merge. Nice work!
There was a problem hiding this comment.
I think TimeSeries would be fine (series is singular and plural) 😄
There was a problem hiding this comment.
I was actually wondering about that. "timeserie" sounded weird. Thanks!
There was a problem hiding this comment.
I assume this is because we're using the types from our old lodash version and so we don't have the type for this individual lodash.mean package?
There was a problem hiding this comment.
Yeah, I tried installing @types/lodash.mean and it's expecting mean to be in lodash (which it's only for 4.x)
|
Closing in favor of #25848 |
4 participants
No description provided.