add dynamic json typing for typescript imports#24425
Closed
mattapperson wants to merge 2 commits intoelastic:masterfrom
Closed
add dynamic json typing for typescript imports#24425mattapperson wants to merge 2 commits intoelastic:masterfrom
mattapperson wants to merge 2 commits intoelastic:masterfrom
Conversation
mattapperson
added
chore
non-issue
spalger
approved these changes
Oct 23, 2018
sorenlouv
approved these changes
Oct 23, 2018
Member
|
fyi @jasonrhodes |
Contributor
💔 Build Failed |
Contributor
Author
|
Ah there is a bug here microsoft/TypeScript#25755 // CC @spalger |
Contributor
💔 Build Failed |
sorenlouv
reviewed
Oct 23, 2018
| "tslint-config-prettier": "^1.15.0", | ||
| "tslint-plugin-prettier": "^2.0.0", | ||
| "typescript": "^3.0.3", | ||
| "typescript": "^3.1.3", |
Contributor
Author
|
Aborting PR, after further research TS added this feature, "fixed it" and now only supports commons module types due to es module spec not supporting json imports. |
This was referenced Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the "new" as of 2.9
resolveJsonModuletsconfig flag to Kibana. This allows the import of static JSON such as the EUI configs as typed files vsany