[I18n] Inject Intl Polyfill to PhantomJS#25465
Merged
LeanidShutau merged 8 commits intoelastic:masterfrom Nov 16, 2018
Merged
Conversation
LeanidShutau
added
Team:Core
Contributor
|
Pinging @elastic/kibana-platform |
azasypkin
added
zDeprecated Feature:Reporting
Contributor
|
Pinging @elastic/kibana-app |
LeanidShutau
changed the title
LeanidShutau
force-pushed
the
fix/i18n-inject-intl-to-phantom
branch
from
8fafb62 to
c46409c
Compare
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
This was referenced Nov 13, 2018
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
azasypkin
reviewed
Nov 15, 2018
x-pack/plugins/reporting/server/browsers/phantom/driver/index.js
Outdated
Show resolved
Hide resolved
azasypkin
reviewed
Nov 15, 2018
x-pack/plugins/reporting/server/browsers/phantom/driver/index.js
Outdated
Show resolved
Hide resolved
azasypkin
reviewed
Nov 15, 2018
x-pack/plugins/reporting/server/browsers/phantom/driver/index.js
Outdated
Show resolved
Hide resolved
azasypkin
reviewed
Nov 15, 2018
Contributor
|
Hey @tsullivan, Would you mind taking a look at this PR and let us know if it looks good to you? Thanks! |
Contributor
💚 Build Succeeded |
maryia-lapata
approved these changes
Nov 16, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
LGTM.
@LeanidShutau thank you for fixing this issue!
LeanidShutau
added a commit
to LeanidShutau/kibana
that referenced
this pull request
Nov 16, 2018
* [I18n] Inject Intl Polyfill to PhantomJS * Refactor injection code * Move intl to "dependencies" * Move 'intl' to the root 'package.json' * Fix polyfills paths * Move intl to x-pack package.json
LeanidShutau
added a commit
that referenced
this pull request
Nov 16, 2018
Contributor
Author
|
6.x/6.6: afbc1ce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
PhantomJS doesn't have
Intlproperty in the global object, soreact-intlthrows[React Intl] The `Intl` APIs must be available in the runtime, and do not appear to be built-inerror.
Fix
Inject
Intlpolyfill fromintlpackage