[i18n] Translations for Monitoring: Cluster and Alerts by maryia-lapata · Pull Request #24736 · elastic/kibana

maryia-lapata · 2018-10-29T13:40:53Z

Translations for Monitoring: Cluster and Alerts pages

Fixes: #24713

Nox911

Please fix comments

x-pack/plugins/monitoring/public/components/cluster/overview/apm_panel.js

x-pack/plugins/monitoring/public/components/cluster/overview/beats_panel.js

x-pack/plugins/monitoring/public/components/cluster/overview/elasticsearch_panel.js

x-pack/plugins/monitoring/public/components/cluster/overview/license_text.js

x-pack/plugins/monitoring/public/components/cluster/overview/logstash_panel.js

Nox911

Good work! Please fix some minor comments, and let's discuss some names of id.

x-pack/plugins/monitoring/public/directives/alerts/index.js

x-pack/plugins/monitoring/public/directives/cluster/listing/index.js

Nox911 · 2018-10-30T11:25:44Z

LGTM

chrisronline · 2018-10-30T14:49:08Z

Do I need anything setup to test this? Or maybe more broadly, how do I test this? :)

maryia-lapata · 2018-10-30T15:35:35Z

@chrisronline you can set up a pseudo-locale to see what labels are translated. Pseudo-locale adds diacritical mark to each [A-Za-z] character and duplicates every third character to increase messages length by approx. 33%. It's also used to check whether ui breaks with increased message length or not.

How to use:

Set i18n.locale to en-xa in ./config/kibana.yml
Restart yarn start.

There is one more way to test translation. It's possible to check custom locale. It's more complex because this approach hasn't automated yet. Here are the steps:

run command node scripts/i18n_check --output ./. It will generate en.json file with default translations and it place the file in the root folder.
create for example fr.json file (fr is locale name here), copy translations from en.json, update messages in fr.json according to locale (you can just update one or several messages or for example add special symbols at the begging and at the end of messages ("$$some message$$")).
point plugin to the translation file. For example, in src/core_plugins/kibana/index.js add path to fr.json file in translations array:

translations: [
	        require('path').resolve(__dirname, './../../../fr.json')
	      ],

set up locale in config/kibana.yml by changing i18n.locale param. (i18n.locale: "fr")
Restart yarn start.

To make PRs easy to review we are splitting all Monitoring translations into several PRs. So please take into account that one screen (for example Cluster) may be translated not fully in one PR, because we translate folder by folder and some labels on the screen can be translated in other PR.

chrisronline

This is great! I added a couple comments/questions but this is looking great!

x-pack/plugins/monitoring/public/components/cluster/overview/apm_panel.js

chrisronline · 2018-10-30T19:09:05Z

x-pack/plugins/monitoring/public/components/cluster/overview/elasticsearch_panel.js

+                <FormattedMessage
+                  id="xpack.monitoring.cluster.overview.esPanel.jvmHeapLabel"
+                  defaultMessage="{javaVirtualMachine} Heap"
+                  values={{ javaVirtualMachine: 'JVM' }}


So JVM is not something translated, but I see Elasticsearch not used like this, does that mean Elasticsearch will be translated?

No. There is also Kibana translation glossary (https://docs.google.com/document/d/1e-lHAPAtxodP8U4gbwA3lw8FyhhW7M303--77nMpe8w/edit) that contains terms that will remain untranslated.
Mostly we put in values such technical labels like property names url.body.query.

chrisronline · 2018-10-31T13:00:50Z

x-pack/plugins/monitoring/public/components/cluster/overview/elasticsearch_panel.js

+      statusIndicator={statusIndicator}
+      url="elasticsearch"
+      title={props.intl.formatMessage({
+        id: 'xpack.monitoring.cluster.overview.esPanel.elasticsearchTitle', defaultMessage: 'Elasticsearch' })}


Shouldn't Elasticsearch be not translated, per this comment?

You're right, it shouldn't.
I reverted this change.

chrisronline

LGTM (once tests are passing)

elasticmachine · 2018-11-08T16:37:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

maryia-lapata · 2018-11-13T08:23:55Z

Blocked by #25465.

elasticmachine · 2018-11-16T10:22:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Translations for Cluster and Alerts * Translations for cluster and alerts * Translations for cluster and alerts * Fix typos * Update id * Update Notification snapshot * Translate lastEvent label * Revert changes for untranslated label.

Translations for Cluster and Alerts

8308ce8

maryia-lapata added Project:i18n Team:Monitoring Stack Monitoring team v6.6.0 labels Oct 29, 2018

maryia-lapata requested a review from Nox911 October 29, 2018 13:40

Translations for cluster and alerts

d6ab54d

Nox911 reviewed Oct 30, 2018

View reviewed changes

Translations for cluster and alerts

9f1f062

Nox911 suggested changes Oct 30, 2018

View reviewed changes

maryia-lapata added 3 commits October 30, 2018 14:07

Fix typos

e1a5af0

Update id

61234ad

Update Notification snapshot

3e52b44

Nox911 approved these changes Oct 30, 2018

View reviewed changes

Merge branch 'master' into feature/translations/monitoring-cluster

7816e55

maryia-lapata requested a review from chrisronline October 30, 2018 14:09

chrisronline reviewed Oct 30, 2018

View reviewed changes

maryia-lapata added 3 commits October 31, 2018 15:01

Translate lastEvent label

f0daf7c

Merge branch 'master' into feature/translations/monitoring-cluste

4f0cdad

Merge branch 'master' into feature/translations/monitoring-cluster

0ce9481

chrisronline reviewed Oct 31, 2018

View reviewed changes

maryia-lapata added 2 commits October 31, 2018 16:35

Revert changes for untranslated label.

b087246

Merge branch 'master' into feature/translations/monitoring-cluster

17c3a75

elastic deleted a comment from elasticmachine Nov 1, 2018

chrisronline approved these changes Nov 1, 2018

View reviewed changes

maryia-lapata added 6 commits November 1, 2018 23:12

Merge branch 'master' into feature/translations/monitoring-cluster

399d5b4

Merge branch 'master' into feature/translations/monitoring-cluster

6daeca2

Merge branch 'master' into feature/translations/monitoring-cluster

0551f1e

Merge branch 'master' into feature/translations/monitoring-cluster

ded0602

Merge branch 'master' into feature/translations/monitoring-cluster

1eabd5e

Merge branch 'master' into feature/translations/monitoring-cluster

f0e6e7b

elastic deleted a comment from elasticmachine Nov 8, 2018

Merge branch 'master' into feature/translations/monitoring-cluster

b564634

Merge branch 'master' into feature/translations/monitoring-cluster

f736832

maryia-lapata merged commit 11cda77 into elastic:master Nov 16, 2018

maryia-lapata deleted the feature/translations/monitoring-cluster branch November 16, 2018 12:03

maryia-lapata mentioned this pull request Nov 20, 2018

[6.x] [i18n] Translations for Monitoring: Cluster and Alerts (#24736) #25924

Merged

maryia-lapata added the backported label Nov 20, 2018

Conversation

maryia-lapata commented Oct 29, 2018

Uh oh!

Nox911 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nox911 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nox911 commented Oct 30, 2018

Uh oh!

chrisronline commented Oct 30, 2018

Uh oh!

maryia-lapata commented Oct 30, 2018

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrisronline Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

maryia-lapata Oct 31, 2018

Choose a reason for hiding this comment

Uh oh!

chrisronline Oct 31, 2018

Choose a reason for hiding this comment

Uh oh!

maryia-lapata Oct 31, 2018

Choose a reason for hiding this comment

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 8, 2018

💔 Build Failed

Uh oh!

maryia-lapata commented Nov 13, 2018

Uh oh!

elasticmachine commented Nov 16, 2018

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants