Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/platform/packages/shared/kbn-esql-utils/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@
*/

export const ENABLE_ESQL = 'enableESQL';
export const FEEDBACK_LINK = 'https://ela.st/esql-feedback';
2 changes: 1 addition & 1 deletion src/platform/packages/shared/kbn-esql-utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,4 @@ export {
type ESQLStatsQueryMeta,
} from './src';

export { ENABLE_ESQL, FEEDBACK_LINK } from './constants';
export { ENABLE_ESQL } from './constants';
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import React, { useState, useCallback } from 'react';
import { i18n } from '@kbn/i18n';
import { FEEDBACK_LINK } from '@kbn/esql-utils';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be probably also removed from the package.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Removed: d29a4d7.

import {
EuiModal,
EuiModalBody,
Expand All @@ -22,11 +21,9 @@ import {
EuiCheckbox,
EuiFlexItem,
EuiFlexGroup,
EuiLink,
EuiHorizontalRule,
useGeneratedHtmlId,
} from '@elastic/eui';
import { useDiscoverServices } from '../../../../../hooks/use_discover_services';

export interface ESQLToDataViewTransitionModalProps {
onClose: (dismissFlag?: boolean, needsSave?: boolean) => void;
Expand All @@ -40,8 +37,6 @@ export default function ESQLToDataViewTransitionModal({
const onTransitionModalDismiss = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
setDismissModalChecked(e.target.checked);
}, []);
const { notifications } = useDiscoverServices();
const isFeedbackEnabled = notifications.feedback.isEnabled();
const modalTitleId = useGeneratedHtmlId({
prefix: 'discover-esql-to-dataview-modal-title',
});
Expand All @@ -68,17 +63,6 @@ export default function ESQLToDataViewTransitionModal({
'Switching data views removes the current ES|QL query. Save this session to avoid losing work.',
})}
</EuiText>
{isFeedbackEnabled && (
<EuiFlexGroup alignItems="center" justifyContent="flexEnd" gutterSize="xs">
<EuiFlexItem grow={false}>
<EuiLink external href={FEEDBACK_LINK} target="_blank">
{i18n.translate('discover.esqlToDataViewTransitionModal.feedbackLink', {
defaultMessage: 'Submit ES|QL feedback',
})}
</EuiLink>
</EuiFlexItem>
</EuiFlexGroup>
)}
<EuiHorizontalRule margin="s" />
</EuiModalBody>
<EuiModalFooter css={{ paddingBlockStart: 0 }}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2465,7 +2465,6 @@
"discover.esqlMode.selectedColumnsCallout": "Es werden {selectedColumnsNumber} von {esqlQueryColumnsNumber} Feldern angezeigt. Fügen Sie weitere Felder aus der Liste „Verfügbare Felder“ hinzu.",
"discover.esqlToDataViewTransitionModal.closeButtonLabel": "Verwerfen und wechseln",
"discover.esqlToDataViewTransitionModal.dismissButtonLabel": "Fragen Sie mich nicht noch einmal",
"discover.esqlToDataViewTransitionModal.feedbackLink": "ES|QL-Feedback einreichen",
"discover.esqlToDataViewTransitionModal.saveButtonLabel": "Speichern und wechseln",
"discover.esqlToDataViewTransitionModal.title": "Nicht gespeicherte Änderungen",
"discover.esqlToDataviewTransitionModalBody": "Beim Wechseln der Datenquellen wird die aktuelle ES|QL-Abfrage entfernt. Speichern Sie diese Sitzung, um einen Arbeitsverlust zu vermeiden.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2484,7 +2484,6 @@
"discover.esqlMode.selectedColumnsCallout": "Affichage de {selectedColumnsNumber} champ(s) sur {esqlQueryColumnsNumber}. Ajoutez-en d'autres depuis la liste des champs disponibles.",
"discover.esqlToDataViewTransitionModal.closeButtonLabel": "Annuler et changer",
"discover.esqlToDataViewTransitionModal.dismissButtonLabel": "Ne plus me demander",
"discover.esqlToDataViewTransitionModal.feedbackLink": "Soumettre des commentaires ES|QL",
"discover.esqlToDataViewTransitionModal.saveButtonLabel": "Sauvegarder et basculer",
"discover.esqlToDataViewTransitionModal.title": "Modifications non enregistrées",
"discover.esqlToDataviewTransitionModalBody": "Un changement de vue de données supprime la requête ES|QL en cours. Enregistrez cette session pour éviter de perdre votre travail.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2484,7 +2484,6 @@
"discover.esqlMode.selectedColumnsCallout": "{esqlQueryColumnsNumber}フィールド中{selectedColumnsNumber}フィールドを表示します。利用可能なフィールドリストからさらに追加します。",
"discover.esqlToDataViewTransitionModal.closeButtonLabel": "破棄して切り替える",
"discover.esqlToDataViewTransitionModal.dismissButtonLabel": "次回以降確認しない",
"discover.esqlToDataViewTransitionModal.feedbackLink": "ES|QLフィードバックを送信",
"discover.esqlToDataViewTransitionModal.saveButtonLabel": "保存して切り替え",
"discover.esqlToDataViewTransitionModal.title": "保存されていない変更",
"discover.esqlToDataviewTransitionModalBody": "データビューを切り替えると、現在のES|QLクエリが削除されます。作業が失われないようにするには、このセッションを保存してください。",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2477,7 +2477,6 @@
"discover.esqlMode.selectedColumnsCallout": "显示 {selectedColumnsNumber} 个字段,共 {esqlQueryColumnsNumber} 个。从可用字段列表中添加更多字段。",
"discover.esqlToDataViewTransitionModal.closeButtonLabel": "丢弃并切换",
"discover.esqlToDataViewTransitionModal.dismissButtonLabel": "不再询问我",
"discover.esqlToDataViewTransitionModal.feedbackLink": "提交 ES|QL 反馈",
"discover.esqlToDataViewTransitionModal.saveButtonLabel": "保存并切换",
"discover.esqlToDataViewTransitionModal.title": "未保存的更改",
"discover.esqlToDataviewTransitionModalBody": "切换数据视图会移除当前的 ES|QL 查询。保存此会话以避免丢失工作。",
Expand Down
Loading