Skip to content

[Discover] Remove ES|QL modal feedback link#253875

Merged
davismcphee merged 4 commits intoelastic:mainfrom
davismcphee:discover-esql-feedback-link
Feb 20, 2026
Merged

[Discover] Remove ES|QL modal feedback link#253875
davismcphee merged 4 commits intoelastic:mainfrom
davismcphee:discover-esql-feedback-link

Conversation

@davismcphee
Copy link
Copy Markdown
Contributor

Summary

Resolves #253400.

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@davismcphee davismcphee self-assigned this Feb 19, 2026
@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Feb 19, 2026
@davismcphee davismcphee marked this pull request as ready for review February 19, 2026 19:21
@davismcphee davismcphee requested a review from a team as a code owner February 19, 2026 19:21
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)


import React, { useState, useCallback } from 'react';
import { i18n } from '@kbn/i18n';
import { FEEDBACK_LINK } from '@kbn/esql-utils';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be probably also removed from the package.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Removed: d29a4d7.

@davismcphee davismcphee requested a review from a team as a code owner February 20, 2026 15:39
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-utils 141 140 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.6MB 1.6MB -373.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 25.1KB 25.1KB -41.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-utils 195 194 -1

History

cc @davismcphee

@davismcphee davismcphee merged commit 8e9906d into elastic:main Feb 20, 2026
16 checks passed
@davismcphee davismcphee deleted the discover-esql-feedback-link branch February 20, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "Submit feedback" link in the module

5 participants