[CPS] Support data view requests and do not sanitize project_routing in data plugin/resolve indices by mbondyra · Pull Request #253654 · elastic/kibana

mbondyra · 2026-02-18T09:10:15Z

Summary

This PR does 3 things:

Enables data views to query fields scoped to specific projects when CPS is active.
Removes sanitization of the projectRouting parameter. We need to loosen this to support expressions in the future. It was originally added to ease development while es-client had a bug, but now that the bug is fixed, it’s no longer needed.
Removes placing the project_routing parameter directly in the request body—es-client handles this internally.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

elasticmachine · 2026-02-23T12:28:54Z

Pinging @elastic/kibana-presentation (Team:Presentation)

mbondyra · 2026-02-23T13:40:28Z

  overrideValue: ProjectRouting,
  cpsManager?: ICPSManager
 ): ISearchOptions['projectRouting'] {
-  return cpsManager && cpsManager.getProjectPickerAccess() !== ProjectRoutingAccess.DISABLED


this check is already done inside cpsManager so no need to have it here

elasticmachine · 2026-02-24T00:49:51Z

💚 Build Succeeded

Buildkite Build
Commit: 49bc495

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`data`	626	612	-14
`embeddableAlertsTable`	581	580	-1
`ml`	4216	4215	-1
total			-16

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/cps-utils`	44	45	+1
`data`	2612	2614	+2
`dataViews`	452	453	+1
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataViews`	2.0KB	2.0KB	-44.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cps`	5.8KB	5.8KB	+11.0B
`data`	439.1KB	438.9KB	-190.0B
`dataViews`	63.2KB	63.5KB	+297.0B
`kbnUiSharedDeps-srcJs`	4.7MB	4.7MB	-83.0B
total			+35.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/cps-utils`	47	48	+1
`@kbn/es-query`	312	310	-2
`data`	3233	3235	+2
`dataViews`	1254	1257	+3
total			+4

History

This reverts commit 5f98729.

olapawlus

Unblocking CI

delanni

limits.yml 👍

…ps-config-rebase * commit 'f135f030951237c5e9b0251931441aee3121b31d': (163 commits) [CPS] Support data view requests and do not sanitize project_routing in data plugin/resolve indices (elastic#253654) [One Workflow] Execute workflow from historical (elastic#253396) [streams][background tasks] gracefully handle non existing stream (elastic#254683) [Lens API] Waffle/Mosaic get green as a default color (elastic#254304) [Security Solution] Remove prebuilt rules customization callout on Rule Management page (elastic#254386) [Workflows] support passing attachments to run_agent step (elastic#251291) [One Discover][Logs UX] Update OpenTelemetry Semantic Conventions (elastic#254367) [kbn-es] Add --docker flag to yarn es snapshot (elastic#254306) [Workplace AI] Remove Data Source Config (elastic#254521) [Entity Store v2] Add CRUD API (elastic#252052) [CI] Increase type checking machine (elastic#254676) [main] Sync bundled packages with Package Storage (elastic#254232) Skip flaky test elastic#254625 (elastic#254662) Upgrade `@elastic/elasticsearch` to 9.3.1 (elastic#253660) [One Workflow] Migrate http step to new connector (elastic#249004) [Entity Store] Store EUID Scripts (elastic#254515) [APM] Fix Otel missing fields undefined errors (elastic#254271) [Console] Add support for documentation links on Serverless (elastic#254489) Create edit ILM flow (elastic#253393) [Agent Builder] Mid term: minimal recommended model set elastic#12875 (elastic#254560) ...

…in data plugin/resolve indices (elastic#253654) ## Summary This PR does 3 things: 1. Enables data views to query fields scoped to specific projects when CPS is active. 2. Removes sanitization of the projectRouting parameter. We need to loosen this to support expressions in the future. It was originally added to ease development while es-client had a bug, but now that the bug is fixed, it’s no longer needed. 3. Removes placing the project_routing parameter directly in the request body—es-client handles this internally. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

mbondyra force-pushed the cps_do_not_sanitize branch 2 times, most recently from 2860528 to 668bed9 Compare February 20, 2026 13:33

mbondyra changed the title ~~[CPS] Do not sanitize project_routing in data plugin/resolve indices~~ [CPS] Support data view requests and do not sanitize project_routing in data plugin/resolve indices Feb 20, 2026

mbondyra force-pushed the cps_do_not_sanitize branch 2 times, most recently from 4b5f52d to 2928f0f Compare February 23, 2026 12:01

mbondyra marked this pull request as ready for review February 23, 2026 12:26

mbondyra requested review from a team as code owners February 23, 2026 12:26

mbondyra added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Feb 23, 2026

mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 23, 2026

to revert after elastic#253654 is merged

2c860e1

mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 23, 2026

to revert after elastic#253654 is merged

5f98729

mbondyra force-pushed the cps_do_not_sanitize branch from 2928f0f to 15e99e4 Compare February 23, 2026 13:39

mbondyra commented Feb 23, 2026

View reviewed changes

data view support, sanitization removal

deeb9e2

mbondyra force-pushed the cps_do_not_sanitize branch from 15e99e4 to deeb9e2 Compare February 23, 2026 19:29

lukasolson approved these changes Feb 23, 2026

View reviewed changes

mbondyra enabled auto-merge (squash) February 23, 2026 20:28

mbondyra disabled auto-merge February 23, 2026 20:28

mbondyra requested review from a team as code owners February 23, 2026 20:48

mbondyra force-pushed the cps_do_not_sanitize branch from d6225b9 to a46174d Compare February 23, 2026 22:53

mbondyra requested a review from a team as a code owner February 23, 2026 22:53

allow the override value inside project picker

49bc495

mbondyra force-pushed the cps_do_not_sanitize branch from a46174d to 49bc495 Compare February 23, 2026 22:55

mbondyra added a commit to rgodfrey-elastic/kibana that referenced this pull request Feb 24, 2026

Revert "to revert after elastic#253654 is merged"

6732a52

This reverts commit 5f98729.

olapawlus approved these changes Feb 24, 2026

View reviewed changes

delanni approved these changes Feb 24, 2026

View reviewed changes

mbondyra merged commit f135f03 into elastic:main Feb 24, 2026
16 checks passed

mbondyra deleted the cps_do_not_sanitize branch February 24, 2026 13:04

kibanamachine added the v9.4.0 label Feb 24, 2026

gsoldevila mentioned this pull request Mar 10, 2026

[CPS] Introduce kbn-project-routing header for simplified project_routing propagation #256839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CPS] Support data view requests and do not sanitize project_routing in data plugin/resolve indices #253654

[CPS] Support data view requests and do not sanitize project_routing in data plugin/resolve indices #253654
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:cps_do_not_sanitize

mbondyra commented Feb 18, 2026 •

edited

Loading

Uh oh!

elasticmachine commented Feb 23, 2026

Uh oh!

mbondyra Feb 23, 2026

Uh oh!

elasticmachine commented Feb 24, 2026

API count

Uh oh!

olapawlus left a comment

Uh oh!

delanni left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mbondyra commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Identify risks

Uh oh!

elasticmachine commented Feb 23, 2026

Uh oh!

mbondyra Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Feb 24, 2026

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

olapawlus left a comment

Choose a reason for hiding this comment

Uh oh!

delanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mbondyra commented Feb 18, 2026 •

edited

Loading