Conversation
kubasobon
added
release_note:skip
kubasobon
force-pushed
the
entity-store-v2-crud
branch
from
d9aa08d to
a95d6e7
Compare
Member
Author
|
Ready for your re-reviews, gentlemen. @romulets PTAL #252052 (comment) 🙂 |
kubasobon
requested review from
chennn1990,
hop-dev,
orouz,
romulets and
uri-weisman
uri-weisman
approved these changes
Feb 23, 2026
chennn1990
approved these changes
Feb 23, 2026
hop-dev
reviewed
Feb 23, 2026
hop-dev
reviewed
Feb 23, 2026
| }); | ||
| } | ||
|
|
||
| public async deleteEntity(id: string): Promise<void> { |
Contributor
There was a problem hiding this comment.
we spoke in slack, we need to align ID behaviour between upsert and delete, should this take the hashed or unhashed ID?
Member
Author
There was a problem hiding this comment.
DELETE endpoint now requires an object containing EUID in request body to remove entities. Example: { entityId: 'generic:this-is-my-id' }
romulets
reviewed
Feb 23, 2026
|
|
||
| const readyDoc = validateAndTransformDoc(entityType, this.namespace, doc, force); | ||
|
|
||
| const { result } = await this.esClient.update({ |
romulets
approved these changes
Feb 23, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| export function hashEuid(id: string): string { | ||
| // EUID generation uses MD5. It is not a security-related feature. | ||
| // eslint-disable-next-line @kbn/eslint/no_unsafe_hash | ||
| return createHash('md5').update(id).digest('hex'); |
Check warning
Code scanning / CodeQL
Using weak hashing algorithm Medium
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @kubasobon |
mbondyra
added a commit
to rgodfrey-elastic/kibana
that referenced
this pull request
Feb 24, 2026
…ps-config-rebase * commit 'f135f030951237c5e9b0251931441aee3121b31d': (163 commits) [CPS] Support data view requests and do not sanitize project_routing in data plugin/resolve indices (elastic#253654) [One Workflow] Execute workflow from historical (elastic#253396) [streams][background tasks] gracefully handle non existing stream (elastic#254683) [Lens API] Waffle/Mosaic get green as a default color (elastic#254304) [Security Solution] Remove prebuilt rules customization callout on Rule Management page (elastic#254386) [Workflows] support passing attachments to run_agent step (elastic#251291) [One Discover][Logs UX] Update OpenTelemetry Semantic Conventions (elastic#254367) [kbn-es] Add --docker flag to yarn es snapshot (elastic#254306) [Workplace AI] Remove Data Source Config (elastic#254521) [Entity Store v2] Add CRUD API (elastic#252052) [CI] Increase type checking machine (elastic#254676) [main] Sync bundled packages with Package Storage (elastic#254232) Skip flaky test elastic#254625 (elastic#254662) Upgrade `@elastic/elasticsearch` to 9.3.1 (elastic#253660) [One Workflow] Migrate http step to new connector (elastic#249004) [Entity Store] Store EUID Scripts (elastic#254515) [APM] Fix Otel missing fields undefined errors (elastic#254271) [Console] Add support for documentation links on Serverless (elastic#254489) Create edit ILM flow (elastic#253393) [Agent Builder] Mid term: minimal recommended model set elastic#12875 (elastic#254560) ...
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Feb 25, 2026
Closes elastic#245018 ## TODO: - [x] Add the 3 API routes - [x] Add Entity Manager to handle the operations - [x] Rebase onto single index code - [ ] ~~Update Entity schema with missing fields~~ We decided Entity v2 schema changes will get their own PR - [x] Support bulk async - [x] Update with Unique ID generation - [x] Add Scout tests - [ ] ~~Update documentation~~ Separate PR --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Mar 11, 2026
Closes elastic#245018 ## TODO: - [x] Add the 3 API routes - [x] Add Entity Manager to handle the operations - [x] Rebase onto single index code - [ ] ~~Update Entity schema with missing fields~~ We decided Entity v2 schema changes will get their own PR - [x] Support bulk async - [x] Update with Unique ID generation - [x] Add Scout tests - [ ] ~~Update documentation~~ Separate PR --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245018
TODO:
Update Entity schema with missing fieldsWe decided Entity v2 schema changes will get their own PRUpdate documentationSeparate PR