[One Workflow][Bug] Toggling workflow enabled state corrupts YAML conten#252676

Merged

rosomri merged 2 commits intoelastic:mainfrom

rosomri:preserve_yaml_content_when_toggeling

Feb 11, 2026

Contributor

rosomri commented Feb 11, 2026 •

edited by kibanamachine

Loading

Summary

Fixes a bug where toggling a workflow's enabled state (or updating name/description/tags) would corrupt the stored YAML. The server was performing a full YAML → JSON → YAML roundtrip just to update metadata fields, which:

Dropped all YAML comments and blank lines
Corrupted template expressions like {{ inputs.comment }} into "{ inputs.comment }": null

Before

Screen.Recording.2026-02-11.at.10.49.58.mov

After

Screen.Recording.2026-02-11.at.11.55.05.mov

Fix

Replaced the parse-modify-stringify approach in workflows_management_service.ts with updateWorkflowYamlFields(), which edits fields in-place on the YAML AST (using parseDocument with keepSourceTokens: true), preserving all comments, formatting, and template expressions.

Test plan

Added unit tests for updateYamlField and updateWorkflowYamlFields covering comment/blank line/template expression preservation
Added CRUD-level test in workflows_management_service.test.ts verifying the full update flow preserves YAML integrity when toggling enabled

rosomri added 2 commits

February 11, 2026 11:45


          Fixes a bug where toggling a workflow's state (or updating name/descr…

372fb5e

…iption/tags) would corrupt the stored YAML. The server was performing a full YAML > JSON > YAML roundtrip just to update metadata fields


          Fixes a bug where toggling a workflow's state (or updating name/descr…

adf4037

…iption/tags) would corrupt the stored YAML. The server was performing a full YAML > JSON > YAML roundtrip just to update metadata fields

rosomri requested a review from a team as a code owner

February 11, 2026 09:53

rosomri added release_note:skip backport:version Team:One Workflow v9.3.0 v9.3.1 labels

rosomri marked this pull request as draft

February 11, 2026 09:57

rosomri marked this pull request as ready for review

February 11, 2026 09:57

rosomri changed the title ~~Preserve yaml content when toggeling~~ [One Workflow][Bug] Toggling workflow enabled state corrupts YAML conten

rosomri linked an issue

that may be closed by this pull request

[One Workflow][Bug] Toggling workflow enabled state corrupts YAML content #252663

Closed

skynetigor approved these changes

View reviewed changes

Contributor

skynetigor left a comment

LGTM

Contributor

elasticmachine commented Feb 11, 2026

💚 Build Succeeded

Buildkite Build
Commit: adf4037

Metrics [docs]

✅ unchanged

rosomri merged commit 32773f8 into elastic:main

31 checks passed

kibanamachine added the v9.4.0 label

Contributor

kibanamachine commented Feb 11, 2026

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/21904391570

Contributor

kibanamachine commented Feb 11, 2026

💔 All backports failed

Status	Branch	Result
❌	9.3	Backport failed because of merge conflicts You might need to backport the following PRs to 9.3: - feat: add bulk workflow creation API endpoint (#252214) - perf: use refresh:true instead of wait_for for workflow CRUD APIs (#252213)

Manual backport

To create the backport manually run:

node scripts/backport --pr 252676

Questions ?

Please refer to the Backport tool documentation

kibanamachine mentioned this pull request

[Fields Metadata] Update dependency @elastic/ecs to ^9.2.0 and optimize bundle #245798

Merged

kibanamachine added the backport missing label

Contributor

kibanamachine commented Feb 12, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

9 similar comments

Contributor

kibanamachine commented Feb 13, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Feb 16, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Feb 17, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Feb 18, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Feb 19, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Feb 20, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Feb 23, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Feb 24, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Feb 25, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Mar 31, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

25 similar comments

Contributor

kibanamachine commented Apr 1, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 2, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 3, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 6, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 7, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 8, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 9, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 10, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 13, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 14, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 15, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 16, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 17, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 20, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 21, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 22, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 23, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 24, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 27, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 28, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 29, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented Apr 30, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented May 2, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented May 4, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented May 5, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

rkernutt added a commit to rkernutt/cloud-to-elastic-load-generator that referenced this pull request


          workflow: install DISABLED so users explicitly enable it

4053cec

The bundled YAML, the Setup wizard, and the CLI installer all set
`enabled: true` on create, which made it possible for a fresh install
to start running the moment a user attached it to a rule — before they
had a chance to review the notification step. The user-facing design
calls out three manual follow-up steps (review notification, attach to
rules, enable); the third one was effectively skipped because the
workflow was already enabled.

Now every install path persists `enabled: false`:

  - workflows/data-pipeline-alert-enrichment.yaml top-level flag
  - assets/workflows/ mirror (regenerated by export-standalone-assets)
  - Bulk POST /api/workflows envelope in the wizard + CLI
  - Update-existing PUT path in the wizard + CLI

Working around elastic/kibana#252676:

Kibana 9.5's Workflows API silently drops the `enabled` field when it's
sent inside a full PUT body alongside `yaml`. After the regular update,
both installers now follow up with a *partial* PUT containing just
`{ enabled: false }` — that path is unaffected by the bug. Verified end
to end on Observability Serverless 9.5.0:

  PUT /api/workflows/workflow/<id>  (full body) → 200, enabled: true (bug)
  PUT /api/workflows/workflow/<id>  ({enabled: false}) → 200, enabled: false

Post-install messaging in the wizard, CLI, and docs (workflow-deployment,
SETUP-WIZARD-AND-UNINSTALL, SetupPage description, YAML header comment)
now lists three manual steps — review notification, attach to rules,
flip the Enabled toggle — and explains that the install is intentionally
a no-op until all three are complete.

Co-authored-by: Cursor <cursoragent@cursor.com>

Contributor

kibanamachine commented May 6, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

2 similar comments

Contributor

kibanamachine commented May 7, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Contributor

kibanamachine commented May 8, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252676 locally
cc: @rosomri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport missing backport:version release_note:skip Team:One Workflow v9.3.0 v9.3.1 v9.4.0