[Fields Metadata] Update dependency @elastic/ecs to ^9.2.0 and optimize bundle#245798
[Fields Metadata] Update dependency @elastic/ecs to ^9.2.0 and optimize bundle#245798rStelmach merged 49 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/obs-onboarding-team (Team:obs-onboarding) |
| */ | ||
| import { LRUCache } from 'lru-cache'; | ||
| import hash from 'object-hash'; | ||
| import stringify from 'json-stable-stringify'; |
There was a problem hiding this comment.
note: We can get rid of object hashing and use a much lighter stable stringify here since the params are not a complex structure that requires deep hashing.
There was a problem hiding this comment.
@rStelmach we should change this in favour of @kbn/std as this was done in #251890
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
b4834c6 to
3ae1957
Compare
b2e30aa to
ba3a46f
Compare
e881bb5 to
5e15b7f
Compare
kdelemme
left a comment
There was a problem hiding this comment.
actionable-obs code change lgtm
dhurley14
left a comment
There was a problem hiding this comment.
Thanks for adding the directory and updating the backport labels after we spoke. I would like to see the number of fields in the our cypress test remain the same, just with the updated names. Thanks.
| '"matched.field":["myhash.mysha256"]', | ||
| '"matched.index":["logs-ti_abusech.malware"]', | ||
| '"matched.type":["indicator_match_rule"]', | ||
| ]; |
There was a problem hiding this comment.
This doesn't contain all the fields that were previously present. It looks like matched.atomic should now be x-pack/solutions/security/plugins/security_solution/common/field_maps/9.3.1/alerts.ts
Please update these field names to match the new ones introduced in this PR rather than deleting them.
dhurley14
left a comment
There was a problem hiding this comment.
Thanks for adding the directory and updating the backport labels after we spoke. I would like to see the number of fields in the our cypress test remain the same, just with the updated names. Thanks.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
| '"matched.field":["myhash.mysha256"]', | ||
| '"matched.index":["logs-ti_abusech.malware"]', | ||
| '"matched.type":["indicator_match_rule"]', | ||
| ]; |
|
Starting backport for target branches: 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/21904573072 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
closes: #252704 ## Summary Bumps `@elastic/ecs` from `9.2.0` to `9.3.0` and fixes all resulting CI test failures. ## Changes ### Dependency bump - **`package.json` / `yarn.lock`** - updated `@elastic/ecs` from `9.2.0` to `9.3.0` ### Snapshot updates (ECS field expansion + version string change) - **`x-pack/platform/plugins/shared/stack_alerts/server/rule_types/es_query/util.test.ts`** - updated inline snapshot for `getSourceFields()` to include ~324 new ECS fields added in 9.3.0 (e.g. `entity.*`, `entity.target.*`, `host.target.*`) - **`src/core/packages/logging/server-internal/src/__snapshots__/logging_system.test.ts.snap`** - updated `ecs.version` from `"9.3.0-dev"` to `"9.3.0"` across all snapshot entries ### Generated schema regeneration - **`src/platform/packages/shared/kbn-alerts-as-data-utils/src/schemas/generated/ecs_schema.ts`** - regenerated io-ts schemas to reflect the new ECS 9.3.0 field definitions in `ecsFieldMap` ### Test fixture updates - **`x-pack/platform/test/api_integration/apis/maps/maps_telemetry.ts`** - updated `geo_point` field count assertion from `63` to `71` to account for new ECS geo_point fields in cluster stats - **`x-pack/solutions/security/test/fixtures/es_archives/security_solution/alerts/8.1.0/mappings.json.gz`** - raised `total_fields.limit` from `2500` to `3500` in test archive mappings to prevent `illegal_argument_exception` when loading the SIEM alert fixture with expanded ECS fields (same approach used in #245798 for `8.8.0` archives, test-only, production limit in `alerts_service.ts` remains at `2500`)
closes: elastic#252704 ## Summary Bumps `@elastic/ecs` from `9.2.0` to `9.3.0` and fixes all resulting CI test failures. ## Changes ### Dependency bump - **`package.json` / `yarn.lock`** - updated `@elastic/ecs` from `9.2.0` to `9.3.0` ### Snapshot updates (ECS field expansion + version string change) - **`x-pack/platform/plugins/shared/stack_alerts/server/rule_types/es_query/util.test.ts`** - updated inline snapshot for `getSourceFields()` to include ~324 new ECS fields added in 9.3.0 (e.g. `entity.*`, `entity.target.*`, `host.target.*`) - **`src/core/packages/logging/server-internal/src/__snapshots__/logging_system.test.ts.snap`** - updated `ecs.version` from `"9.3.0-dev"` to `"9.3.0"` across all snapshot entries ### Generated schema regeneration - **`src/platform/packages/shared/kbn-alerts-as-data-utils/src/schemas/generated/ecs_schema.ts`** - regenerated io-ts schemas to reflect the new ECS 9.3.0 field definitions in `ecsFieldMap` ### Test fixture updates - **`x-pack/platform/test/api_integration/apis/maps/maps_telemetry.ts`** - updated `geo_point` field count assertion from `63` to `71` to account for new ECS geo_point fields in cluster stats - **`x-pack/solutions/security/test/fixtures/es_archives/security_solution/alerts/8.1.0/mappings.json.gz`** - raised `total_fields.limit` from `2500` to `3500` in test archive mappings to prevent `illegal_argument_exception` when loading the SIEM alert fixture with expanded ECS fields (same approach used in elastic#245798 for `8.8.0` archives, test-only, production limit in `alerts_service.ts` remains at `2500`)
📓 Summary
Closes #244577
Since a schema change in the new
@elastic/ecspackage release was conflicting with our tests, the update is being manually done here.I also took the chance to shrink some extra KBs from the bundle, removing unnecessary deps.