[Discover] Add feature flag to make ESQL the default query mode#252268
Merged
AlexGPlay merged 2 commits intoelastic:mainfrom Feb 10, 2026
Merged
[Discover] Add feature flag to make ESQL the default query mode#252268AlexGPlay merged 2 commits intoelastic:mainfrom
AlexGPlay merged 2 commits intoelastic:mainfrom
Conversation
AlexGPlay
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
approved these changes
Feb 10, 2026
Contributor
jughosta
left a comment
jughosta
left a comment
There was a problem hiding this comment.
LGTM 👍
Left some minor suggestions.
| const esArchiver = getService('esArchiver'); | ||
| const browser = getService('browser'); | ||
|
|
||
| describe('discover/query_mode', function () { |
Contributor
There was a problem hiding this comment.
Suggested change
| describe('discover/query_mode', function () { | |
| describe('discover/query_mode_esql_default', function () { |
| if (hasEsqlEnabled && queryMode === 'esql' && dataView instanceof DataView) | ||
| return { esql: getInitialESQLQuery(dataView, true) }; | ||
| if (queryMode === 'esql' && canUseEsql) return { esql: getInitialESQLQuery(dataView, true) }; | ||
| if (queryMode === 'classic') return services.data.query.queryString.getDefaultQuery(); |
Contributor
There was a problem hiding this comment.
nit: We could move the check for classic higher and combine the 2 checks for ES|QL initial query.
|
|
||
| // Reload the app and validate classic mode is persisted | ||
| await common.navigateToApp('discover', { path: '' }); | ||
| await testSubjects.existOrFail('discover-dataView-switch-link'); |
Contributor
There was a problem hiding this comment.
We might want to create new helpers instead of
await discover.expectSourceViewerToExist();await testSubjects.existOrFail('discover-dataView-switch-link');
and call them rather:
isInESQLModeisInClassicMode.
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @AlexGPlay |
jbudz
approved these changes
Feb 10, 2026
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 10, 2026
* commit '7dcc1fe3c205d2de0c3ca3f65804f21de09013c3': (285 commits) Enrich kbn-check-saved-objects-cli README with CI and manual usage docs (elastic#252557) [Discover] Add feature flag to make ESQL the default query mode (elastic#252268) Add maskProps.headerZindexLocation above to inspect component flyout (elastic#252543) [Security Solution][Atack/Alerts] Flyout header: Assignees (elastic#252190) Upgrade EUI to v112.3.0 (elastic#252315) [Fleet] Make save_knowledge_base async in streaming state machine (elastic#252328) Upgrade @smithy/config-resolver 4.3.0 → 4.4.6 (elastic#252457) [Lens as API] Add colorMapping support for XY charts (ES|QL data layers) (elastic#252051) [WorkplaceAI] Add Google Drive data source and connector (elastic#250677) [Scout] Move GlobalSearch FTR tests to Scout (elastic#252201) [EDR Workflows] Fix osquery pack results display when agent clock is skewed (elastic#251417) [Observability Onboarding] Apply integrations limit after dedup in parseIntegrationsTSV (elastic#252486) [Entity Analytics] Update `host.ip` aggregation to remove painless script (elastic#252426) Address `@elastic/eui/require-table-caption` lint violations across `@elastic/obs-presentation-team` files (elastic#251050) Consolidate JSON stringify dependencies (elastic#251890) [index mgmt] Use esql instead of query dsl to get the index count (elastic#252422) Add Usage API Plugin (elastic#252434) Cases All Templates page (elastic#250372) [Agent Builder] Default value for optional params in ESQL tools (elastic#238472) [Fleet] Add upgrade_details.metadata.reason to AgentResponseSchema (elastic#252485) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #250201
Follow up to #250388 - now on top of storing the last used query mode, if there's nothing stored as the last one, and if possible, ES|QL will be the default when the
isEsqlDefaultfeature flag is set to true.Tip
To test it set
feature_flags.overrides.discover.isEsqlDefaultto true in yourkibana.dev.ymlChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.