[Scout] Move GlobalSearch FTR tests to Scout#252201
[Scout] Move GlobalSearch FTR tests to Scout#252201kowalczyk-krzysztof merged 9 commits intoelastic:mainfrom
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10698[❌] x-pack/platform/plugins/shared/global_search/test/scout/ui/playwright.config.ts: 0/25 tests passed. |
|
@elastic/appex-qa However when I ran flaky test runner, something weird happened: The stateful run passed, but those failed: The test suites have |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
| kbnTestServer: { | ||
| ...xpackFunctionalConfig.get('kbnTestServer'), | ||
| serverArgs: [ | ||
| ...xpackFunctionalConfig.get('kbnTestServer.serverArgs'), | ||
| `--plugin-path=${resolve( | ||
| KIBANA_ROOT, | ||
| 'src/platform/test/plugin_functional/plugins/core_provider_plugin' | ||
| )}`, | ||
| ...findTestPluginPaths(resolve(__dirname, 'plugins')), | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Scout server configuration is targeting Cloud testing by default, meaning local servers setup is matching CECH/MKI setup.
Since your tests depend on some custom plugins, it won't work unless you create a custom server configs override (see this PR for instructions #244306)
When you create custom server configuration, you decide where it can be run (e.g. having only stateful one won't allow to run tests against serverless project)
There was a problem hiding this comment.
Looks like this is some legacy thing and src/platform/test/plugin_functional/plugins/core_provider_plugin is not needed as Scout provides everything it did.
There was a problem hiding this comment.
As discussed on Slack, I'm keeping the classic tests only.
This is a bug 🐛 Please check my comment about custom server definition, it won't work without it |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
bhavyarm
left a comment
There was a problem hiding this comment.
LGTM. Had kept an eye on this. Awesome work!
* commit '7dcc1fe3c205d2de0c3ca3f65804f21de09013c3': (285 commits) Enrich kbn-check-saved-objects-cli README with CI and manual usage docs (elastic#252557) [Discover] Add feature flag to make ESQL the default query mode (elastic#252268) Add maskProps.headerZindexLocation above to inspect component flyout (elastic#252543) [Security Solution][Atack/Alerts] Flyout header: Assignees (elastic#252190) Upgrade EUI to v112.3.0 (elastic#252315) [Fleet] Make save_knowledge_base async in streaming state machine (elastic#252328) Upgrade @smithy/config-resolver 4.3.0 → 4.4.6 (elastic#252457) [Lens as API] Add colorMapping support for XY charts (ES|QL data layers) (elastic#252051) [WorkplaceAI] Add Google Drive data source and connector (elastic#250677) [Scout] Move GlobalSearch FTR tests to Scout (elastic#252201) [EDR Workflows] Fix osquery pack results display when agent clock is skewed (elastic#251417) [Observability Onboarding] Apply integrations limit after dedup in parseIntegrationsTSV (elastic#252486) [Entity Analytics] Update `host.ip` aggregation to remove painless script (elastic#252426) Address `@elastic/eui/require-table-caption` lint violations across `@elastic/obs-presentation-team` files (elastic#251050) Consolidate JSON stringify dependencies (elastic#251890) [index mgmt] Use esql instead of query dsl to get the index count (elastic#252422) Add Usage API Plugin (elastic#252434) Cases All Templates page (elastic#250372) [Agent Builder] Default value for optional params in ESQL tools (elastic#238472) [Fleet] Add upgrade_details.metadata.reason to AgentResponseSchema (elastic#252485) ...
Summary
This PR migrates global search FTR tests to Scout and removes
x-pack/platform/test/plugin_functionaldirectory and all mentions of it, since the global search suite was the only thing left in that directory.Closes: https://github.com/elastic/kibana-team/issues/2812