Skip to content

[Scout] Move GlobalSearch FTR tests to Scout#252201

Merged
kowalczyk-krzysztof merged 9 commits intoelastic:mainfrom
kowalczyk-krzysztof:scout/global-search
Feb 10, 2026
Merged

[Scout] Move GlobalSearch FTR tests to Scout#252201
kowalczyk-krzysztof merged 9 commits intoelastic:mainfrom
kowalczyk-krzysztof:scout/global-search

Conversation

@kowalczyk-krzysztof
Copy link
Copy Markdown
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Feb 7, 2026

Summary

This PR migrates global search FTR tests to Scout and removes x-pack/platform/test/plugin_functional directory and all mentions of it, since the global search suite was the only thing left in that directory.

Closes: https://github.com/elastic/kibana-team/issues/2812

@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Feb 7, 2026
@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Feb 7, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10698

[❌] x-pack/platform/plugins/shared/global_search/test/scout/ui/playwright.config.ts: 0/25 tests passed.

see run history

@kowalczyk-krzysztof
Copy link
Copy Markdown
Member Author

@elastic/appex-qa
The CI run for this migrated test suite was green.

However when I ran flaky test runner, something weird happened:

x-pack/platform/plugins/shared/global_search/test/scout/ui/playwright.config.ts (--stateful)

The stateful run passed, but those failed:

Failed modes:
	  --serverless=es ❌
	  --serverless=oblt ❌
	  --serverless=security ❌

The test suites have tag: tags.ESS_ONLY - as the original FTR suite didn't have serverless specific tests. So what do I do here? Is this just flaky test runner behaving weird by trying to run all modes? Should I make it work on all modes as the functionality being tested works the same everywhere? This is my first time migrating FTR to Scout so I'm not sure if I'm doing it correctly.

@kowalczyk-krzysztof kowalczyk-krzysztof marked this pull request as ready for review February 9, 2026 08:56
@kowalczyk-krzysztof kowalczyk-krzysztof requested review from a team as code owners February 9, 2026 08:56
@kowalczyk-krzysztof kowalczyk-krzysztof added the Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// label Feb 9, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Comment on lines -36 to -46
kbnTestServer: {
...xpackFunctionalConfig.get('kbnTestServer'),
serverArgs: [
...xpackFunctionalConfig.get('kbnTestServer.serverArgs'),
`--plugin-path=${resolve(
KIBANA_ROOT,
'src/platform/test/plugin_functional/plugins/core_provider_plugin'
)}`,
...findTestPluginPaths(resolve(__dirname, 'plugins')),
],
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scout server configuration is targeting Cloud testing by default, meaning local servers setup is matching CECH/MKI setup.

Since your tests depend on some custom plugins, it won't work unless you create a custom server configs override (see this PR for instructions #244306)

When you create custom server configuration, you decide where it can be run (e.g. having only stateful one won't allow to run tests against serverless project)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is some legacy thing and src/platform/test/plugin_functional/plugins/core_provider_plugin is not needed as Scout provides everything it did.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack, I'm keeping the classic tests only.

@dmlemeshko
Copy link
Copy Markdown
Contributor

@elastic/appex-qa The CI run for this migrated test suite was green.

However when I ran flaky test runner, something weird happened:

x-pack/platform/plugins/shared/global_search/test/scout/ui/playwright.config.ts (--stateful)

The stateful run passed, but those failed:

Failed modes:
	  --serverless=es ❌
	  --serverless=oblt ❌
	  --serverless=security ❌

The test suites have tag: tags.ESS_ONLY - as the original FTR suite didn't have serverless specific tests. So what do I do here? Is this just flaky test runner behaving weird by trying to run all modes? Should I make it work on all modes as the functionality being tested works the same everywhere? This is my first time migrating FTR to Scout so I'm not sure if I'm doing it correctly.

This is a bug 🐛 Please check my comment about custom server definition, it won't work without it

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #3 / "before all" hook in "{root}"

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack-platform 146 145 -1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack-platform 151 150 -1

History

cc @kowalczyk-krzysztof

Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhavyarm bhavyarm self-requested a review February 10, 2026 09:32
Copy link
Copy Markdown
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Had kept an eye on this. Awesome work!

@kowalczyk-krzysztof kowalczyk-krzysztof enabled auto-merge (squash) February 10, 2026 09:33
@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 8b34cc9 into elastic:main Feb 10, 2026
18 checks passed
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the scout/global-search branch February 10, 2026 15:20
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 10, 2026
* commit '7dcc1fe3c205d2de0c3ca3f65804f21de09013c3': (285 commits)
  Enrich kbn-check-saved-objects-cli README with CI and manual usage docs (elastic#252557)
  [Discover] Add feature flag to make ESQL the default query mode (elastic#252268)
  Add maskProps.headerZindexLocation above to inspect component flyout (elastic#252543)
  [Security Solution][Atack/Alerts] Flyout header: Assignees  (elastic#252190)
  Upgrade EUI to v112.3.0 (elastic#252315)
  [Fleet] Make save_knowledge_base async in streaming state machine (elastic#252328)
  Upgrade @smithy/config-resolver 4.3.0 → 4.4.6 (elastic#252457)
  [Lens as API] Add colorMapping support for XY charts (ES|QL data layers) (elastic#252051)
  [WorkplaceAI] Add Google Drive data source and connector (elastic#250677)
  [Scout] Move GlobalSearch FTR tests to Scout (elastic#252201)
  [EDR Workflows] Fix osquery pack results display when agent clock is skewed (elastic#251417)
  [Observability Onboarding] Apply integrations limit after dedup in parseIntegrationsTSV (elastic#252486)
  [Entity Analytics] Update `host.ip` aggregation to remove painless script (elastic#252426)
  Address `@elastic/eui/require-table-caption` lint violations across `@elastic/obs-presentation-team` files (elastic#251050)
  Consolidate JSON stringify dependencies (elastic#251890)
  [index mgmt] Use esql instead of query dsl to get the index count (elastic#252422)
  Add Usage API Plugin (elastic#252434)
  Cases All Templates page (elastic#250372)
  [Agent Builder] Default value for optional params in ESQL tools (elastic#238472)
  [Fleet] Add upgrade_details.metadata.reason to AgentResponseSchema (elastic#252485)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants