Skip to content

[ES|QL] hides popup for operators in the editor#251465

Merged
momovdg merged 3 commits intoelastic:mainfrom
momovdg:esql-hide-popup-operators
Feb 4, 2026
Merged

[ES|QL] hides popup for operators in the editor#251465
momovdg merged 3 commits intoelastic:mainfrom
momovdg:esql-hide-popup-operators

Conversation

@momovdg
Copy link
Copy Markdown
Contributor

@momovdg momovdg commented Feb 3, 2026

resolves #248391

Summary

This fixe stops the signature popup from appearing when hovering over operators.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@momovdg momovdg changed the title [ES|QL] hides popup for operators int he editor [ES|QL] hides popup for operators in the editor Feb 3, 2026
@momovdg momovdg self-assigned this Feb 3, 2026
@momovdg momovdg added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.4.0 labels Feb 3, 2026
@momovdg momovdg marked this pull request as ready for review February 4, 2026 05:48
@momovdg momovdg requested a review from a team as a code owner February 4, 2026 05:48
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I have some second thoughts. I think it is confusing that we dont allow the hover at the != etc but we allow it for isNULL

Image

Why don't we hide the hover only for the SET = and nothing else? It seems everything else is quite decent. Wdyt?

Comment on lines +97 to +98
const mathOperators = arithmeticOperators.concat(comparisonFunctions).map(({ name }) => name);
const operators = ['='].concat(mathOperators);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could combine them

  const operators = [
    '=',
    ...[...arithmeticOperators, ...comparisonFunctions].map(({ name }) => name),
  ]

@momovdg momovdg requested a review from stratoula February 4, 2026 07:43
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #41 / "before all" hook in "{root}"
  • [job] [logs] FTR Configs #86 / "before all" hook in "{root}"

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 4.5MB 4.5MB +16.0B

cc @momovdg

@momovdg momovdg merged commit 4bdd6aa into elastic:main Feb 4, 2026
16 checks passed
@momovdg momovdg deleted the esql-hide-popup-operators branch February 4, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ES|QL] Don't display hover popup on operators

3 participants