Skip to content

Fix onCascadeGroupNodeCollapsed in the cascade component.#250538

Merged
eokoneyo merged 6 commits intoelastic:mainfrom
eokoneyo:patch/fix-cascade-component-on-group-collapse
Jan 29, 2026
Merged

Fix onCascadeGroupNodeCollapsed in the cascade component.#250538
eokoneyo merged 6 commits intoelastic:mainfrom
eokoneyo:patch/fix-cascade-component-on-group-collapse

Conversation

@eokoneyo
Copy link
Copy Markdown
Contributor

@eokoneyo eokoneyo commented Jan 27, 2026

Summary

  • Change implementation for onGroupCollapse in place of invoking the passed callback on unmount, we invoke the callback only when the row is explicitly not expanded.
  • Also fix console error, with maskImage style getting set as an attribute on the dom elements.

@eokoneyo eokoneyo self-assigned this Jan 27, 2026
@eokoneyo eokoneyo added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Jan 27, 2026
@eokoneyo
Copy link
Copy Markdown
Contributor Author

eokoneyo commented Jan 27, 2026

/ci

@eokoneyo eokoneyo linked an issue Jan 27, 2026 that may be closed by this pull request
[Discover] [Group By] Got "no results" when count is not 0 #250247
Closed
@eokoneyo eokoneyo marked this pull request as ready for review January 27, 2026 11:55
@eokoneyo eokoneyo requested a review from a team as a code owner January 27, 2026 11:55
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 27, 2026

Pinging @elastic/appex-sharedux (Team:SharedUX)

@eokoneyo
Copy link
Copy Markdown
Contributor Author

eokoneyo commented Jan 27, 2026

@elasticmachine merge upstream

@eokoneyo eokoneyo added the (do not use) backport:9.3 This doesn't do backports! use `backport:version` `v9.3.0` instead label Jan 27, 2026
@eokoneyo eokoneyo changed the title Changes to the cascade component. Fix onCascadeGroupNodeCollapsed in the cascade component. Jan 27, 2026
@eokoneyo
Copy link
Copy Markdown
Contributor Author

eokoneyo commented Jan 27, 2026

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 27, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #126 / "before all" hook in "{root}"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.5MB 1.5MB +71.0B

History

cc @eokoneyo

@eokoneyo
Copy link
Copy Markdown
Contributor Author

eokoneyo commented Jan 28, 2026

@elasticmachine merge upstream

@eokoneyo eokoneyo merged commit 0065cdd into elastic:main Jan 29, 2026
16 checks passed
@eokoneyo eokoneyo deleted the patch/fix-cascade-component-on-group-collapse branch January 29, 2026 12:17
@eokoneyo eokoneyo mentioned this pull request Jan 29, 2026
Closed
4 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 30, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 30, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 250538 locally
cc: @eokoneyo

hannahbrooks pushed a commit to hannahbrooks/kibana that referenced this pull request Jan 30, 2026
@eokoneyo @elasticmachine
@kibanamachine @hannahbrooks
Fix onCascadeGroupNodeCollapsed in the cascade component. (elastic#…
5f33d93 
…250538)

## Summary

- Change implementation for `onGroupCollapse` in place of invoking the
passed callback on unmount, we invoke the callback only when the row is
explicitly not expanded.
- Also fix console error, with `maskImage` style getting set as an
attribute on the dom elements.

<!--

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

-->

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 2, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 250538 locally
cc: @eokoneyo

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 3, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 250538 locally
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 5, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

12 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 6, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 9, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 10, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 11, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 12, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 13, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 16, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 17, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 18, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 19, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 20, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 23, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine kibanamachine mentioned this pull request Mar 23, 2026
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 24, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

11 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 25, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 27, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 30, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 31, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 1, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 2, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 4, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 6, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 7, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 8, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

eokoneyo added a commit that referenced this pull request Apr 8, 2026
@eokoneyo @elasticmachine @kibanamachine
[9.3] Fix onCascadeGroupNodeCollapsed in the cascade component. (#2…
737a954 
…50538) (#253016)

# Backport

This will backport the following commits from `main` to `9.3`:
- [Fix `onCascadeGroupNodeCollapsed` in the cascade component.
(#250538)](#250538)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Eyo O.
Eyo","email":"7893459+eokoneyo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-01-29T12:17:12Z","message":"Fix
`onCascadeGroupNodeCollapsed` in the cascade component. (#250538)\n\n##
Summary\n\n- Change implementation for `onGroupCollapse` in place of
invoking the\npassed callback on unmount, we invoke the callback only
when the row is\nexplicitly not expanded.\n- Also fix console error,
with `maskImage` style getting set as an\nattribute on the dom
elements.\n\n\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0065cdd909a869c57163d68a5da5b511198a245c","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","Team:SharedUX","v9.4.0","backport:9.3"],"title":"Fix
`onCascadeGroupNodeCollapsed` in the cascade
component.","number":250538,"url":"https://github.com/elastic/kibana/pull/250538","mergeCommit":{"message":"Fix
`onCascadeGroupNodeCollapsed` in the cascade component. (#250538)\n\n##
Summary\n\n- Change implementation for `onGroupCollapse` in place of
invoking the\npassed callback on unmount, we invoke the callback only
when the row is\nexplicitly not expanded.\n- Also fix console error,
with `maskImage` style getting set as an\nattribute on the dom
elements.\n\n\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0065cdd909a869c57163d68a5da5b511198a245c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/250538","number":250538,"mergeCommit":{"message":"Fix
`onCascadeGroupNodeCollapsed` in the cascade component. (#250538)\n\n##
Summary\n\n- Change implementation for `onGroupCollapse` in place of
invoking the\npassed callback on unmount, we invoke the callback only
when the row is\nexplicitly not expanded.\n- Also fix console error,
with `maskImage` style getting set as an\nattribute on the dom
elements.\n\n\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"0065cdd909a869c57163d68a5da5b511198a245c"}}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added backport:skip This PR does not require backporting v9.3.3 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kowalczyk-krzysztof kowalczyk-krzysztof kowalczyk-krzysztof approved these changes

Assignees

@eokoneyo eokoneyo

Labels

backport:skip This PR does not require backporting (do not use) backport:9.3 This doesn't do backports! use `backport:version` `v9.3.0` instead release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.3.3 v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Discover] [Group By] Got "no results" when count is not 0

4 participants

@eokoneyo @elasticmachine @kibanamachine @kowalczyk-krzysztof