fix issue with cascade not showing on mobile#255838
Conversation
|
/deploy-oblt |
|
/oblt-deploy |
|
@elasticmachine merge upstream |
|
/oblt-deploy |
|
@elasticmachine merge upstream |
c318d1a to
e8ad378
Compare
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
e504d62 to
c178c93
Compare
⏳ Build in-progress, with failures
Failed CI StepsHistory
cc @eokoneyo |
c178c93 to
5e18d04
Compare
5e18d04 to
7926098
Compare
|
general question, what is it that doesn't show on mobile? I'm testing cascade with a small screen before this PR and it's showing for me - other than the "Group by" button content being slightly broken it's looking the same for me |
We had it working previously, but there was a revert, so now If you make the screen small enough on main the cascade experience doesn't render. Fixed the issue with the "Group by" button here 7ef08b4 |
just trying to understand the fix, in main for me it's looking good: cascade.movbtw, maybe not related to this but i've got this for a couple of fields too
|
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
## Summary Fixes issue with cascade experience not displaying on mobile. ### Visuals <img width="606" height="927" alt="Screenshot 2026-03-22 at 21 48 05" src="https://github.com/user-attachments/assets/e1dd4607-c279-4d43-a79c-3d3b569cbad2" /> _Cascade experience on mobile_ P.S. It should be noted that there's an open issue to refine the mobile view for the cascade component itself, see elastic#246968 <!-- ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... -->
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
8 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
@eokoneyo do you want to backport this? |
Yes! I will be backporting this along a whole bunch of other PRs too |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
## Summary Fixes issue with cascade experience not displaying on mobile. ### Visuals <img width="606" height="927" alt="Screenshot 2026-03-22 at 21 48 05" src="https://github.com/user-attachments/assets/e1dd4607-c279-4d43-a79c-3d3b569cbad2" /> _Cascade experience on mobile_ P.S. It should be noted that there's an open issue to refine the mobile view for the cascade component itself, see elastic#246968 <!-- ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --> (cherry picked from commit 772f5f6) # Conflicts: # src/platform/plugins/shared/discover/public/application/main/components/layout/cascaded_documents/blocks/use_table_header_components.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
# Backport This will backport the following commits from `main` to `9.3`: - [fix issue with cascade not showing on mobile (#255838)](#255838) <!--- Backport version: 11.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Eyo O. Eyo","email":"7893459+eokoneyo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-03-23T16:45:48Z","message":"fix issue with cascade not showing on mobile (#255838)\n\n## Summary\n\nFixes issue with cascade experience not displaying on mobile. \n\n### Visuals\n<img width=\"606\" height=\"927\" alt=\"Screenshot 2026-03-22 at 21 48 05\"\nsrc=\"https://github.com/user-attachments/assets/e1dd4607-c279-4d43-a79c-3d3b569cbad2\"\n/>\n\n\n\n_Cascade experience on mobile_\n\nP.S. It should be noted that there's an open issue to refine the mobile\nview for the cascade component itself, see\nhttps://github.com//issues/246968\n\n","sha":"772f5f6a0247900b598f357d84b97ffb1578e796","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","Team:SharedUX","backport:version","v9.4.0","v9.3.3"],"title":"fix issue with cascade not showing on mobile","number":255838,"url":"https://github.com/elastic/kibana/pull/255838","mergeCommit":{"message":"fix issue with cascade not showing on mobile (#255838)\n\n## Summary\n\nFixes issue with cascade experience not displaying on mobile. \n\n### Visuals\n<img width=\"606\" height=\"927\" alt=\"Screenshot 2026-03-22 at 21 48 05\"\nsrc=\"https://github.com/user-attachments/assets/e1dd4607-c279-4d43-a79c-3d3b569cbad2\"\n/>\n\n\n\n_Cascade experience on mobile_\n\nP.S. It should be noted that there's an open issue to refine the mobile\nview for the cascade component itself, see\nhttps://github.com//issues/246968\n\n","sha":"772f5f6a0247900b598f357d84b97ffb1578e796"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/255838","number":255838,"mergeCommit":{"message":"fix issue with cascade not showing on mobile (#255838)\n\n## Summary\n\nFixes issue with cascade experience not displaying on mobile. \n\n### Visuals\n<img width=\"606\" height=\"927\" alt=\"Screenshot 2026-03-22 at 21 48 05\"\nsrc=\"https://github.com/user-attachments/assets/e1dd4607-c279-4d43-a79c-3d3b569cbad2\"\n/>\n\n\n\n_Cascade experience on mobile_\n\nP.S. It should be noted that there's an open issue to refine the mobile\nview for the cascade component itself, see\nhttps://github.com//issues/246968\n\n","sha":"772f5f6a0247900b598f357d84b97ffb1578e796"}},{"branch":"9.3","label":"v9.3.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->

Summary
Fixes issue with cascade experience not displaying on mobile.
Visuals
Cascade experience on mobile
P.S. It should be noted that there's an open issue to refine the mobile view for the cascade component itself, see #246968