[9.2] [Security Solution] Installation review pagination: Frontend (#248259)#250009
Merged
nikitaindik merged 3 commits intoelastic:9.2from Jan 23, 2026
Merged
[9.2] [Security Solution] Installation review pagination: Frontend (#248259)#250009nikitaindik merged 3 commits intoelastic:9.2from
nikitaindik merged 3 commits intoelastic:9.2from
Conversation
…#248259) **Partially addresses: elastic#241656 **Backend PR: elastic#247375 >⚠️ Note: This PR should be merged only when the [backend PR](elastic#247375) is merged and released in Serverless (after Monday 19-Jan-2026). ## Summary This PR builds on top of the [backend PR](elastic#247375) and adds frontend changes for the installation review pagination. ## Changes - If `page` parameter is not passed, it's defaulted to 1. If `per_page` parameter is not passed it's defaulted to 20. - UI code now sends `page` and `per_page` parameters. - Client-side sorting and filtering was removed. It now happens on the backend. - Added Cypress tests to match the test plan. - Refactored `reviewRuleInstallationHandler` to make it more readable, as suggested in the feedback for the backend PR. (cherry picked from commit 2a85280) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table_context.tsx # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/review_rule_installation/review_rule_installation_route.ts # x-pack/solutions/security/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/install_prebuilt_rules/review_installation.ts
This was referenced Jan 22, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
|
maximpn
approved these changes
Jan 23, 2026
Contributor
maximpn
left a comment
maximpn
left a comment
There was a problem hiding this comment.
@nikitaindik Thanks for encompassing my suggestions to the backport 🙏
The diff is pretty close to the original PR. Testing has shown it works in the expected way.
| refetchInterval: 60000, // Refetch available rules for installation every minute | ||
| keepPreviousData: true, // Use this option so that the state doesn't jump between "success" and "loading" on page change | ||
| // Fetch rules to install only after background installation of security_detection_rules package is complete | ||
| enabled: isUpgradeReviewRequestEnabled({ |
Contributor
There was a problem hiding this comment.
Ideally we could have a single hook for that purpose named something like usePrebuiltRulesAvailable. It could encapsulate the dependent hooks and return the clear result. isUpgradeReviewRequestEnabled was originally related to the prebuilt rules upgrade review API endpoint.
Let's note it for the future.
| } | ||
| ); | ||
|
|
||
| const rules = useMemo(() => reviewResponse?.rules ?? [], [reviewResponse]); |
Contributor
There was a problem hiding this comment.
It does't look like useMemo is required here.
| const rulesMatchingFilterCount = reviewResponse?.total ?? 0; | ||
| const installableRulesCount = reviewResponse?.stats.num_rules_to_install ?? 0; | ||
|
|
||
| const tags = useMemo(() => reviewResponse?.stats?.tags ?? [], [reviewResponse]); |
Contributor
There was a problem hiding this comment.
It does't look like useMemo is required here.
...rebuilt_rules/logic/rule_assets/prebuilt_rule_assets_client/methods/fetch_latest_versions.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
run docs-build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation