[Security Solution] Installation review pagination: Frontend#248259
Merged
nikitaindik merged 6 commits intoelastic:mainfrom Jan 21, 2026
Merged
[Security Solution] Installation review pagination: Frontend#248259nikitaindik merged 6 commits intoelastic:mainfrom
nikitaindik merged 6 commits intoelastic:mainfrom
Conversation
35 tasks
nikitaindik
force-pushed
the
installation-review-pagination-frontend
branch
from
f2b5f4c to
bcb7e17
Compare
nikitaindik
added
bug
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
nikitaindik
changed the title
nikitaindik
force-pushed
the
installation-review-pagination-frontend
branch
from
76c160c to
16420c1
Compare
gsoldevila
approved these changes
Jan 14, 2026
Member
gsoldevila
left a comment
gsoldevila
left a comment
There was a problem hiding this comment.
Core changes pair-reviewed with the author and agreed upon ✅
nikitaindik
force-pushed
the
installation-review-pagination-frontend
branch
2 times, most recently
from
2c0bc89 to
ee9ef24
Compare
nikitaindik
force-pushed
the
installation-review-pagination-frontend
branch
from
b7d87b8 to
277d7a4
Compare
Contributor
|
Starting backport for target branches: 9.3 https://github.com/elastic/kibana/actions/runs/21217289006 |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @nikitaindik |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 21, 2026
…#248259) **Partially addresses: elastic#241656 **Backend PR: elastic#247375 >⚠️ Note: This PR should be merged only when the [backend PR](elastic#247375) is merged and released in Serverless (after Monday 19-Jan-2026). ## Summary This PR builds on top of the [backend PR](elastic#247375) and adds frontend changes for the installation review pagination. ## Changes - If `page` parameter is not passed, it's defaulted to 1. If `per_page` parameter is not passed it's defaulted to 20. - UI code now sends `page` and `per_page` parameters. - Client-side sorting and filtering was removed. It now happens on the backend. - Added Cypress tests to match the test plan. - Refactored `reviewRuleInstallationHandler` to make it more readable, as suggested in the feedback for the backend PR. (cherry picked from commit 2a85280)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Merged
10 tasks
kibanamachine
added a commit
that referenced
this pull request
Jan 21, 2026
…248259) (#249913) # Backport This will backport the following commits from `main` to `9.3`: - [[Security Solution] Installation review pagination: Frontend (#248259)](#248259) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2026-01-21T16:24:33Z","message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","performance","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","ci:build-cloud-image","backport:version","v9.3.0","v9.4.0"],"title":"[Security Solution] Installation review pagination: Frontend","number":248259,"url":"https://github.com/elastic/kibana/pull/248259","mergeCommit":{"message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248259","number":248259,"mergeCommit":{"message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360"}}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
nikitaindik
added a commit
to nikitaindik/kibana
that referenced
this pull request
Jan 22, 2026
…#248259) **Partially addresses: elastic#241656 **Backend PR: elastic#247375 >⚠️ Note: This PR should be merged only when the [backend PR](elastic#247375) is merged and released in Serverless (after Monday 19-Jan-2026). ## Summary This PR builds on top of the [backend PR](elastic#247375) and adds frontend changes for the installation review pagination. ## Changes - If `page` parameter is not passed, it's defaulted to 1. If `per_page` parameter is not passed it's defaulted to 20. - UI code now sends `page` and `per_page` parameters. - Client-side sorting and filtering was removed. It now happens on the backend. - Added Cypress tests to match the test plan. - Refactored `reviewRuleInstallationHandler` to make it more readable, as suggested in the feedback for the backend PR. (cherry picked from commit 2a85280) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table_context.tsx # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/review_rule_installation/review_rule_installation_route.ts # x-pack/solutions/security/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/install_prebuilt_rules/review_installation.ts
nikitaindik
added a commit
to nikitaindik/kibana
that referenced
this pull request
Jan 22, 2026
…#248259) **Partially addresses: elastic#241656 **Backend PR: elastic#247375 >⚠️ Note: This PR should be merged only when the [backend PR](elastic#247375) is merged and released in Serverless (after Monday 19-Jan-2026). ## Summary This PR builds on top of the [backend PR](elastic#247375) and adds frontend changes for the installation review pagination. ## Changes - If `page` parameter is not passed, it's defaulted to 1. If `per_page` parameter is not passed it's defaulted to 20. - UI code now sends `page` and `per_page` parameters. - Client-side sorting and filtering was removed. It now happens on the backend. - Added Cypress tests to match the test plan. - Refactored `reviewRuleInstallationHandler` to make it more readable, as suggested in the feedback for the backend PR. (cherry picked from commit 2a85280) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table_context.tsx # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/review_rule_installation/review_rule_installation_route.ts # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/constants.ts # x-pack/solutions/security/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/install_prebuilt_rules/review_installation.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jan 22, 2026
…#248259) **Partially addresses: elastic#241656 **Backend PR: elastic#247375 >⚠️ Note: This PR should be merged only when the [backend PR](elastic#247375) is merged and released in Serverless (after Monday 19-Jan-2026). ## Summary This PR builds on top of the [backend PR](elastic#247375) and adds frontend changes for the installation review pagination. ## Changes - If `page` parameter is not passed, it's defaulted to 1. If `per_page` parameter is not passed it's defaulted to 20. - UI code now sends `page` and `per_page` parameters. - Client-side sorting and filtering was removed. It now happens on the backend. - Added Cypress tests to match the test plan. - Refactored `reviewRuleInstallationHandler` to make it more readable, as suggested in the feedback for the backend PR.
dennis-tismenko
pushed a commit
to dennis-tismenko/kibana
that referenced
this pull request
Jan 22, 2026
…#248259) **Partially addresses: elastic#241656 **Backend PR: elastic#247375 >⚠️ Note: This PR should be merged only when the [backend PR](elastic#247375) is merged and released in Serverless (after Monday 19-Jan-2026). ## Summary This PR builds on top of the [backend PR](elastic#247375) and adds frontend changes for the installation review pagination. ## Changes - If `page` parameter is not passed, it's defaulted to 1. If `per_page` parameter is not passed it's defaulted to 20. - UI code now sends `page` and `per_page` parameters. - Client-side sorting and filtering was removed. It now happens on the backend. - Added Cypress tests to match the test plan. - Refactored `reviewRuleInstallationHandler` to make it more readable, as suggested in the feedback for the backend PR.
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
nikitaindik
added a commit
that referenced
this pull request
Jan 23, 2026
…248259) (#250009) # Backport This will backport the following commits from `main` to `9.2`: - [[Security Solution] Installation review pagination: Frontend (#248259)](#248259) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2026-01-21T16:24:33Z","message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","performance","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","ci:build-cloud-image","backport:version","v9.3.0","v9.4.0","v9.2.5","v8.19.11"],"title":"[Security Solution] Installation review pagination: Frontend","number":248259,"url":"https://github.com/elastic/kibana/pull/248259","mergeCommit":{"message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/249913","number":249913,"state":"MERGED","mergeCommit":{"sha":"b6297bbc54e274ced69eb9b28f63271c74808daa","message":"[9.3] [Security Solution] Installation review pagination: Frontend (#248259) (#249913)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.3`:\n- [[Security Solution] Installation review pagination: Frontend\n(#248259)](https://github.com/elastic/kibana/pull/248259)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>"}},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248259","number":248259,"mergeCommit":{"message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360"}},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.11","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
nikitaindik
added a commit
that referenced
this pull request
Jan 23, 2026
…248259) (#250011) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Installation review pagination: Frontend (#248259)](#248259) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2026-01-21T16:24:33Z","message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","performance","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","ci:build-cloud-image","backport:version","v9.3.0","v9.4.0","v9.2.5","v8.19.11"],"title":"[Security Solution] Installation review pagination: Frontend","number":248259,"url":"https://github.com/elastic/kibana/pull/248259","mergeCommit":{"message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/249913","number":249913,"state":"MERGED","mergeCommit":{"sha":"b6297bbc54e274ced69eb9b28f63271c74808daa","message":"[9.3] [Security Solution] Installation review pagination: Frontend (#248259) (#249913)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.3`:\n- [[Security Solution] Installation review pagination: Frontend\n(#248259)](https://github.com/elastic/kibana/pull/248259)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>"}},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248259","number":248259,"mergeCommit":{"message":"[Security Solution] Installation review pagination: Frontend (#248259)\n\n**Partially addresses: https://github.com/elastic/kibana/issues/241656**\n**Backend PR: https://github.com/elastic/kibana/pull/247375**\n\n>⚠️ Note: This PR should be merged only when the [backend\nPR](#247375) is merged and\nreleased in Serverless (after Monday 19-Jan-2026).\n\n## Summary\nThis PR builds on top of the [backend\nPR](#247375) and adds frontend\nchanges for the installation review pagination.\n\n## Changes\n- If `page` parameter is not passed, it's defaulted to 1. If `per_page`\nparameter is not passed it's defaulted to 20.\n- UI code now sends `page` and `per_page` parameters.\n- Client-side sorting and filtering was removed. It now happens on the\nbackend.\n- Added Cypress tests to match the test plan.\n- Refactored `reviewRuleInstallationHandler` to make it more readable,\nas suggested in the feedback for the backend PR.","sha":"2a8528027e41a5e0f17e9e401d0926f516419360"}},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.11","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #241656
Backend PR: #247375
Summary
This PR builds on top of the backend PR and adds frontend changes for the installation review pagination.
Changes
pageparameter is not passed, it's defaulted to 1. Ifper_pageparameter is not passed it's defaulted to 20.pageandper_pageparameters.reviewRuleInstallationHandlerto make it more readable, as suggested in the feedback for the backend PR.