[Alerting][Custom Threshold Rule] Update custom_threshold_rule schema and test snapshot#249998
Merged
miguelmartin-elastic merged 1 commit intoelastic:mainfrom Jan 23, 2026
Conversation
Contributor
Author
|
/ci |
github-actions
Bot
added
the
author:actionable-obs
Contributor
|
@miguelmartin-elastic, it looks like you're updating the parameters for a rule type! Please review the guidelines for making additive changes to rule type parameters and determine if your changes require an intermediate release. |
Contributor
💚 Build Succeeded
Metrics [docs]
|
miguelmartin-elastic
added
release_note:skip
pmuellr
approved these changes
Jan 23, 2026
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
LGTM. Hopefully this will be applied to serverless on Monday / Tuesday, so you can then commit changes which set the new field. In any case, this PR's code needs to be running in Serverless the release BEFORE the one that sets the new field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for an intermediate release for #248845 .
metricsitems : schema changed fromnevertooptional stringTest
I tested it manually and verified that Custom Threshold Rules with the new schema in place are executed without issues in current Kibana version in
main