[Alerting] Allow KQL filtering for all types of aggregations when creating a Custom Threshold Rule#248845
Conversation
|
/ci |
|
Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/648 |
|
/ci |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10469[❌] x-pack/solutions/observability/test/observability_functional/with_rac_write.config.ts: 0/10 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10478[❌] x-pack/solutions/observability/test/observability_functional/with_rac_write.config.ts: 0/10 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10481[❌] x-pack/solutions/observability/test/observability_functional/with_rac_write.config.ts: 0/10 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10482[❌] x-pack/solutions/observability/test/observability_functional/with_rac_write.config.ts: 0/10 tests passed. |
|
/ci |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10483[✅] x-pack/solutions/observability/test/observability_functional/with_rac_write.config.ts: 10/10 tests passed. |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
benakansara
left a comment
There was a problem hiding this comment.
@miguelmartin-elastic when I try to save rule, I get the following error:
… and test snapshot (#249998) ## Summary This PR is for an intermediate release for #248845 . * Update the Custom Threshold Rule schema to accept an optional KQL string filter as part of the `metrics` items : schema changed from `never` to `optional string` ## Test I tested it manually and verified that Custom Threshold Rules with the new schema in place are executed without issues in current Kibana version in `main`
|
hey @pmuellr , the intermediate release for this PR was already deployed to serverless in 6f03fc5236af. Are we good to go from your side? |
Looks like that was merged late-ish on Friday. We should double-check it made it into this week's build - I'll have to figure out how :-) |
|
Ya, it did make it into this week's build (git commit is now written in all kinds of messages \o/ ), you should be good to go! |
|
filter info added to the title and tooltip @benakansara ✅ |
pmuellr
left a comment
There was a problem hiding this comment.
ResponseOps changes to move to an intermediate release for this PR LGTM.
|
Pinging @elastic/actionable-obs-team (Team:actionable-obs) |
⏳ Build in-progress
Failed CI StepsTest Failures
History
|

Release Notes
Support KQL filtering in all types of aggregations in Custom Threshold Rules
Summary
closes #231158
Allow KQL filter to all types of aggregations when creating a Custom Threshold Rule
Alert details page
Filter info added to chart title and tooltip:

Testing
Countaggregation type is selected, only one input is shown: KQL Filter A, and that it works correctly.