Skip to content

Address @elastic/eui/require-table-caption lint violations across @elastic/security-threat-hunting files #249680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexwizp merged 2 commits into from
Jan 21, 2026
Merged

Address @elastic/eui/require-table-caption lint violations across @elastic/security-threat-hunting files #249680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33f62ae
Address `@elastic/eui/require-table-caption` lint violations across `…
alexwizp Jan 20, 2026
2e107ea
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ export const MigrationDashboardsTable: React.FC<MigrationDashboardsTableProps> =
</EuiFlexGroup>
<EuiSpacer size="m" />
<EuiBasicTable<DashboardMigrationDashboard>
tableCaption={i18n.DASHBOARDS_MIGRATION_TABLE_CAPTION}
loading={false}
items={migrationDashboards}
pagination={pagination}
Expand Down
7 changes: 7 additions & 0 deletions ...ity_solution/public/siem_migrations/dashboards/components/dashboard_table/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,10 @@ export const NOT_TRANSLATED_DASHBOARD_TOOLTIP = i18n.translate(
defaultMessage: 'Not translated migration dashboard',
}
);

export const DASHBOARDS_MIGRATION_TABLE_CAPTION = i18n.translate(
'xpack.securitySolution.siemMigrations.dashboards.table.caption',
{
defaultMessage: 'Dashboards migration status',
}
);
1 change: 1 addition & 0 deletions .../siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ const TranslationResultsTable = React.memo<{
items={items}
columns={columns}
compressed
tableCaption={i18n.DASHBOARD_MIGRATION_SUMMARY_TITLE}
/>
);
});
Expand Down
1 change: 1 addition & 0 deletions ...ublic/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ const TranslationResultsTable = React.memo<{
data-test-subj="translatedResultsTable"
items={items}
columns={columns}
tableCaption={i18n.RULE_MIGRATION_SUMMARY_TITLE}
compressed
/>
);
Expand Down
1 change: 1 addition & 0 deletions ...y/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ export const MigrationRulesTable: React.FC<MigrationRulesTableProps> = React.mem
itemId={'id'}
data-test-subj={'rules-translation-table'}
columns={rulesColumns}
tableCaption={i18n.RULES_MIGRATION_TABLE_CAPTION}
/>
</>
)
Expand Down
7 changes: 7 additions & 0 deletions ...ins/security_solution/public/siem_migrations/rules/components/rules_table/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@

import { i18n } from '@kbn/i18n';

export const RULES_MIGRATION_TABLE_CAPTION = i18n.translate(
'xpack.securitySolution.siemMigrations.rules.table.caption',
{
defaultMessage: 'Rules migration status',
}
);

export const ALREADY_TRANSLATED_RULE_TOOLTIP = i18n.translate(
'xpack.securitySolution.siemMigrations.rules.table.alreadyTranslatedTooltip',
{
Expand Down