Skip to content

Change "Select color" option label back to just "Color" #248681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florent-leborgne merged 3 commits into from
Jan 13, 2026
Merged

Change "Select color" option label back to just "Color" #248681

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a80194
Change Select color option label back to just Color
florent-leborgne Jan 12, 2026
42bfc0e
Update x-pack/platform/plugins/shared/lens/public/visualizations/metr…
florent-leborgne Jan 12, 2026
8fd3de9
Merge branch 'main' into lens-rever-select-color-label
florent-leborgne Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/platform/plugins/shared/lens/public/visualizations/metric/dimension_editor.tsx
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@mariairiartef mariairiartef Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question related to the release notes.

We have made several changes to the Primary Metric editor across multiple PRs:

The most recent PRs modify things that were already changed in previous PRs.

In cases like this, is it ok to provide a single release note that summarizes the final state?

Copy link
Copy Markdown
Member Author

@florent-leborgne florent-leborgne Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can do that in two ways:

  • For 9.3 or earlier: Manually by editing the release notes PR, such as this one that will be reviewable later this week after we do a first pass of cleanup: [Docs] Kibana release notes for 9.3.0 #248511
  • For the future: you can mark PRs as release_note:skip and write up a small ## Release Note section in the most significant one that describes the final state.

Original file line number Diff line number Diff line change
Expand Up @@ -768,8 +768,8 @@ function StaticColorControl({
setColor: (color: string) => void;
swatches?: string[];
}) {
const colorLabel = i18n.translate('xpack.lens.metric.selectColor.label', {
defaultMessage: 'Select color',
const colorLabel = i18n.translate('xpack.lens.metric.colorLabel', {
defaultMessage: 'Color',
});

const { inputValue: currentColor, handleInputChange: handleColorChange } =
Expand Down