Change "Select color" option label back to just "Color"#248681
Merged
florent-leborgne merged 3 commits intoelastic:mainfrom Jan 13, 2026
Merged
Change "Select color" option label back to just "Color"#248681florent-leborgne merged 3 commits intoelastic:mainfrom
florent-leborgne merged 3 commits intoelastic:mainfrom
Conversation
florent-leborgne
added
Team:Visualizations
Contributor
|
Pinging @elastic/experience-docs (Team:Docs) |
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
x-pack/platform/plugins/shared/lens/public/visualizations/metric/dimension_editor.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
I have a question related to the release notes.
We have made several changes to the Primary Metric editor across multiple PRs:
- [Lens] [Metric] Improve "Supporting visualization" section #243608
- [Lens] [Metric] Improve Primary Metric editor by removing "Supporting visualization" title #245979
- Change "Select color" option label back to just "Color" #248681
The most recent PRs modify things that were already changed in previous PRs.
In cases like this, is it ok to provide a single release note that summarizes the final state?
Contributor
Author
There was a problem hiding this comment.
Yes, we can do that in two ways:
- For 9.3 or earlier: Manually by editing the release notes PR, such as this one that will be reviewable later this week after we do a first pass of cleanup: [Docs] Kibana release notes for 9.3.0 #248511
- For the future: you can mark PRs as
release_note:skipand write up a small ## Release Note section in the most significant one that describes the final state.
…ic/dimension_editor.tsx Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>
20 tasks
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 9.3 https://github.com/elastic/kibana/actions/runs/20954765561 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 13, 2026
Suggesting to change the name of the "Select color" option back to just Color as it was before to keep option labels aligned. This one was the only one using imperative mood, which is odd, and just Color is perfectly clear IMO. "Apply color to" is also using a verb but with regular present tense, not imperative mood, which sounds fine to me. <img width="347" height="352" alt="image" src="https://github.com/user-attachments/assets/d997cd88-dd17-48d1-8368-fcbab808c95c" /> --------- Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com> (cherry picked from commit 722c1ed)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 13, 2026
… (#248820) # Backport This will backport the following commits from `main` to `9.3`: - [Change "Select color" option label back to just "Color" (#248681)](#248681) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"florent-leborgne","email":"florent.leborgne@elastic.co"},"sourceCommit":{"committedDate":"2026-01-13T11:17:33Z","message":"Change \"Select color\" option label back to just \"Color\" (#248681)\n\nSuggesting to change the name of the \"Select color\" option back to just\nColor as it was before to keep option labels aligned.\n\nThis one was the only one using imperative mood, which is odd, and just\nColor is perfectly clear IMO.\n\"Apply color to\" is also using a verb but with regular present tense,\nnot imperative mood, which sounds fine to me.\n\n<img width=\"347\" height=\"352\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d997cd88-dd17-48d1-8368-fcbab808c95c\"\n/>\n\n---------\n\nCo-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>","sha":"722c1edadc107e877ee979d86289db676d010551","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Visualizations","release_note:skip","docs","backport:version","v9.3.0","v9.4.0"],"title":"Change \"Select color\" option label back to just \"Color\"","number":248681,"url":"https://github.com/elastic/kibana/pull/248681","mergeCommit":{"message":"Change \"Select color\" option label back to just \"Color\" (#248681)\n\nSuggesting to change the name of the \"Select color\" option back to just\nColor as it was before to keep option labels aligned.\n\nThis one was the only one using imperative mood, which is odd, and just\nColor is perfectly clear IMO.\n\"Apply color to\" is also using a verb but with regular present tense,\nnot imperative mood, which sounds fine to me.\n\n<img width=\"347\" height=\"352\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d997cd88-dd17-48d1-8368-fcbab808c95c\"\n/>\n\n---------\n\nCo-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>","sha":"722c1edadc107e877ee979d86289db676d010551"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248681","number":248681,"mergeCommit":{"message":"Change \"Select color\" option label back to just \"Color\" (#248681)\n\nSuggesting to change the name of the \"Select color\" option back to just\nColor as it was before to keep option labels aligned.\n\nThis one was the only one using imperative mood, which is odd, and just\nColor is perfectly clear IMO.\n\"Apply color to\" is also using a verb but with regular present tense,\nnot imperative mood, which sounds fine to me.\n\n<img width=\"347\" height=\"352\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d997cd88-dd17-48d1-8368-fcbab808c95c\"\n/>\n\n---------\n\nCo-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>","sha":"722c1edadc107e877ee979d86289db676d010551"}}]}] BACKPORT--> Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>
smith
pushed a commit
to smith/kibana
that referenced
this pull request
Jan 16, 2026
Suggesting to change the name of the "Select color" option back to just Color as it was before to keep option labels aligned. This one was the only one using imperative mood, which is odd, and just Color is perfectly clear IMO. "Apply color to" is also using a verb but with regular present tense, not imperative mood, which sounds fine to me. <img width="347" height="352" alt="image" src="https://github.com/user-attachments/assets/d997cd88-dd17-48d1-8368-fcbab808c95c" /> --------- Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggesting to change the name of the "Select color" option back to just Color as it was before to keep option labels aligned.
This one was the only one using imperative mood, which is odd, and just Color is perfectly clear IMO.
"Apply color to" is also using a verb but with regular present tense, not imperative mood, which sounds fine to me.