[Security Solution][Attacks/Alerts][Attacks page][Table section] Hide tabs for generic attack groups#248444
Merged
e40pud merged 1 commit intoelastic:mainfrom Jan 9, 2026
Conversation
… tabs for generic attack groups
e40pud
added
release_note:fix
backport:skip
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
PhilippeOberti
approved these changes
Jan 9, 2026
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
Desk tested and code LGTM!
devamanv
pushed a commit
to devamanv/kibana
that referenced
this pull request
Jan 12, 2026
… tabs for generic attack groups (elastic#248444) ## Summary This change updates the UI to avoid showing tabs for the generic `-` attack groups (where no specific attack is identified). Instead, only the alerts table is displayed directly. As a consequence of this change, the `AttackDetailsContainer` component has been refactored to require the `attack` prop. Previously, the component handled logic for when `attack` was `undefined` (showing only the Alerts tab). This responsibility has been shifted to the parent component, which now renders `AlertsTab` directly when no attack is present, and conditionally renders `AttackDetailsContainer` only when a valid attack is available. ## Feature Flag > [!NOTE] > The feature is hidden behind the feature flag (in `kibana.dev.yml`): ``` feature_flags.overrides: securitySolution.attacksAlertsAlignment: true ```
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Jan 12, 2026
* commit 'c4304e27736c62f17af20d145770b2ae9d3fae30': (418 commits) skip failing suite (elastic#89079) [ES|QL] Update grammars (elastic#248600) skip failing test suite (elastic#248579) [ES|QL] Update function metadata (elastic#248601) skip failing test suite (elastic#248554) Fix flaky test runner serverless flag for Search solution (elastic#248559) [Security Solution][Attacks/Alerts][Attacks page][Table section] Remember last selected attack details tab (Summary or Alerts) (elastic#247519) (elastic#247988) Fix ES health check poller (elastic#248496) Fix collector schema ownership (elastic#241292) [api-docs] 2026-01-10 Daily api_docs build (elastic#248574) Update dependency cssstyle to v5.3.5 (main) (elastic#237637) Update dependency @octokit/rest to v22.0.1 (main) (elastic#243102) skip failing test suite (elastic#248504) skip failing test suite (elastic#247685) Remove broken ecommerce_dashboard journeys (elastic#248162) [Obs AI] Hide AI Insight component when there are no connectors (elastic#248542) skip failing suite (elastic#248433) [Security Solution][Attacks/Alerts][Attacks page][Table section] Hide tabs for generic attack groups (elastic#248444) [Agent Builder] [AI Infra] Adds product documentation tool and task evals (elastic#248370) [Controls Anywhere] Keep controls focused when creating + editing other panels (elastic#248021) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the UI to avoid showing tabs for the generic
-attack groups (where no specific attack is identified). Instead, only the alerts table is displayed directly.As a consequence of this change, the
AttackDetailsContainercomponent has been refactored to require theattackprop. Previously, the component handled logic for whenattackwasundefined(showing only the Alerts tab). This responsibility has been shifted to the parent component, which now rendersAlertsTabdirectly when no attack is present, and conditionally rendersAttackDetailsContaineronly when a valid attack is available.Feature Flag
Note
The feature is hidden behind the feature flag (in
kibana.dev.yml):