[Controls Anywhere] Keep controls focused when creating + editing other panels#248021
Merged
Zacqary merged 15 commits intoelastic:mainfrom Jan 9, 2026
Merged
[Controls Anywhere] Keep controls focused when creating + editing other panels#248021Zacqary merged 15 commits intoelastic:mainfrom
Zacqary merged 15 commits intoelastic:mainfrom
Conversation
Zacqary
added
Feature:Dashboard
Zacqary
commented
Jan 8, 2026
...atform/packages/shared/presentation/presentation_containers/interfaces/panel_capabilities.ts
Outdated
Show resolved
Hide resolved
Zacqary
commented
Jan 8, 2026
...atform/packages/shared/presentation/presentation_containers/interfaces/panel_capabilities.ts
Outdated
Show resolved
Hide resolved
This reverts commit 91e9899. # Conflicts: # src/platform/plugins/shared/controls/public/controls/data_controls/data_control_manager.ts # src/platform/plugins/shared/controls/public/controls/esql_control/esql_control_manager.ts # src/platform/plugins/shared/dashboard/public/dashboard_api/related_panels_manager.ts
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Zacqary
removed
the
impact:high
Zacqary
added
the
impact:medium
ThomThomson
approved these changes
Jan 9, 2026
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Nice well tested and commented new API for Dashboards, which follows all of our standards!
My only hesitation is how much it pushes the logic for determining when panels are related via ESQL variables onto the Dashboard instead of keeping it at the Lens level.
That said, I see why you've done it this way. The Dashboard is the best place for this logic for controls, so keeping the ESQL logic here too centralizes it nicely. Additionally, the relationship to ESQL is nicely encapsulated by the apiPublishesESQLQuery call and the getESQLQueryVariables call.
Overall no blockers in the code, and everything worked correctly when testing locally, I like that you can drag the controls around while editing a panel, and that if you drag them into a section that doesn't apply them immediately become unfocused. Nice attention to detail! LGTM
| const blurPanel = | ||
| focusedPanelId !== undefined && | ||
| focusedPanelId !== id && | ||
| !arePanelsRelated(id, focusedPanelId); |
Contributor
There was a problem hiding this comment.
Nice clean usage of the new API
Heenawter
approved these changes
Jan 9, 2026
Contributor
Heenawter
left a comment
Heenawter
left a comment
There was a problem hiding this comment.
I left a couple code nits but Kibana is being annoying so I can't test it before I take off for the day. Trusting Devon's testing of the behaviour + the code LGTM 🎉
src/platform/plugins/shared/dashboard/public/dashboard_api/related_panels_manager.ts
Show resolved
Hide resolved
src/platform/plugins/shared/dashboard/public/dashboard_api/related_panels_manager.ts
Outdated
Show resolved
Hide resolved
…ated_panels_manager.ts Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
kibanamachine
added
backport:skip
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
History
|
devamanv
pushed a commit
to devamanv/kibana
that referenced
this pull request
Jan 12, 2026
…er panels (elastic#248021) ## Summary Closes elastic#236021 (Second pass at this issue after elastic#241023 was closed, previous discussions may contain some helpful context.) Focuses filter controls that apply to the same section as the focused panel: https://github.com/user-attachments/assets/2eedfd2f-ef73-4afb-88e9-839cd32e8ad9 Also focuses ES|QL controls which affect the currently focused ES|QL panel, including controls that have just been created: https://github.com/user-attachments/assets/09d68f3d-cd03-4d91-82e6-ef6b95a69d48 I opted NOT to check whether ES|QL panels and ES|QL controls were in the same section, because it shouldn't be possible to use an ES|QL variable that's unavailable in a certain panel's section. It is currently possible to do this, but once elastic#248198 is fixed we shouldn't need any special section checking logic for ES|QL. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Jan 12, 2026
* commit 'c4304e27736c62f17af20d145770b2ae9d3fae30': (418 commits) skip failing suite (elastic#89079) [ES|QL] Update grammars (elastic#248600) skip failing test suite (elastic#248579) [ES|QL] Update function metadata (elastic#248601) skip failing test suite (elastic#248554) Fix flaky test runner serverless flag for Search solution (elastic#248559) [Security Solution][Attacks/Alerts][Attacks page][Table section] Remember last selected attack details tab (Summary or Alerts) (elastic#247519) (elastic#247988) Fix ES health check poller (elastic#248496) Fix collector schema ownership (elastic#241292) [api-docs] 2026-01-10 Daily api_docs build (elastic#248574) Update dependency cssstyle to v5.3.5 (main) (elastic#237637) Update dependency @octokit/rest to v22.0.1 (main) (elastic#243102) skip failing test suite (elastic#248504) skip failing test suite (elastic#247685) Remove broken ecommerce_dashboard journeys (elastic#248162) [Obs AI] Hide AI Insight component when there are no connectors (elastic#248542) skip failing suite (elastic#248433) [Security Solution][Attacks/Alerts][Attacks page][Table section] Hide tabs for generic attack groups (elastic#248444) [Agent Builder] [AI Infra] Adds product documentation tool and task evals (elastic#248370) [Controls Anywhere] Keep controls focused when creating + editing other panels (elastic#248021) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #236021 (Second pass at this issue after #241023 was closed, previous discussions may contain some helpful context.)
Focuses filter controls that apply to the same section as the focused panel:
Screen.Recording.2026-01-08.at.4.28.57.PM.mov
Also focuses ES|QL controls which affect the currently focused ES|QL panel, including controls that have just been created:
Screen.Recording.2026-01-08.at.4.31.53.PM.mov
I opted NOT to check whether ES|QL panels and ES|QL controls were in the same section, because it shouldn't be possible to use an ES|QL variable that's unavailable in a certain panel's section. It is currently possible to do this, but once #248198 is fixed we shouldn't need any special section checking logic for ES|QL.
Checklist