[Security Solution] fix cell action popover closing before we can click on its content #245162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck on its content (after this recent EUI PR elastic#244032 changed the default offset to 4)
PhilippeOberti
added
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
10 tasks
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
…ck on its content (elastic#245162) ## Summary This PR fixes a UI issue with the `kbn-cell-actions` rendering in hover mode. A recent [EUI PR](elastic#244032) made a change to the default `offset` value: ### Context ``` - Updated EuiPopover default prop values of hasArrow, position and offset: (elastic/eui#9218) - Changed hasArrow to false - Changed position to downLeft - Changed offset to 4 when hasArrow=false ``` This offset change ended up making our cell actions almost unusable, as the gap that is now present between the hovered content and the content of the `EuiPopover` is not 4 pixels (instead of previously 0). This means that when leaving the hovered content and before reaching the `EuiPopover` content, the popover is actually being removed... Before the EUI `109.2.0` commit https://github.com/user-attachments/assets/4ff1e2ef-38cc-486e-a236-1df400b2a5d0 Right at the EUI `109.2.0` commit https://github.com/user-attachments/assets/e4af2ca6-36fc-48e9-aee7-c8a9fc00ede3 ### Solution Add `offset={0}` to the `EuiPopover` in the `kbn-cell-actions` package. That way we do not have to change the UI and the correct behavior is restored. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a UI issue with the
kbn-cell-actionsrendering in hover mode. A recent EUI PR made a change to the defaultoffsetvalue:Context
This offset change ended up making our cell actions almost unusable, as the gap that is now present between the hovered content and the content of the
EuiPopoveris not 4 pixels (instead of previously 0). This means that when leaving the hovered content and before reaching theEuiPopovercontent, the popover is actually being removed...Before the EUI
109.2.0commitScreen.Recording.2025-12-03.at.1.42.54.PM.mov
Right at the EUI
109.2.0commitScreen.Recording.2025-12-03.at.1.37.26.PM.mov
Solution
Add
offset={0}to theEuiPopoverin thekbn-cell-actionspackage. That way we do not have to change the UI and the correct behavior is restored.Checklist
release_note:*label is applied per the guidelinesbackport:*labels.