Skip to content

Conversation

@weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Nov 24, 2025

  • @elastic/eui: v109.1.0v109.2.0
  • @elastic/eui-theme-borealis: v5.0.0v5.1.0

Questions? Please see our Kibana upgrade FAQ.


Changes

  • Only snapshot updates related to EuiPopover, ToolTip and Table changes (see below)

Package updates

@elastic/eui v109.2.0

  • Updated EuiFlexItem to fall back to grow={true} if invalid values for grow are passed (#9228)
  • Updated shared button styles in useEuiButtonColorCSS to use euiDisabledSelector (#9226)
  • Added euiTextTruncateCSS Emotion style utility (#9231)
  • Added hasBackground prop on EuiTable, EuiBasicTable and EuiInMemoryTable (#9224)
  • Added component token components.tableFooterBackground (#9224)
  • Updated the color of mobile table header cells to use colors.textSubdued (#9224)
  • Updated EuiSuperDatePicker to show a tooltip with the full range details when the button displays a pretty duration e.g. "Last 15 minutes" (#9221)
  • Updated EuiPopover default prop values of hasArrow, position and offset: (#9218)
    • Changed hasArrow to false
    • Changed position to downLeft
    • Changed offset to 4 when hasArrow=false
  • Updated EuiInputPopover offset default value to 2 (#9218)
  • Updated EuiTourStep to not apply hasArrow=true by default when decoration="none" (#9218)
  • Updated EuiSuperDatePicker to have a more forgiving manual input for absolute dates. (#9199)

Bug fixes

  • Updated EuiButtonGroup disabled style selectors to use euiDisabledSelector to ensure high contrast mode styles apply correctly (#9226)
  • Updated EuiSuperDatePicker to ensure its pretty format button dates are truncated correctly (#9231)
  • Fixed a visual bug for mobile table action buttons that causes shifting positions when changing color mode (#8231) (#9224)

Accessibility

  • Improved the navigation of sibling EuiToolTip anchor elements in NVDA browse mode by adding an id to ensure they are unique (#9208)

@elastic/eui-theme-borealis v5.1.0

  • Added component token components.tableFooterBackground (#9224)

@weronikaolejniczak weronikaolejniczak self-assigned this Nov 24, 2025
@weronikaolejniczak weronikaolejniczak added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting labels Nov 24, 2025
@weronikaolejniczak weronikaolejniczak force-pushed the update-eui-to-109.2.0 branch 3 times, most recently from 08371e5 to 36eae73 Compare November 25, 2025 16:09
@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review November 25, 2025 19:02
@weronikaolejniczak weronikaolejniczak requested review from a team as code owners November 25, 2025 19:02
@weronikaolejniczak weronikaolejniczak requested a review from a team November 25, 2025 19:02
@weronikaolejniczak weronikaolejniczak requested review from a team as code owners November 25, 2025 19:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM!

Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session_view changes LGTM

Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Entity analytics UIs all LGTM 🚀

@jsanz jsanz force-pushed the update-eui-to-109.2.0 branch from 79109ab to 4cd0e1e Compare November 27, 2025 16:28
Copy link
Contributor

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to maps look good to me now

@mgadewoll mgadewoll requested a review from a team as a code owner December 1, 2025 11:26
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 492.2KB 492.5KB +318.0B
dashboard 698.5KB 698.8KB +318.0B
kubernetesSecurity 215.6KB 216.0KB +318.0B
maps 3.1MB 3.1MB +344.0B
ml 5.6MB 5.6MB +320.0B
visTypeVega 2.0MB 2.0MB +318.0B
total +1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.4MB 6.4MB +2.1KB

History

cc @weronikaolejniczak

Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine changes LGTM; sorry for the slow review here.

I was digging into the changes to anomaly_score.tsx and believe it's actually dead code, but: that's a separate issue it looks good 👍 .

:shipit:

@mgadewoll mgadewoll merged commit 79be3fb into elastic:main Dec 2, 2025
13 checks passed
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Dec 2, 2025
- `@elastic/eui`: `v109.1.0` ⏩ `v109.2.0`
- `@elastic/eui-theme-borealis`: `v5.0.0` ⏩ `v5.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## Changes

- Only snapshot updates related to EuiPopover, ToolTip and Table changes
(see below)

## Package updates

### `@elastic/eui` v109.2.0

- Updated `EuiFlexItem` to fall back to `grow={true}` if invalid values
for `grow` are passed
([elastic#9228](elastic/eui#9228))
- Updated shared button styles in `useEuiButtonColorCSS` to use
`euiDisabledSelector`
([elastic#9226](elastic/eui#9226))
- Added `euiTextTruncateCSS` Emotion style utility
([elastic#9231](elastic/eui#9231))
- Added `hasBackground` prop on `EuiTable`, `EuiBasicTable` and
`EuiInMemoryTable` ([elastic#9224](elastic/eui#9224))
- Added component token `components.tableFooterBackground`
([elastic#9224](elastic/eui#9224))
- Updated the color of mobile table header cells to use
`colors.textSubdued` ([elastic#9224](elastic/eui#9224))
- Updated `EuiSuperDatePicker` to show a tooltip with the full range
details when the button displays a pretty duration e.g. "Last 15
minutes" ([elastic#9221](elastic/eui#9221))
- Updated `EuiPopover` default prop values of `hasArrow`, `position` and
`offset`: ([elastic#9218](elastic/eui#9218))
  - Changed `hasArrow` to `false`
  - Changed `position` to `downLeft`
  - Changed `offset` to `4` when `hasArrow=false`
- Updated `EuiInputPopover` `offset` default value to `2`
([elastic#9218](elastic/eui#9218))
- Updated `EuiTourStep` to not apply `hasArrow=true` by default when
`decoration="none"` ([elastic#9218](elastic/eui#9218))
- Updated `EuiSuperDatePicker` to have a more forgiving manual input for
absolute dates. ([elastic#9199](elastic/eui#9199))

**Bug fixes**

- Updated EuiButtonGroup disabled style selectors to use
`euiDisabledSelector` to ensure high contrast mode styles apply
correctly ([elastic#9226](elastic/eui#9226))
- Updated `EuiSuperDatePicker` to ensure its pretty format button dates
are truncated correctly
([elastic#9231](elastic/eui#9231))
- Fixed a visual bug for mobile table action buttons that causes
shifting positions when changing color mode
([elastic#8231](elastic/eui#8231))
([elastic#9224](elastic/eui#9224))

**Accessibility**

- Improved the navigation of sibling `EuiToolTip` anchor elements in
NVDA browse mode by adding an `id` to ensure they are unique
([elastic#9208](elastic/eui#9208))

### `@elastic/eui-theme-borealis` v5.1.0

- Added component token `components.tableFooterBackground`
([elastic#9224](elastic/eui#9224))

---------

Co-authored-by: Jorge Sanz <[email protected]>
Co-authored-by: Lene Gadewoll <[email protected]>
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request Dec 3, 2025
…ck on its content (after this recent EUI PR elastic#244032 changed the default offset to 4)
PhilippeOberti added a commit that referenced this pull request Dec 3, 2025
…ck on its content (#245162)

## Summary

This PR fixes a UI issue with the `kbn-cell-actions` rendering in hover
mode. A recent [EUI PR](#244032)
made a change to the default `offset` value:

### Context

```
- Updated EuiPopover default prop values of hasArrow, position and offset: (elastic/eui#9218)
  - Changed hasArrow to false
  - Changed position to downLeft
  - Changed offset to 4 when hasArrow=false
``` 

This offset change ended up making our cell actions almost unusable, as
the gap that is now present between the hovered content and the content
of the `EuiPopover` is not 4 pixels (instead of previously 0). This
means that when leaving the hovered content and before reaching the
`EuiPopover` content, the popover is actually being removed...

Before the EUI `109.2.0` commit


https://github.com/user-attachments/assets/4ff1e2ef-38cc-486e-a236-1df400b2a5d0

Right at the EUI `109.2.0` commit


https://github.com/user-attachments/assets/e4af2ca6-36fc-48e9-aee7-c8a9fc00ede3

### Solution

Add `offset={0}` to the `EuiPopover` in the `kbn-cell-actions` package.
That way we do not have to change the UI and the correct behavior is
restored.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
mgadewoll added a commit that referenced this pull request Dec 5, 2025
## Summary

This PR is a follow-up to changes added in
#244032

EUI updated the default `offset` value for `EuiPopover` to `4` when
`hasArrow=false` (set as default).
This results in the popover closing unexpectedly when the popover has
custom closing behavior on `onMouseLeave` due to the `4px` gap between
the trigger and the panel elements.

>[!NOTE]
`EuiPopover` currently does not support open/close behavior on
mouseenter/mouseleave due to general accessibility concerns
([docs](https://eui.elastic.co/v109.1.0/docs/components/containers/popover/)).
The implementations use custom functionality which is not considered by
the default `offset` value.

### Changes

- updates `offset` to `0` for `EuiPopover` usages that apply custom
open/close behavior on mouseenter/mouseleave

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
- `@elastic/eui`: `v109.1.0` ⏩ `v109.2.0`
- `@elastic/eui-theme-borealis`: `v5.0.0` ⏩ `v5.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## Changes

- Only snapshot updates related to EuiPopover, ToolTip and Table changes
(see below)

## Package updates

### `@elastic/eui` v109.2.0

- Updated `EuiFlexItem` to fall back to `grow={true}` if invalid values
for `grow` are passed
([elastic#9228](elastic/eui#9228))
- Updated shared button styles in `useEuiButtonColorCSS` to use
`euiDisabledSelector`
([elastic#9226](elastic/eui#9226))
- Added `euiTextTruncateCSS` Emotion style utility
([elastic#9231](elastic/eui#9231))
- Added `hasBackground` prop on `EuiTable`, `EuiBasicTable` and
`EuiInMemoryTable` ([elastic#9224](elastic/eui#9224))
- Added component token `components.tableFooterBackground`
([elastic#9224](elastic/eui#9224))
- Updated the color of mobile table header cells to use
`colors.textSubdued` ([elastic#9224](elastic/eui#9224))
- Updated `EuiSuperDatePicker` to show a tooltip with the full range
details when the button displays a pretty duration e.g. "Last 15
minutes" ([elastic#9221](elastic/eui#9221))
- Updated `EuiPopover` default prop values of `hasArrow`, `position` and
`offset`: ([elastic#9218](elastic/eui#9218))
  - Changed `hasArrow` to `false`
  - Changed `position` to `downLeft`
  - Changed `offset` to `4` when `hasArrow=false`
- Updated `EuiInputPopover` `offset` default value to `2`
([elastic#9218](elastic/eui#9218))
- Updated `EuiTourStep` to not apply `hasArrow=true` by default when
`decoration="none"` ([elastic#9218](elastic/eui#9218))
- Updated `EuiSuperDatePicker` to have a more forgiving manual input for
absolute dates. ([elastic#9199](elastic/eui#9199))

**Bug fixes**

- Updated EuiButtonGroup disabled style selectors to use
`euiDisabledSelector` to ensure high contrast mode styles apply
correctly ([elastic#9226](elastic/eui#9226))
- Updated `EuiSuperDatePicker` to ensure its pretty format button dates
are truncated correctly
([elastic#9231](elastic/eui#9231))
- Fixed a visual bug for mobile table action buttons that causes
shifting positions when changing color mode
([elastic#8231](elastic/eui#8231))
([elastic#9224](elastic/eui#9224))

**Accessibility**

- Improved the navigation of sibling `EuiToolTip` anchor elements in
NVDA browse mode by adding an `id` to ensure they are unique
([elastic#9208](elastic/eui#9208))

### `@elastic/eui-theme-borealis` v5.1.0

- Added component token `components.tableFooterBackground`
([elastic#9224](elastic/eui#9224))

---------

Co-authored-by: Jorge Sanz <[email protected]>
Co-authored-by: Lene Gadewoll <[email protected]>
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
…ck on its content (elastic#245162)

## Summary

This PR fixes a UI issue with the `kbn-cell-actions` rendering in hover
mode. A recent [EUI PR](elastic#244032)
made a change to the default `offset` value:

### Context

```
- Updated EuiPopover default prop values of hasArrow, position and offset: (elastic/eui#9218)
  - Changed hasArrow to false
  - Changed position to downLeft
  - Changed offset to 4 when hasArrow=false
``` 

This offset change ended up making our cell actions almost unusable, as
the gap that is now present between the hovered content and the content
of the `EuiPopover` is not 4 pixels (instead of previously 0). This
means that when leaving the hovered content and before reaching the
`EuiPopover` content, the popover is actually being removed...

Before the EUI `109.2.0` commit


https://github.com/user-attachments/assets/4ff1e2ef-38cc-486e-a236-1df400b2a5d0

Right at the EUI `109.2.0` commit


https://github.com/user-attachments/assets/e4af2ca6-36fc-48e9-aee7-c8a9fc00ede3

### Solution

Add `offset={0}` to the `EuiPopover` in the `kbn-cell-actions` package.
That way we do not have to change the UI and the correct behavior is
restored.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
)

## Summary

This PR is a follow-up to changes added in
elastic#244032

EUI updated the default `offset` value for `EuiPopover` to `4` when
`hasArrow=false` (set as default).
This results in the popover closing unexpectedly when the popover has
custom closing behavior on `onMouseLeave` due to the `4px` gap between
the trigger and the panel elements.

>[!NOTE]
`EuiPopover` currently does not support open/close behavior on
mouseenter/mouseleave due to general accessibility concerns
([docs](https://eui.elastic.co/v109.1.0/docs/components/containers/popover/)).
The implementations use custom functionality which is not considered by
the default `offset` value.

### Changes

- updates `offset` to `0` for `EuiPopover` usages that apply custom
open/close behavior on mouseenter/mouseleave

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.