Skip to content

[Dataset Quality] Graceful skipping of flaky tests for slow network related timeouts#244053

Merged
awahab07 merged 5 commits intoelastic:mainfrom
awahab07:231558-fix-flaky-data-load-error
Nov 26, 2025
Merged

[Dataset Quality] Graceful skipping of flaky tests for slow network related timeouts#244053
awahab07 merged 5 commits intoelastic:mainfrom
awahab07:231558-fix-flaky-data-load-error

Conversation

@awahab07
Copy link
Copy Markdown
Contributor

@awahab07 awahab07 commented Nov 24, 2025

Fixes #231558

Summary

Skips the tests conditionally if a slow network is detected, to prevent flakiness. See for more details.

@awahab07 awahab07 requested a review from a team as a code owner November 24, 2025 18:22
@awahab07 awahab07 added release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 v9.3.0 labels Nov 24, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-onboarding-team (Team:obs-onboarding)

Copy link
Copy Markdown
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

QQ: will that be solved when this ticket is done? [Dataset quality] configuring dockerized package registry in tests or does it have no effect on it?

If so maybe lets add a comment to keep track of reverting this back when the above is done.

@awahab07
Copy link
Copy Markdown
Contributor Author

buildkite test this

@awahab07
Copy link
Copy Markdown
Contributor Author

QQ: will that be solved when this ticket is done? #234891 or does it have no effect on it?

@mohamedhamed-ahmed good point.

/dataset_quality/integrations endpoint is the slowest one which makes the dataset quality table not load and fail with

.euiBasicTable-loading was still present

#234891 should solve this or improve it and we should get a reduced number of such failures after this.

But there could be other cases where data isn't available before the timeout kicks in, failing the tests, e.g. ES is down or network is slow. Such environment issues, including the integrations one, should not count as legit flakes. So we should keeps this check even after #234891.

@awahab07
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@awahab07 awahab07 merged commit 5a4d2e4 into elastic:main Nov 26, 2025
12 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/19699038889

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2025
…elated timeouts (elastic#244053)

Skips the tests conditionally if a slow network is detected, to prevent
flakiness.
[See](elastic#231558 (comment))
for more details.

(cherry picked from commit 5a4d2e4)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2025
…elated timeouts (elastic#244053)

Skips the tests conditionally if a slow network is detected, to prevent
flakiness.
[See](elastic#231558 (comment))
for more details.

(cherry picked from commit 5a4d2e4)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2025
…elated timeouts (elastic#244053)

Skips the tests conditionally if a slow network is detected, to prevent
flakiness.
[See](elastic#231558 (comment))
for more details.

(cherry picked from commit 5a4d2e4)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.19
9.1
9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 26, 2025
…work related timeouts (#244053) (#244297)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Dataset Quality] Graceful skipping of flaky tests for slow network
related timeouts
(#244053)](#244053)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Abdul Wahab
Zahid","email":"awahab07@yahoo.com"},"sourceCommit":{"committedDate":"2025-11-26T09:33:47Z","message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more
details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-onboarding","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.3.0"],"title":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts","number":244053,"url":"https://github.com/elastic/kibana/pull/244053","mergeCommit":{"message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more
details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.2"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244053","number":244053,"mergeCommit":{"message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732"}}]}]
BACKPORT-->

Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
kibanamachine added a commit that referenced this pull request Nov 26, 2025
…work related timeouts (#244053) (#244298)

# Backport

This will backport the following commits from `main` to `9.2`:
- [[Dataset Quality] Graceful skipping of flaky tests for slow network
related timeouts
(#244053)](#244053)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Abdul Wahab
Zahid","email":"awahab07@yahoo.com"},"sourceCommit":{"committedDate":"2025-11-26T09:33:47Z","message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more
details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-onboarding","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.3.0"],"title":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts","number":244053,"url":"https://github.com/elastic/kibana/pull/244053","mergeCommit":{"message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more
details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.2"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244053","number":244053,"mergeCommit":{"message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732"}}]}]
BACKPORT-->

Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
kibanamachine added a commit that referenced this pull request Nov 26, 2025
…twork related timeouts (#244053) (#244296)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Dataset Quality] Graceful skipping of flaky tests for slow network
related timeouts
(#244053)](#244053)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Abdul Wahab
Zahid","email":"awahab07@yahoo.com"},"sourceCommit":{"committedDate":"2025-11-26T09:33:47Z","message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more
details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-onboarding","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.3.0"],"title":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts","number":244053,"url":"https://github.com/elastic/kibana/pull/244053","mergeCommit":{"message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more
details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.2"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244053","number":244053,"mergeCommit":{"message":"[Dataset
Quality] Graceful skipping of flaky tests for slow network related
timeouts (#244053)\n\nSkips the tests conditionally if a slow network is
detected, to
prevent\nflakiness.\n[See](https://github.com/elastic/kibana/issues/231558#issuecomment-3571750911)\nfor
more details.","sha":"5a4d2e4dd039e441bf1fb1c302275d87e4d60732"}}]}]
BACKPORT-->

Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Dec 2, 2025
…elated timeouts (elastic#244053)

Skips the tests conditionally if a slow network is detected, to prevent
flakiness.
[See](elastic#231558 (comment))
for more details.
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
…elated timeouts (elastic#244053)

Skips the tests conditionally if a slow network is detected, to prevent
flakiness.
[See](elastic#231558 (comment))
for more details.
flash1293 added a commit that referenced this pull request Dec 10, 2025
Fixes #233620

By rolling out the fix from
#244053 to this test as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team v8.19.0 v8.19.8 v9.1.0 v9.1.8 v9.2.0 v9.2.2 v9.3.0

Projects

None yet

4 participants