[Dataset quality] configuring dockerized package registry in tests#234891
Closed
yngrdyn wants to merge 15 commits intoelastic:mainfrom
Closed
[Dataset quality] configuring dockerized package registry in tests#234891yngrdyn wants to merge 15 commits intoelastic:mainfrom
yngrdyn wants to merge 15 commits intoelastic:mainfrom
Conversation
botelastic
Bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
yngrdyn
added
release_note:skip
mohamedhamed-ahmed
approved these changes
Sep 12, 2025
Contributor
mohamedhamed-ahmed
left a comment
mohamedhamed-ahmed
left a comment
There was a problem hiding this comment.
LGTM! Great job spotting this 🤞 hope this makes our tests less flaky
This was referenced Sep 15, 2025
jennypavlova
approved these changes
Sep 16, 2025
Member
jennypavlova
left a comment
jennypavlova
left a comment
There was a problem hiding this comment.
LGTM 🚀 Thank you for fixing that!
yngrdyn
commented
Sep 16, 2025
| const bitbucketDatasetName = 'atlassian_bitbucket.audit'; | ||
| const bitbucketAuditDataStreamName = `logs-${bitbucketDatasetName}-${defaultNamespace}`; | ||
| const bitbucketPkg = { | ||
| name: 'atlassian_bitbucket', |
Contributor
Author
There was a problem hiding this comment.
atlassian_bitbucket is not part of distribution:lite docker
yngrdyn
commented
Sep 16, 2025
| `--server.publicBaseUrl=${kbnUrl}`, | ||
| // Allow dynamic config overrides in tests | ||
| `--coreApp.allowDynamicConfigOverrides=true`, | ||
| ...(dockerRegistryPort |
Contributor
Author
There was a problem hiding this comment.
@dmlemeshko this configuration was not set before the changes so I'm not sure the docker was being used
Do you know if that was the case?
And I believe that's why all scout tests are failing.
Does scout needs this configuration to query the local package registry?
yngrdyn
commented
Sep 16, 2025
| `--permissionsPolicy.report_to=${JSON.stringify(['violations-endpoint'])}`, | ||
| // Allow dynamic config overrides in tests | ||
| `--coreApp.allowDynamicConfigOverrides=true`, | ||
| ...(dockerRegistryPort |
This was
linked to
issues
Sep 23, 2025
seanrathier
approved these changes
Oct 14, 2025
…age-registry-in-tests
Contributor
Contributor
|
closing this and opening a new PR to carry on the work there as this is already too old to fix the conflicts. [Dataset quality] configuring dockerized package registry in tests |
mohamedhamed-ahmed
added a commit
that referenced
this pull request
Jan 23, 2026
…250040) ## Summary We have been dealing with a lot of flakiness in our tests due to package registry not being available, this PR changes the package registery being used to the dockerized one in Dataset Quality. As well as centralizing its usage in kbn-test package so that it can later on be used from a central place by other teams instead of duplicating it in every test suite. This is work continuation for [[Dataset quality] configuring dockerized package registry in tests](#234891).
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 23, 2026
…lastic#250040) ## Summary We have been dealing with a lot of flakiness in our tests due to package registry not being available, this PR changes the package registery being used to the dockerized one in Dataset Quality. As well as centralizing its usage in kbn-test package so that it can later on be used from a central place by other teams instead of duplicating it in every test suite. This is work continuation for [[Dataset quality] configuring dockerized package registry in tests](elastic#234891). (cherry picked from commit 8902479)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 23, 2026
…lastic#250040) ## Summary We have been dealing with a lot of flakiness in our tests due to package registry not being available, this PR changes the package registery being used to the dockerized one in Dataset Quality. As well as centralizing its usage in kbn-test package so that it can later on be used from a central place by other teams instead of duplicating it in every test suite. This is work continuation for [[Dataset quality] configuring dockerized package registry in tests](elastic#234891). (cherry picked from commit 8902479)
mohamedhamed-ahmed
added a commit
to mohamedhamed-ahmed/kibana
that referenced
this pull request
Jan 24, 2026
…lastic#250040) ## Summary We have been dealing with a lot of flakiness in our tests due to package registry not being available, this PR changes the package registery being used to the dockerized one in Dataset Quality. As well as centralizing its usage in kbn-test package so that it can later on be used from a central place by other teams instead of duplicating it in every test suite. This is work continuation for [[Dataset quality] configuring dockerized package registry in tests](elastic#234891). (cherry picked from commit 8902479) # Conflicts: # x-pack/platform/test/api_integration_deployment_agnostic/default_configs/feature_flag.serverless.config.base.ts # x-pack/platform/test/api_integration_deployment_agnostic/default_configs/serverless.config.base.ts # x-pack/solutions/observability/test/functional/config.base.ts
mohamedhamed-ahmed
added a commit
to mohamedhamed-ahmed/kibana
that referenced
this pull request
Jan 24, 2026
…lastic#250040) ## Summary We have been dealing with a lot of flakiness in our tests due to package registry not being available, this PR changes the package registery being used to the dockerized one in Dataset Quality. As well as centralizing its usage in kbn-test package so that it can later on be used from a central place by other teams instead of duplicating it in every test suite. This is work continuation for [[Dataset quality] configuring dockerized package registry in tests](elastic#234891). (cherry picked from commit 8902479) # Conflicts: # x-pack/platform/test/api_integration_deployment_agnostic/default_configs/feature_flag.serverless.config.base.ts # x-pack/platform/test/api_integration_deployment_agnostic/default_configs/serverless.config.base.ts # x-pack/solutions/observability/test/functional/config.base.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233620, #234087, #235057, #235275, #235633, #235723
We have been dealing with a lot of flakiness in our tests due to package registry not being available, after checking the configs I discovered we are not using the dockerized package registry, we are only using it in our api tests (which seems to be more stable).
This PR aims to use dockerized package registry for all our tests.
As a stretch goal of this PR, I agreed with @dmlemeshko to centralize the package-registry config into
@kbn/testsince was duplicated all over the place and it also benefit other teams, special configuration can be still added insidedefineDockerServersConfigand overriden for special cases