[9.2] [Search] Disable custom suggestion on embedded console (#241516)#243376
Merged
wildemat merged 1 commit intoelastic:9.2from Nov 19, 2025
Merged
[9.2] [Search] Disable custom suggestion on embedded console (#241516)#243376wildemat merged 1 commit intoelastic:9.2from
wildemat merged 1 commit intoelastic:9.2from
Conversation
### Summary **Problem**: In the embedded console, the error & suggestion widget is misplaced. Currently `fixedOverflowWidgets` prop of monaco editor is set to `true` and the suggestion widget css is calculated to prevent widget being placed under header in Dashboard, ES|QL. In this PR, the customized css would be applied only if it's not a embeddable console. ### Changes - create new prop within the `UseBug223981FixRepositionSuggestWidget` called `enableSuggestWidgetRepositioning` - default this prop to `true` except for within the embedded console ### Screen recording **recording of error in embedded console vs standalone dev console** https://github.com/user-attachments/assets/f88f0124-bdb2-4aaf-b66a-0c91ec1587dc **fix in embedded console vs standalone dev console** https://github.com/user-attachments/assets/827a8ded-50cf-4f0b-b07a-3c2c2dd1741c ### Testing open dev console and create a empty query to generate suggestion widget & error message. --------- Co-authored-by: Matt Wilde <matt.wilde@elastic.co> (cherry picked from commit 9cd3222) # Conflicts: # src/platform/plugins/shared/console/public/application/containers/editor/editor.tsx # src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor.tsx
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
kapral18
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation