[Search] Disable custom suggestion on embedded console#241516
Merged
wildemat merged 9 commits intoelastic:mainfrom Nov 17, 2025
Merged
[Search] Disable custom suggestion on embedded console#241516wildemat merged 9 commits intoelastic:mainfrom
wildemat merged 9 commits intoelastic:mainfrom
Conversation
saarikabhasi
force-pushed
the
fix/embeddedConsole-code-editor
branch
from
f6a52ac to
3f70a42
Compare
eokoneyo
reviewed
Nov 3, 2025
src/platform/packages/shared/shared-ux/code_editor/impl/code_editor.tsx
Outdated
Show resolved
Hide resolved
wildemat
changed the title
wildemat
added
release_note:fix
backport:version
Contributor
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
eokoneyo
reviewed
Nov 11, 2025
Contributor
|
@elasticmachine merge upstream |
damian-polewski
approved these changes
Nov 17, 2025
Contributor
|
Starting backport for target branches: 9.2 https://github.com/elastic/kibana/actions/runs/19435729502 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
|
Hey there @wildemat, we're looking to backport #240921 (comment) to Are you still intending for this to be backported to |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
@spong apologies for the delay. Created backport PR with conflict resolutions |
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Nov 18, 2025
### Summary **Problem**: In the embedded console, the error & suggestion widget is misplaced. Currently `fixedOverflowWidgets` prop of monaco editor is set to `true` and the suggestion widget css is calculated to prevent widget being placed under header in Dashboard, ES|QL. In this PR, the customized css would be applied only if it's not a embeddable console. ### Changes - create new prop within the `UseBug223981FixRepositionSuggestWidget` called `enableSuggestWidgetRepositioning` - default this prop to `true` except for within the embedded console ### Screen recording **recording of error in embedded console vs standalone dev console** https://github.com/user-attachments/assets/f88f0124-bdb2-4aaf-b66a-0c91ec1587dc **fix in embedded console vs standalone dev console** https://github.com/user-attachments/assets/827a8ded-50cf-4f0b-b07a-3c2c2dd1741c ### Testing open dev console and create a empty query to generate suggestion widget & error message. --------- Co-authored-by: Matt Wilde <matt.wilde@elastic.co> (cherry picked from commit 9cd3222) # Conflicts: # src/platform/plugins/shared/console/public/application/containers/editor/editor.tsx # src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor.tsx
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
wildemat
added a commit
that referenced
this pull request
Nov 19, 2025
#243376) # Backport This will backport the following commits from `main` to `9.2`: - [[Search] Disable custom suggestion on embedded console (#241516)](#241516) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"55930906+saarikabhasi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-11-17T15:53:06Z","message":"[Search] Disable custom suggestion on embedded console (#241516)\n\n### Summary\n**Problem**: In the embedded console, the error & suggestion widget is\nmisplaced. Currently `fixedOverflowWidgets` prop of monaco editor is set\nto `true` and the suggestion widget css is calculated to prevent widget\nbeing placed under header in Dashboard, ES|QL. In this PR, the\ncustomized css would be applied only if it's not a embeddable console.\n\n### Changes\n- create new prop within the `UseBug223981FixRepositionSuggestWidget`\ncalled `enableSuggestWidgetRepositioning`\n- default this prop to `true` except for within the embedded console\n\n### Screen recording\n**recording of error in embedded console vs standalone dev console**\n\n\nhttps://github.com/user-attachments/assets/f88f0124-bdb2-4aaf-b66a-0c91ec1587dc\n\n**fix in embedded console vs standalone dev console**\n\n\nhttps://github.com/user-attachments/assets/827a8ded-50cf-4f0b-b07a-3c2c2dd1741c\n\n\n\n### Testing\nopen dev console and create a empty query to generate suggestion widget\n& error message.\n\n---------\n\nCo-authored-by: Matt Wilde <matt.wilde@elastic.co>","sha":"9cd32222f7a234704f229a039c33417d10281d79","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","v9.2.0","v9.3.0"],"title":"[Search] Disable custom suggestion on embedded console","number":241516,"url":"https://github.com/elastic/kibana/pull/241516","mergeCommit":{"message":"[Search] Disable custom suggestion on embedded console (#241516)\n\n### Summary\n**Problem**: In the embedded console, the error & suggestion widget is\nmisplaced. Currently `fixedOverflowWidgets` prop of monaco editor is set\nto `true` and the suggestion widget css is calculated to prevent widget\nbeing placed under header in Dashboard, ES|QL. In this PR, the\ncustomized css would be applied only if it's not a embeddable console.\n\n### Changes\n- create new prop within the `UseBug223981FixRepositionSuggestWidget`\ncalled `enableSuggestWidgetRepositioning`\n- default this prop to `true` except for within the embedded console\n\n### Screen recording\n**recording of error in embedded console vs standalone dev console**\n\n\nhttps://github.com/user-attachments/assets/f88f0124-bdb2-4aaf-b66a-0c91ec1587dc\n\n**fix in embedded console vs standalone dev console**\n\n\nhttps://github.com/user-attachments/assets/827a8ded-50cf-4f0b-b07a-3c2c2dd1741c\n\n\n\n### Testing\nopen dev console and create a empty query to generate suggestion widget\n& error message.\n\n---------\n\nCo-authored-by: Matt Wilde <matt.wilde@elastic.co>","sha":"9cd32222f7a234704f229a039c33417d10281d79"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/241516","number":241516,"mergeCommit":{"message":"[Search] Disable custom suggestion on embedded console (#241516)\n\n### Summary\n**Problem**: In the embedded console, the error & suggestion widget is\nmisplaced. Currently `fixedOverflowWidgets` prop of monaco editor is set\nto `true` and the suggestion widget css is calculated to prevent widget\nbeing placed under header in Dashboard, ES|QL. In this PR, the\ncustomized css would be applied only if it's not a embeddable console.\n\n### Changes\n- create new prop within the `UseBug223981FixRepositionSuggestWidget`\ncalled `enableSuggestWidgetRepositioning`\n- default this prop to `true` except for within the embedded console\n\n### Screen recording\n**recording of error in embedded console vs standalone dev console**\n\n\nhttps://github.com/user-attachments/assets/f88f0124-bdb2-4aaf-b66a-0c91ec1587dc\n\n**fix in embedded console vs standalone dev console**\n\n\nhttps://github.com/user-attachments/assets/827a8ded-50cf-4f0b-b07a-3c2c2dd1741c\n\n\n\n### Testing\nopen dev console and create a empty query to generate suggestion widget\n& error message.\n\n---------\n\nCo-authored-by: Matt Wilde <matt.wilde@elastic.co>","sha":"9cd32222f7a234704f229a039c33417d10281d79"}}]}] BACKPORT--> Co-authored-by: Saarika Bhasi <55930906+saarikabhasi@users.noreply.github.com>
kibanamachine
added
v9.2.2
and removed
backport missing
Contributor
|
Backport pr has been merged @spong |
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
### Summary **Problem**: In the embedded console, the error & suggestion widget is misplaced. Currently `fixedOverflowWidgets` prop of monaco editor is set to `true` and the suggestion widget css is calculated to prevent widget being placed under header in Dashboard, ES|QL. In this PR, the customized css would be applied only if it's not a embeddable console. ### Changes - create new prop within the `UseBug223981FixRepositionSuggestWidget` called `enableSuggestWidgetRepositioning` - default this prop to `true` except for within the embedded console ### Screen recording **recording of error in embedded console vs standalone dev console** https://github.com/user-attachments/assets/f88f0124-bdb2-4aaf-b66a-0c91ec1587dc **fix in embedded console vs standalone dev console** https://github.com/user-attachments/assets/827a8ded-50cf-4f0b-b07a-3c2c2dd1741c ### Testing open dev console and create a empty query to generate suggestion widget & error message. --------- Co-authored-by: Matt Wilde <matt.wilde@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem: In the embedded console, the error & suggestion widget is misplaced. Currently
fixedOverflowWidgetsprop of monaco editor is set totrueand the suggestion widget css is calculated to prevent widget being placed under header in Dashboard, ES|QL. In this PR, the customized css would be applied only if it's not a embeddable console.Changes
UseBug223981FixRepositionSuggestWidgetcalledenableSuggestWidgetRepositioningtrueexcept for within the embedded consoleScreen recording
recording of error in embedded console vs standalone dev console
without.change-.Before.mov
fix in embedded console vs standalone dev console
After.removing.custom.css.calc.mov
Testing
open dev console and create a empty query to generate suggestion widget & error message.