Skip to content

[Chrome Grid] Fix printing regression#243081

Merged
Dosant merged 3 commits intoelastic:mainfrom
Dosant:d/2025-11-14-fix-printing-regression
Nov 17, 2025
Merged

[Chrome Grid] Fix printing regression#243081
Dosant merged 3 commits intoelastic:mainfrom
Dosant:d/2025-11-14-fix-printing-regression

Conversation

@Dosant
Copy link
Copy Markdown
Contributor

@Dosant Dosant commented Nov 14, 2025

Summary

fix #243071

Looks like for pdf printing to work, we need to force the full page rendering in print mode.
This was my intention to not break regular browser printing, but looks like it regressed with some of the recent changes

Note

Currently, on main, there is a different problem with PDF w/print, which will be resolved when #242780 is merged. Without this fix, PDF w/print reports will time out and produce a completely empty report.

@Dosant Dosant requested a review from a team as a code owner November 14, 2025 17:01
@Dosant Dosant requested a review from pmuellr November 14, 2025 17:03
@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Nov 14, 2025
@Dosant Dosant requested a review from tsullivan November 14, 2025 17:20
Copy link
Copy Markdown
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out, on top of #242780, and it generated the Web Log sample dash in PDF, PDF/print, and PNG.

@Dosant Dosant enabled auto-merge (squash) November 15, 2025 13:21
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 506.2KB 506.2KB +30.0B

History

@Dosant Dosant added the chrome-grid Work related to Chrome refactor to grid layout label Nov 17, 2025
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM reviewed the code only

@Dosant Dosant merged commit 4c97766 into elastic:main Nov 17, 2025
14 checks passed
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting chrome-grid Work related to Chrome refactor to grid layout release_note:skip Skip the PR/issue when compiling release notes v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Reporting] PDF w/print generates single page report with new grid layout

5 participants