Fix print mode regression in Dashboard#242780
Conversation
|
/ci |
There was a problem hiding this comment.
We were hoping this would fix generating a PDF with print format on, which is currently broken on main. Before this PR, the report would time out.
Now, it doesn't time out, but the report it generates only contains the first visualization. I always test with the Web Logs sample data, with the dashboard it provides, and generate a report from that.
Perhaps there is some else needed on the reporting side ...
|
@pmuellr I'm not seeing this behaviour. On my end the PDF report with print format on generates correctly. |
|
hahahaha ... I still had my config for testing the new grid layout feature_flags.overrides:
core.chrome.layoutType: 'grid'Once I removed that, all the panels come in. Will do a complete review (I just tried the code out before). I guess that means the grid layout likely breaks pdf/print, which I was waiting for this PR, to unblock testing it :-) |
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, works with PNG, PDF, and what was broken PDF/print
ThomThomson
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
skips pausing the fetch when in print mode. Controls are never rendered in Print mode, so the control group is never set.
4 participants
Summary
Fixes #242741 by not pausing the fetch when in print mode. Controls are never rendered in Print mode, so the control group is never set.
Backport skipped because the PR that caused the issue was not backported.